Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose starting time in mock_ElectricalSeries #1805

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Dec 18, 2023

Motivation

The starting_time is exposed in all the mock methods but for some reason not in mock_ElectricalSeries. I needed this recently in a test in spike interface so I am pushing it here in case you want to add it.

I also realized that the mock_OnePhotonSeries function has offset exposed but not propagated whereas mock_TwoPhotonSeries had neither of them. I did this as well.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b5621) 91.99% compared to head (6598cdc) 83.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1805      +/-   ##
==========================================
- Coverage   91.99%   83.68%   -8.32%     
==========================================
  Files          27       27              
  Lines        2623     2623              
  Branches      685      685              
==========================================
- Hits         2413     2195     -218     
- Misses        138      344     +206     
- Partials       72       84      +12     
Flag Coverage Δ
integration ?
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-mayorquin h-mayorquin marked this pull request as ready for review December 18, 2023 10:42
@rly rly enabled auto-merge (squash) December 22, 2023 00:41
@rly rly merged commit 6498000 into NeurodataWithoutBorders:dev Dec 22, 2023
21 of 23 checks passed
@h-mayorquin h-mayorquin deleted the expose_starting_time_into_mock_objects branch April 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants