Fix validation in NWB testing util classes #1782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
validate
function in thepynwb.testing.testh5io
classes was not validating the exported file and was using the olderpynwb_validate(io=io)
which validates against the core namespace instead of all leaves of the namespace hierarchy if extensions are present. The newerpynwb_validate(paths=[...])
syntax should be used instead.Also update the write functions to cache the spec by default.
How to test the behavior?
Checklist
flake8
from the source directory.