Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to read first NWB file from each dandiset #1695

Merged
merged 10 commits into from
May 25, 2023
Merged

Add CI to read first NWB file from each dandiset #1695

merged 10 commits into from
May 25, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented May 25, 2023

Motivation

This adds a quick version of https://github.com/dandi/dandisets-healthstatus

Currently it takes under two hours to read an NWB file from all 158 dandisets with NWB files on DANDI. The max GitHub Actions runtime is 6 hours.
Note that some reads may time out.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1695 (0edb290) into dev (89d9e04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1695   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          26       26           
  Lines        2592     2592           
  Branches      679      679           
=======================================
  Hits         2383     2383           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.52% <ø> (ø)
unit 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

oruebel
oruebel previously approved these changes May 25, 2023
@rly rly requested a review from oruebel May 25, 2023 18:28
oruebel
oruebel previously approved these changes May 25, 2023
@rly
Copy link
Contributor Author

rly commented May 25, 2023

Sorry @oruebel I had a flake8 error. Can you reapprove?

@rly rly requested a review from oruebel May 25, 2023 20:11
@rly rly merged commit a6fa917 into dev May 25, 2023
@rly rly deleted the add_dandi_read_ci branch May 25, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants