Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare PyNWB 2.3.2 #1672

Merged
merged 19 commits into from
Apr 11, 2023
Merged

Prepare PyNWB 2.3.2 #1672

merged 19 commits into from
Apr 11, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Mar 20, 2023

Prepare for release of PyNWB 2.3.2

Before merging:

  • Major and minor releases: Update package versions in requirements.txt, requirements-dev.txt,
    requirements-doc.txt, requirements-min.txt, setup.py as needed
    See https://requires.io/github/NeurodataWithoutBorders/pynwb/requirements/?branch=dev
  • Check legal file dates and information in Legal.txt, license.txt, README.rst, docs/source/conf.py,
    and any other locations as needed
  • Update setup.py as needed
  • Update README.rst as needed
  • Update src/pynwb/nwb-schema submodule as needed. Check the version number and commit SHA manually
  • Update changelog (set release date) in CHANGELOG.md and any other docs as needed
  • Run tests locally including gallery, validation, and streaming tests, and inspect all warnings and outputs
    (python test.py -v -p -i -b -w -r > out.txt 2>&1)
  • Test docs locally (make clean, make html)
  • Push changes to this PR and make sure all PRs to be included in this release have been merged
  • Check that the readthedocs build for this PR succeeds (build latest to pull the new branch, then activate and
    build docs for new branch): https://readthedocs.org/projects/pynwb/builds/

After merging:

  1. Create release by following steps in docs/source/make_a_release.rst or use alias git pypi-release [tag] if set up
  2. After the CI bot creates the new release (wait ~10 min), update the release notes on the
    GitHub releases page with the changelog
  3. Check that the readthedocs "latest" and "stable" builds run and succeed
  4. Update conda-forge/pynwb-feedstock with the latest version number
    and SHA256 retrieved from PyPI > PyNWB > Download Files > View hashes for the .tar.gz file. Re-render as needed

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1672 (e2676af) into dev (d4e946d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1672   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          26       26           
  Lines        2592     2592           
  Branches      477      477           
=======================================
  Hits         2383     2383           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.52% <ø> (ø)
unit 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly marked this pull request as ready for review April 11, 2023 06:31
@rly rly requested review from bendichter and oruebel April 11, 2023 06:34
bendichter
bendichter previously approved these changes Apr 11, 2023
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rly rly requested a review from bendichter April 11, 2023 20:47
@rly
Copy link
Contributor Author

rly commented Apr 11, 2023

Sorry, I missed a change to fix the recent numpy deprecations. @bendichter can you please reapprove?

@rly rly merged commit de7f474 into dev Apr 11, 2023
@rly rly deleted the prepare_2.3.2 branch April 11, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants