-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 1p ophys tutorial #1658
Adding 1p ophys tutorial #1658
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1658 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 26 26
Lines 2592 2592
Branches 497 497
=======================================
Hits 2383 2383
Misses 134 134
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fix problem with value checking inside OnePhotonSeries class
…dding_1p_ophys_tutorial
Traceback (most recent call last):
File "test.py", line 115, in __run_example_tests_helper
_import_from_file(script)
File "test.py", line 63, in _import_from_file
return imp.load_source(os.path.basename(script), script)
File "/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/imp.py", line 171, in load_source
module = _load(spec)
File "<frozen importlib._bootstrap>", line 696, in _load
File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 728, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "docs/gallery/domain/ophys.py", line 31, in <module>
from pynwb.ophys import (
ImportError: cannot import name 'OnePhotonSeries' from 'pynwb.ophys' (/home/runner/work/pynwb/pynwb/.tox/gallery-py37-minimum/lib/python3.7/site-packages/pynwb/ophys.py) not sure why I am getting this error. The file runs fine locally. |
Not sure, but it looks like maybe the workflow is for some reason installing PyNWB 2.2 @mavaylon1 @rly looking at https://anaconda.org/conda-forge/pynwb it looks like PyNWB 2.3 may not be released on conda? |
Are the docs tests using a conda release instead of installing from the PR? In that case, even after the conda release is fixed, this PR will still fail because the tutorials requires a minor fix to the API. I suppose I could separate that into another PR. |
I believe #1679 is affecting the CI errors. |
Motivation
OnePhotonSeries
to tutorial ophys tutorialChecklist
flake8
from the source directory.