Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 1p ophys tutorial #1658

Merged
merged 12 commits into from
Mar 27, 2023
Merged

Adding 1p ophys tutorial #1658

merged 12 commits into from
Mar 27, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Mar 8, 2023

Motivation

  • Add OnePhotonSeries to tutorial ophys tutorial
  • Improve styling, fix some links, and move ophys tutorial towards current best practices

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter requested a review from oruebel March 8, 2023 20:41
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1658 (18d41d7) into dev (5b7766b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1658   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          26       26           
  Lines        2592     2592           
  Branches      497      497           
=======================================
  Hits         2383     2383           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.52% <ø> (ø)
unit 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bendichter
Copy link
Contributor Author

Traceback (most recent call last):
  File "test.py", line 115, in __run_example_tests_helper
    _import_from_file(script)
  File "test.py", line 63, in _import_from_file
    return imp.load_source(os.path.basename(script), script)
  File "/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "docs/gallery/domain/ophys.py", line 31, in <module>
    from pynwb.ophys import (
ImportError: cannot import name 'OnePhotonSeries' from 'pynwb.ophys' (/home/runner/work/pynwb/pynwb/.tox/gallery-py37-minimum/lib/python3.7/site-packages/pynwb/ophys.py)

not sure why I am getting this error. The file runs fine locally.

@oruebel
Copy link
Contributor

oruebel commented Mar 9, 2023

not sure why I am getting this error. The file runs fine locally.

Not sure, but it looks like maybe the workflow is for some reason installing PyNWB 2.2

https://github.com/NeurodataWithoutBorders/pynwb/actions/runs/4375905634/jobs/7657259083#step:6:447

@mavaylon1 @rly looking at https://anaconda.org/conda-forge/pynwb it looks like PyNWB 2.3 may not be released on conda?

@bendichter
Copy link
Contributor Author

Are the docs tests using a conda release instead of installing from the PR? In that case, even after the conda release is fixed, this PR will still fail because the tutorials requires a minor fix to the API. I suppose I could separate that into another PR.

@rly
Copy link
Contributor

rly commented Mar 24, 2023

I believe #1679 is affecting the CI errors.

@bendichter bendichter merged commit dd54e5a into dev Mar 27, 2023
@rly rly deleted the adding_1p_ophys_tutorial branch March 28, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants