Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of version 2.0b #1651

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Fix handling of version 2.0b #1651

merged 3 commits into from
Feb 25, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 24, 2023

Motivation

Fix #1650. In the history of NWB 2.x files, I have found that only version "2.0b" does not follow the X.Y.Z format of semantic versioning. This patch covers that use case while not making the code terribly complicated.

How to test the behavior?

Run tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1651 (f3e1751) into dev (1dc9125) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1651      +/-   ##
==========================================
+ Coverage   91.97%   91.99%   +0.01%     
==========================================
  Files          26       26              
  Lines        2581     2585       +4     
  Branches      494      496       +2     
==========================================
+ Hits         2374     2378       +4     
  Misses        132      132              
  Partials       75       75              
Flag Coverage Δ
integration 71.52% <100.00%> (+0.04%) ⬆️
unit 83.67% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/io/utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly requested a review from bendichter February 24, 2023 22:54
@rly rly merged commit 26538b3 into dev Feb 25, 2023
@rly rly deleted the fix_version branch April 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: regression in 2.3.0 leading to IndexError
2 participants