Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Images in stimulus templates #1638

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Allow Images in stimulus templates #1638

merged 4 commits into from
Jan 24, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 19, 2023

Motivation

Fix #1637
Also add new test utility class that is more flexible than NWBH5IOMixin and which will replace that class eventually.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel January 19, 2023 08:19
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1638 (dababb1) into dev (4a38196) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1638   +/-   ##
=======================================
  Coverage   91.31%   91.32%           
=======================================
  Files          25       25           
  Lines        2534     2535    +1     
  Branches      481      481           
=======================================
+ Hits         2314     2315    +1     
  Misses        139      139           
  Partials       81       81           
Flag Coverage Δ
integration 70.49% <100.00%> (+0.05%) ⬆️
unit 84.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/file.py 88.02% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -156,7 +157,7 @@ class NWBFile(MultiContainerInterface):
{
'attr': 'stimulus_template',
'add': '_add_stimulus_template_internal',
'type': TimeSeries,
'type': (TimeSeries, Images),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can add Images but not Image directly? I'm OK with that I just wanted to confirm that this is what we want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@rly rly merged commit cf0048a into dev Jan 24, 2023
@rly rly deleted the allow_stimulus_template_images branch January 24, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NWBFile.stimulus_templates does not accept Images type
3 participants