Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citation for PyNWB to eLife paper #1604

Merged
merged 12 commits into from
Dec 12, 2022
Merged

Update citation for PyNWB to eLife paper #1604

merged 12 commits into from
Dec 12, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Dec 10, 2022

Motivation

Fix #1605
Fix #1606

  • Update the citation for PyNWB to point users to the eLife paper rather than the pre-print.
    • Update citation in the docs
    • Update citation for duecredit
  • Fix hardcoded link warnings in the docs build

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #1604 (8ce07ea) into dev (03740d0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1604   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files          25       25           
  Lines        2510     2510           
  Branches      474      474           
=======================================
  Hits         2291     2291           
  Misses        139      139           
  Partials       80       80           
Flag Coverage Δ
integration 70.35% <100.00%> (ø)
unit 84.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/__init__.py 75.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oruebel oruebel marked this pull request as ready for review December 10, 2022 09:49
@oruebel
Copy link
Contributor Author

oruebel commented Dec 10, 2022

@rly this PR is ready for review

rly
rly previously approved these changes Dec 11, 2022
@oruebel
Copy link
Contributor Author

oruebel commented Dec 11, 2022

@rly merging is blocked because of the failing linux-python-3.10 test. However, it looks like this is due to some version conflicts in that test rather than due to changes in this PR. Can you help?

@oruebel
Copy link
Contributor Author

oruebel commented Dec 12, 2022

@rly can you re-approve. I had to resolve merge conflicts in the CHANGELOG to sync with dev

@oruebel oruebel merged commit cf6759a into dev Dec 12, 2022
@oruebel oruebel deleted the update/citingpynwb branch December 12, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants