Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntracellularRecordingsTable: infer electrode #1598

Merged
merged 13 commits into from
Dec 12, 2022

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Nov 12, 2022

infer electrode from response or stimulus

Motivation

fix #1597

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1598 (2f578d6) into dev (cf6759a) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##              dev    #1598      +/-   ##
==========================================
- Coverage   91.27%   91.25%   -0.03%     
==========================================
  Files          25       25              
  Lines        2510     2515       +5     
  Branches      474      477       +3     
==========================================
+ Hits         2291     2295       +4     
  Misses        139      139              
- Partials       80       81       +1     
Flag Coverage Δ
integration 70.21% <14.28%> (-0.14%) ⬇️
unit 84.49% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/icephys.py 91.77% <85.71%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bendichter bendichter changed the title IntracellularRecordingsTable: allow electrode to be inferred by respo… IntracellularRecordingsTable: infer electrode Nov 28, 2022
oruebel
oruebel previously approved these changes Dec 10, 2022
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the test slightly to make sure the case were the electrode is determined from the response (instead of the stimulus) is also covered. Otherwise this looks good to me.

@oruebel
Copy link
Contributor

oruebel commented Dec 10, 2022

@rly merging seems to be blocked due to the failing 3.10 test, but I don't think the error is related to this PR

@oruebel
Copy link
Contributor

oruebel commented Dec 12, 2022

I synced the branch with dev, so that Python 3.10 tests should pass now. I'll merge once all checks have finished/passed.

@oruebel oruebel merged commit f4bd3bc into dev Dec 12, 2022
@oruebel oruebel deleted the intracellular_recordings_table_optional_electrode branch December 12, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IntracellularElectrodeTable.add_recording should not require electrode
2 participants