-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntracellularRecordingsTable: infer electrode #1598
IntracellularRecordingsTable: infer electrode #1598
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1598 +/- ##
==========================================
- Coverage 91.27% 91.25% -0.03%
==========================================
Files 25 25
Lines 2510 2515 +5
Branches 474 477 +3
==========================================
+ Hits 2291 2295 +4
Misses 139 139
- Partials 80 81 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the test slightly to make sure the case were the electrode is determined from the response (instead of the stimulus) is also covered. Otherwise this looks good to me.
@rly merging seems to be blocked due to the failing 3.10 test, but I don't think the error is related to this PR |
I synced the branch with dev, so that Python 3.10 tests should pass now. I'll merge once all checks have finished/passed. |
infer electrode from response or stimulus
Motivation
fix #1597
Checklist
flake8
from the source directory.