Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: IntracellularElectrodeTable.add_recording should not require electrode #1597

Closed
3 tasks done
bendichter opened this issue Nov 12, 2022 · 0 comments · Fixed by #1598
Closed
3 tasks done

[Bug]: IntracellularElectrodeTable.add_recording should not require electrode #1597

bendichter opened this issue Nov 12, 2022 · 0 comments · Fixed by #1598

Comments

@bendichter
Copy link
Contributor

What happened?

IntracellularElectrodeTable.add_recording currently requires an electrode argument, but this is redundant because the stimulus and/or response objects have an electrode field and the electrode can be easily inferred from those.

Steps to Reproduce

cCSS = CurrentClampStimulusSeries(
            name="test_cCSS",
            data=np.ones((30,)),
            electrode=electrode_name,
            gain=1.0,
            rate=100_000.,
        )

        cCS = CurrentClampSeries(
            name="test_cCS",
            data=np.ones((30,)),
            electrode=electrode_name,
            gain=1.0,
            rate=100_000.,
        )

        itr = IntracellularRecordingsTable()
        itr.add_recording(stimulus=cCSS, response=cCS)

Traceback

No response

Operating System

macOS

Python Executable

Python

Python Version

3.7

Package Versions

No response

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant