add mock neurodata objects #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy with the flexibility of this approach. I think this could help minimize a l of testing code across several repos, including PyNWB, NWB Widgets, and NWB Inspector. Questions:
|
* add mock ophys types * use new mock types in ophys unit tests
add behavior
* correct SpikeEventSeries timestamps * move all mock tests do a dedicated testing file
# Conflicts: # tests/unit/test_ecephys.py # tests/unit/test_ophys.py
bendichter
commented
Aug 24, 2022
bendichter
commented
Aug 24, 2022
Co-authored-by: Oliver Ruebel <[email protected]>
oruebel
reviewed
Aug 31, 2022
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
oruebel
reviewed
Aug 31, 2022
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
oruebel
reviewed
Aug 31, 2022
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
bendichter
commented
Aug 31, 2022
oruebel
requested changes
Aug 31, 2022
There was a problem hiding this comment.
@bendichter could you add a docstring at least at the top of each module (py-file) to describe what the module contains and how to use it. It would be nice to also have docstrings for each of the functions, but I think in this particular case that is less critical as the functions are more-or-less self-describing once you know what the purpose of a mock_X function is.
Otherwise this looks good to me. Thanks for putting this together.
bendichter
commented
Sep 16, 2022
oruebel
requested changes
Sep 16, 2022
oruebel
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #1452
I tried fixtures first but it was very difficult to get them to play nice with unitTests.