Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ros3 tests if internet or ros3 driver are not available #1414

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Oct 5, 2021

Motivation

Fix #1412

Automatically skip ROS3 tests if internet is not available or if ROS3 is not installed

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested a review from rly October 5, 2021 07:39
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1414 (010cc3a) into dev (dd7c301) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1414   +/-   ##
=======================================
  Coverage   77.31%   77.31%           
=======================================
  Files          37       37           
  Lines        2715     2715           
  Branches      450      450           
=======================================
  Hits         2099     2099           
  Misses        535      535           
  Partials       81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7c301...010cc3a. Read the comment docs.

@oruebel oruebel added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) labels Oct 5, 2021
@oruebel oruebel merged commit e484bfd into dev Oct 5, 2021
@oruebel oruebel deleted the autoskip/ros3 branch October 5, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a “nice” way to selectively disable tests which require network access?
2 participants