Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load namespaces by default except in write mode and during validation #1196

Closed
wants to merge 1 commit into from
Closed

Load namespaces by default except in write mode and during validation #1196

wants to merge 1 commit into from

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 20, 2020

Fix #1169.

@rly rly requested review from t-b, ajtritt, bendichter and oruebel and removed request for t-b February 20, 2020 01:54
@t-b t-b self-requested a review May 11, 2020 16:08
@t-b
Copy link
Collaborator

t-b commented May 11, 2020

@rly I think the validation fails as we need to use load_namespaces=True in the validator when we validate against a spec from the NWB file.

t-b
t-b requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@t-b t-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1196 (comment)

@bendichter
Copy link
Contributor

I think at this point this PR has so many merge conflicts we should just start over. Thoughts, @rly?

@bendichter
Copy link
Contributor

@rly can this be closed?

@rly
Copy link
Contributor Author

rly commented Feb 5, 2024

Addressed by #1748

@rly rly closed this Feb 5, 2024
@rly rly deleted the enh/load_ns_default branch February 5, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-b t-b t-b requested changes

@ajtritt ajtritt Awaiting requested review from ajtritt

@bendichter bendichter Awaiting requested review from bendichter

@oruebel oruebel Awaiting requested review from oruebel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set load_namespaces = True by default?
3 participants
@rly @t-b @bendichter