Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Create separate workflow for testing allensdk example #1679

Open
3 tasks done
rly opened this issue Mar 24, 2023 · 1 comment
Open
3 tasks done

[Feature]: Create separate workflow for testing allensdk example #1679

rly opened this issue Mar 24, 2023 · 1 comment
Assignees
Labels
priority: medium non-critical problem and/or affecting only a small set of NWB users topic: docs issues related to documentation topic: testing issues related to testing
Milestone

Comments

@rly
Copy link
Contributor

rly commented Mar 24, 2023

What would you like to see added to PyNWB?

The allensdk has strict requirements on the versions of hdmf and pynwb as a result (currently the requirement is hdmf<=3.4.7 but the latest pynwb requires hdmf>=3.5.1). This creates a version conflict when we try to test the latest version of pynwb and hdmf - specifically when we try to test our sphinx gallery example that requires allensdk and so we install allensdk.

allensdk also has not historically supported the latest version of Python (3.10 is not supported at the moment) and allensdk has a ton of requirements that slows down builds.

Is your feature request related to a problem?

No response

What solution would you like?

I suggest we create a separate CI workflow for testing allensdk compatibility that handles the dependency issues above and so that the other gallery tests do not need to rely on an older version of Python or be slowed down in the install. This separate workflow can run nightly like the ROS3 workflow.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@rly
Copy link
Contributor Author

rly commented Mar 24, 2023

Oops. This is a duplicate of #1659

@rly rly self-assigned this Mar 24, 2023
@rly rly added priority: medium non-critical problem and/or affecting only a small set of NWB users topic: docs issues related to documentation topic: testing issues related to testing labels Mar 24, 2023
@rly rly added this to the Next Release milestone Mar 24, 2023
@stephprince stephprince modified the milestones: 2.7.0, 2.8.0 May 9, 2024
@stephprince stephprince modified the milestones: 2.8.0, 2.9.0 Jul 23, 2024
@rly rly modified the milestones: 2.9.0, Next Major Release - 3.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium non-critical problem and/or affecting only a small set of NWB users topic: docs issues related to documentation topic: testing issues related to testing
Projects
None yet
Development

No branches or pull requests

2 participants