From 649800088ffb4bffb95bf0f55302d82537a8d78f Mon Sep 17 00:00:00 2001
From: Heberto Mayorquin <h.mayorquin@gmail.com>
Date: Fri, 22 Dec 2023 01:43:41 +0100
Subject: [PATCH] Expose starting time in `mock_ElectricalSeries` (#1805)

Co-authored-by: Ryan Ly <rly@lbl.gov>
---
 CHANGELOG.md                      | 3 ++-
 src/pynwb/testing/mock/ecephys.py | 2 ++
 src/pynwb/testing/mock/ophys.py   | 3 +++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 078eb5ce3..f38f6001d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,8 @@
 - Add `pynwb.get_nwbfile_version()`. @bendichter [#1703](https://github.com/NeurodataWithoutBorders/pynwb/pull/1703)
 - Updated timeseries data checks to warn instead of error when reading invalid files. @stephprince [#1793](https://github.com/NeurodataWithoutBorders/pynwb/pull/1793) and [#1809](https://github.com/NeurodataWithoutBorders/pynwb/pull/1809)
 - Expose the offset, conversion and channel conversion parameters in `mock_ElectricalSeries`. @h-mayorquin [#1796](https://github.com/NeurodataWithoutBorders/pynwb/pull/1796)
-- Enhance `get_data_in_units()` to work with objects that have a `channel_conversion` attribute like the `ElectricalSeries`  @h-mayorquin [#1806](https://github.com/NeurodataWithoutBorders/pynwb/pull/1806)
+- Expose `starting_time` in `mock_ElectricalSeries`. @h-mayorquin [#1805](https://github.com/NeurodataWithoutBorders/pynwb/pull/1805)
+- Enhance `get_data_in_units()` to work with objects that have a `channel_conversion` attribute like the `ElectricalSeries`. @h-mayorquin [#1806](https://github.com/NeurodataWithoutBorders/pynwb/pull/1806)
 
 ### Bug fixes
 - Fix bug where namespaces were loaded in "w-" mode. @h-mayorquin [#1795](https://github.com/NeurodataWithoutBorders/pynwb/pull/1795)
diff --git a/src/pynwb/testing/mock/ecephys.py b/src/pynwb/testing/mock/ecephys.py
index 8afa9ebc3..54edf7680 100644
--- a/src/pynwb/testing/mock/ecephys.py
+++ b/src/pynwb/testing/mock/ecephys.py
@@ -71,6 +71,7 @@ def mock_ElectricalSeries(
     data=None,
     rate: float = 30000.0,
     timestamps=None,
+    starting_time: Optional[float] = None,
     electrodes: Optional[DynamicTableRegion] = None,
     filtering: str = "filtering",
     nwbfile: Optional[NWBFile] = None,
@@ -83,6 +84,7 @@ def mock_ElectricalSeries(
         description=description,
         data=data if data is not None else np.ones((10, 5)),
         rate=rate,
+        starting_time=starting_time,
         timestamps=timestamps,
         electrodes=electrodes or mock_electrodes(nwbfile=nwbfile),
         filtering=filtering,
diff --git a/src/pynwb/testing/mock/ophys.py b/src/pynwb/testing/mock/ophys.py
index d9ba02572..cd99d5957 100644
--- a/src/pynwb/testing/mock/ophys.py
+++ b/src/pynwb/testing/mock/ophys.py
@@ -132,6 +132,7 @@ def mock_OnePhotonSeries(
         conversion=conversion,
         timestamps=timestamps,
         starting_time=starting_time,
+        offset=offset,
         rate=rate,
         comments=comments,
         description=description,
@@ -162,6 +163,7 @@ def mock_TwoPhotonSeries(
     dimension=None,
     resolution=-1.0,
     conversion=1.0,
+    offset=0.0,
     timestamps=None,
     starting_time=None,
     comments="no comments",
@@ -194,6 +196,7 @@ def mock_TwoPhotonSeries(
         control=control,
         control_description=control_description,
         device=device,
+        offset=offset,
     )
 
     if nwbfile is not None: