Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide issue template(s) for people to seek feedback on "NWB enhancement" possible new NDX #532

Open
yarikoptic opened this issue Nov 29, 2022 · 1 comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users

Comments

@yarikoptic
Copy link
Contributor

github allows for templating entry of different types of issues. See e.g. https://github.com/bids-standard/bids-specification/tree/master/.github/ISSUE_TEMPLATE for various types BIDS has.

@rly mentioned that it is typical for people to first ask here on either adding a specific feature (new data type etc) would require an NDX or possibly just done within nwb-schema. So I thought it might be nice to have a dedicated template for such enhancements which would provide desired structure to such an issue and instruct submitter to provide necessary details (either new data type is for wide use or just ad-hoc in lab, etc).

@rly
Copy link
Contributor

rly commented Nov 30, 2022

Just to add:

  • for minor bug fixes, documentation changes, and addition of minor metadata fields, we generally recommend submitting an issue or PR here and we'll make the change here.
  • for addition of experiment-specific, lab-specific, or device-specific metadata or data types that are not useful to a broad swath of the community, we recommend creating and using an extension.
  • for addition of a new data modality, major breaking changes to existing data types, we generally recommend creating an extension and proposing that the extension be merged into core.

Am I missing any use cases?

@stephprince stephprince added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

No branches or pull requests

3 participants