-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TimeIntervals
to use the new TimeSeriesReferenceVectorData
#484
Comments
Just adding another option: |
For the upcoming release my current thinking is that we should probably go with "Option 1" and leave |
Yes, I agree with Option 1 for the upcoming 2.4.0 release. We can still implement options 2 and 3 later on. |
NeurodataWithoutBorders/pynwb#1390 defines another alternative approach (option 4). Instead attempting to fix the issue in the ObjectMapper this approach updates the Container class for |
NWB 2.4.0 introduces the
TimeSeriesReferenceVectorData
neurodata type which is identical to theVectorData
-typed column named "timeseries" in theTimeIntervals
table. For consistency in the data format and API, theTimeIntervals
neurodata type should be updated to use theTimeSeriesReferenceVectorData
neurodata type for the column named "timeseries".We will need to decide for the PyNWB API how to handle reading of old files written using the
VectorData
form of the "timeseries" column. Options:VectorData
.TimeSeriesReferenceVectorData
with the same object ID. This will likely require a change in the ObjectMapper base code to allow overriding the type-to-class mapping or modifying the builder before constructing the new object associated with the "timeseries" column.ref: #483
The text was updated successfully, but these errors were encountered: