Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electrodes table and frequency bands table should be their own types #336

Open
rly opened this issue Nov 27, 2019 · 0 comments · May be fixed by #337 or #539
Open

Electrodes table and frequency bands table should be their own types #336

rly opened this issue Nov 27, 2019 · 0 comments · May be fixed by #337 or #539
Assignees
@mavaylon1
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users

Comments

@rly
Copy link
Contributor

rly commented Nov 27, 2019

The "electrodes" table in NWBFile and the "bands" table in DecompositionSeries inherit from DynamicTable and add required datasets (columns) to them, but they themselves are not their own types. This makes validation problematic both at runtime and for the IO object.

Proposal: add a neurodata_type_def to these tables: Electrodes and FrequencyBands

See NeurodataWithoutBorders/pynwb#1115
@rly rly linked a pull request Nov 27, 2019 that will close this issue
Draft
@rly rly linked a pull request Apr 28, 2023 that will close this issue
Draft
5 tasks
@rly rly mentioned this issue Feb 5, 2024
Closed
@stephprince stephprince added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavaylon1 mavaylon1

Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Milestone
No milestone
3 participants
@rly @mavaylon1 @stephprince