-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Default Subclass Properties in checkUnset #475
Conversation
Failing tests are fixed in #461 |
@lawrence-mbf do you know why these tests are failing? Would it be possible to fix them? |
@bendichter We're polluting our MatNWB install directory with schemas of other versions. All tests and tutorials should make sure when their code blocks call As mentioned above, merging in #461 will fix it for the previously added tutorials. |
What is the plan for this PR - to be finished up/merged/released? |
@yarikoptic It can be merged. As mentioned, the test failures are already fixed upstream. Would you say that you approve of these changes? |
Remove dependency on defined class names and instead operate on all properties.
Originally was all-or-nothing. Now detects if a Set already exists and appends instead when that occurs.
03ef958
to
a460c09
Compare
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=========================================
Coverage ? 87.09%
=========================================
Files ? 128
Lines ? 5263
Branches ? 0
=========================================
Hits ? 4584
Misses ? 679
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #470
Motivation
See #470
How to test the behavior?
See #470
Checklist
fix #XX
whereXX
is the issue number?