Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support boolean values #467

Merged
merged 8 commits into from
Oct 20, 2022
Merged

Support boolean values #467

merged 8 commits into from
Oct 20, 2022

Commits on Oct 5, 2022

  1. add bool to logical io

    @lawrence-mbf
    lawrence-mbf committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    4e36a17 View commit details
    Browse the repository at this point in the history

  2. add bool tests

    @lawrence-mbf
    lawrence-mbf committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2555a19 View commit details
    Browse the repository at this point in the history

  3. fix writeCompound syntax

    @lawrence-mbf
    lawrence-mbf committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    3a4ea60 View commit details
    Browse the repository at this point in the history

  4. Change datastub behavior for compound types 

    Now returns table objects which match the default io.parseCompound function.
    @lawrence-mbf
    lawrence-mbf committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    b34dc54 View commit details
    Browse the repository at this point in the history

  5. minor refactor 

    reorder long lines, remove useless comments.
    @lawrence-mbf
    lawrence-mbf committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e83c708 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. cover scalar boolean case

    @lawrence-mbf
    lawrence-mbf committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4265f06 View commit details
    Browse the repository at this point in the history

  2. Re-add struct compound test in dynamic tables 

    The branch is still there so for coverage it's probably best to test it.
We need to cheat a little with this change as it is now guaranteed that reading compound data
types returns tables instead of structs with vectors.
    @lawrence-mbf
    lawrence-mbf committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    2331184 View commit details
    Browse the repository at this point in the history

  3. Remove addTableRow function 

    Error message moved into addRow function.
    @lawrence-mbf
    lawrence-mbf committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    75e9dde View commit details
    Browse the repository at this point in the history