-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tutorial Tests #450
Merged
Merged
Add Tutorial Tests #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, these are reverting the reversions on master only because I pushed to the wrong branch. |
We need to generateCore here.
Otherwise running the scripts may not properly handle the environment correctly.
The one test failure is dependent on #446 |
This was referenced Jul 27, 2022
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 85.92% 87.48% +1.55%
==========================================
Files 126 127 +1
Lines 5216 5232 +16
==========================================
+ Hits 4482 4577 +95
+ Misses 734 655 -79
Help us with your feedback. Take ten seconds to tell us how you rate us. |
bendichter
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #449, Fixes #445, Fixes #444
Motivation
QOL so the CI can test tutorials too.
How to test the behavior?
Checklist
fix #XX
whereXX
is the issue number?