Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tutorial Tests #450

Merged
merged 12 commits into from
Jul 29, 2022
Merged

Add Tutorial Tests #450

merged 12 commits into from
Jul 29, 2022

Conversation

lawrence-mbf
Copy link
Collaborator

@lawrence-mbf lawrence-mbf commented Jul 26, 2022

Fixes #449, Fixes #445, Fixes #444

Motivation

QOL so the CI can test tutorials too.

How to test the behavior?

nwbtest('Name', 'tests.unit.tutorialTest/*');

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf requested a review from bendichter July 26, 2022 20:10
@lawrence-mbf lawrence-mbf changed the title 449 add tutorial tests Add Tutorial Tests Jul 26, 2022
@lawrence-mbf
Copy link
Collaborator Author

Note, these are reverting the reversions on master only because I pushed to the wrong branch.

We need to generateCore here.
@lawrence-mbf lawrence-mbf marked this pull request as draft July 26, 2022 21:16
@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 27, 2022 15:30
@lawrence-mbf
Copy link
Collaborator Author

The one test failure is dependent on #446

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #450 (67cfb4d) into master (d43160c) will increase coverage by 1.55%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   85.92%   87.48%   +1.55%     
==========================================
  Files         126      127       +1     
  Lines        5216     5232      +16     
==========================================
+ Hits         4482     4577      +95     
+ Misses        734      655      -79     
Impacted Files Coverage Δ
+tests/+unit/tutorialTest.m 94.44% <94.44%> (ø)
NwbFile.m 83.21% <0.00%> (+0.47%) ⬆️
+types/+untyped/DataPipe.m 64.58% <0.00%> (+0.69%) ⬆️
+types/+untyped/+datapipe/BoundPipe.m 78.98% <0.00%> (+1.44%) ⬆️
+types/+util/+dynamictable/addVarargRow.m 97.61% <0.00%> (+2.38%) ⬆️
+io/mapData2H5.m 97.22% <0.00%> (+2.77%) ⬆️
+types/+untyped/DataStub.m 94.76% <0.00%> (+2.85%) ⬆️
+io/getBaseType.m 94.11% <0.00%> (+2.94%) ⬆️
+types/+untyped/MetaClass.m 88.88% <0.00%> (+5.55%) ⬆️
nwbExport.m 71.42% <0.00%> (+7.14%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@bendichter bendichter merged commit 5409664 into master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants