Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the window() operation. #337

Closed
wants to merge 1 commit into from
Closed

Added the window() operation. #337

wants to merge 1 commit into from

Conversation

bcotton
Copy link

@bcotton bcotton commented Sep 2, 2013

window() returns an Observable<Observable> that will chunk the source observable
based on several criteria; counts, time etc.

This differs from buffer() in that the underlying observables will all onComplete()
independently from their upstream Observable.

@cloudbees-pull-request-builder

RxJava-pull-requests #224 SUCCESS
This pull request looks good

@daveray
Copy link
Contributor

daveray commented Sep 2, 2013

For consistency with buffer it seems like all the Observable.window methods should be instance methods rather than static.

window() returns an Observable<Observable<T>> that will chunk the source observable
based on several criteria; counts, time etc.

This differs from buffer() in that the underlying observables will all onComplete()
independently from their upstream Observable.
@bcotton
Copy link
Author

bcotton commented Sep 2, 2013

ok. Missed it when porting into 0.11.1

I've forced-pushed my amended commit.

@cloudbees-pull-request-builder

RxJava-pull-requests #225 SUCCESS
This pull request looks good

@DavidMGross
Copy link
Collaborator

Now documented on the wiki (marble diagrams TBD):

https://github.com/Netflix/RxJava/wiki/Transforming-Observables#window

@benjchristensen benjchristensen mentioned this pull request Sep 5, 2013
@benjchristensen
Copy link
Member

Let's switch over to #349 for review as this pull request is out-of-date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants