-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockingObservable #272
BlockingObservable #272
Conversation
- see ReactiveX#270 for background
RxJava-pull-requests #144 FAILURE |
RxJava-pull-requests #145 SUCCESS |
Apparently another non-deterministic test |
I plan on merging this tomorrow morning (Thursday, May 16th Pacific time) if no strong reasons are given for not proceeding. |
No feedback to argue against proceeding so merging now... |
BlockingObservable
…matchers fix (ReactiveX#271): remove deprecated usage of Mockito Matchers
Move all blocking operators to
BlockingObservable
. This has breaking changes for anything using blocking operators ... part of the pursuit of establishing a clean API on our path to 1.0.This is something I've been wanting to do for a while but got the push over the ledge via discussion at #270.
This strays from "match Rx.Net as closely as possible" but feels justified for the following reasons:
take
andtakeLast
is non-obvious)I have removed all blocking operators from
Observable
and put them inBlockingObservable
. I have leftObservable.toBlockingObservable
as a means of going from one to the other as it is an obvious communication of what is now being permitted.While doing this I also cleaned up some odd API artifacts such as
toObservable
vsfrom
and moved implementation specific code fromrx.util
into the internal packagerx.operators
where all code reserves the right to change at any time.I intend on releasing this as version 0.9.