Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_squarefree is missing for fmpz_poly and fmpq_poly #1311

Open
wbhart opened this issue Jun 3, 2022 · 3 comments
Open

is_squarefree is missing for fmpz_poly and fmpq_poly #1311

wbhart opened this issue Jun 3, 2022 · 3 comments

Comments

@wbhart
Copy link
Contributor

wbhart commented Jun 3, 2022

The function is documented as existing in AbstractAlgebra, but missing in Nemo.

@wbhart
Copy link
Contributor Author

wbhart commented Jun 3, 2022

Both functions do however exist in Flint.

@fingolfin
Copy link
Member

Tried fmpz_poly_is_squarefree but it gives incorrect results (it considers $4$ or $4*x$ to be square free). With our version of FLINT, at least -- dunno if it is different in FLINT 3.x, @fredrik-johansson ?)

@thofma
Copy link
Member

thofma commented Nov 23, 2023

It depends a bit on the definition, but most functions related to factoring of fmpz_poly are mathematically wrong. They always give results for the polynomial considered as an element of Q[x] and not Z[x]. We jump through some hoops to make them mathematically correct.

Edit: We discussed the definition of squarefree over at #1510. I agree with you that 4x is not squarefree, but one should not expect flint to be correct in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants