ACL: Add transfer super admin api#94
Merged
Merged
Conversation
mooori
reviewed
Mar 14, 2023
Contributor
mooori
left a comment
There was a problem hiding this comment.
Thanks for this devx improvement! Docs should be changed slightly and I would add another assertion in the test. Otherwise LGTM.
Co-authored-by: mooori <moritz.zielke@aurora.dev>
birchmd
approved these changes
Mar 14, 2023
mooori
approved these changes
Mar 15, 2023
sept-en
reviewed
Mar 15, 2023
mrLSD
approved these changes
Jan 8, 2024
mrLSD
approved these changes
Jan 15, 2024
This was referenced Mar 27, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the ACL plugin provides api to init single super admin by
acl_init_super_admin. But to transfer the admin to another account, the developers need to write their own method, like this:This pull request adds a default implementation to transfer the super admin permissions to another account, this could be useful for transferring the super admin to DAO or another account, or on migration from one DAO to another.
Added pubic APIs: