Skip to content

feat(Upgradable)!: use Acl for authorization #85

Merged
mooori merged 9 commits into
masterfrom
acl-upgradable
Mar 3, 2023
Merged

feat(Upgradable)!: use Acl for authorization #85
mooori merged 9 commits into
masterfrom
acl-upgradable

Conversation

@mooori
Copy link
Copy Markdown
Contributor

@mooori mooori commented Mar 2, 2023

Previously Upgradable authorization was handled by Ownable. An explanation of how to use Upgradable with Acl is available in the example contract.

Acl Roles

Use cases which don’t require fine grained permissions can define only a single role and whitelist it for all Upgradable features. See Role::DAO in the example contract.

The other roles show how to achieve more fine grained permissions by whitelisting a role only for a subset of the Upgradable features.


Edit: Some advantages of using Acl:

  • Permissions can be more fine grained.
  • Permissions can be granted to multiple accounts (vs. a single owner).

@mooori mooori marked this pull request as ready for review March 3, 2023 09:20
@mooori mooori requested a review from birchmd March 3, 2023 09:20
Copy link
Copy Markdown

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice job!

@mooori mooori merged commit 094881b into master Mar 3, 2023
@mooori mooori deleted the acl-upgradable branch March 3, 2023 17:28
This was referenced Mar 27, 2026
This was referenced Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants