test: add integration tests for FullAccessKeyFallback#66
Merged
Conversation
mooori
commented
Jan 16, 2023
birchmd
reviewed
Jan 17, 2023
Contributor
Author
|
It might take some time for fixes of above issues to land in WDYT @birchmd? |
birchmd
approved these changes
Jan 17, 2023
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
Yes, I'm ok with merging this PR. Making issues on the workspaces repo is good enough to make sure we are being good open source citizens.
mrLSD
approved these changes
Mar 17, 2024
This was referenced Mar 27, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration tests and removes the corresponding unit tests. The background and motivation are described in #51, which does the same for
Pausable.This only ports existing unit tests. We'll probably want to add more tests. Before doing that, I propose to wait for
FullAccessKeyFallbackchanges resulting from audits.