test: add integration tests for Pausable plugins#51
Merged
Conversation
birchmd
reviewed
Dec 20, 2022
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
Looks pretty good to me, nice job! Just a few nits.
birchmd
approved these changes
Dec 21, 2022
| } | ||
|
|
||
| /// Exposing internal methods to facilitate integration testing. | ||
| /// TODO needed for this contract? |
Contributor
Author
There was a problem hiding this comment.
It turned out that these functions are not needed for the Pausable test contract. They're removed in 5fe4f37.
Thanks for catching another open TODO!
Contributor
Author
|
CI is green and I've double checked that there are no more open TODOs related to this PR, so merging now. |
This was referenced Jan 10, 2023
mrLSD
approved these changes
Apr 19, 2024
This was referenced Mar 27, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
Pausablewas tested by unit tests vianear_sdk::testing_env, which mocks the chain.The new integration tests compile the contract in
near-plugins/tests/contracts/pausable, deploy it on chain via nearworkspacesand send transactions to it.This is a step towards having only one contract for the
Pausableplugin which is used for tests and serves as documentation resp. example, as laid out in #48. In a follow up PR I’ll clean up duplicate example contracts.Other changes: refactor
near-plugins/tests/commonAccessControllablewas tested via integration tests.