fix: doc comment on Role variant crashes macro#33
Merged
Conversation
mooori
commented
Oct 21, 2022
| } = input; | ||
|
|
||
| let variants = variants.into_iter().collect::<Vec<_>>(); | ||
| let variant_idents = variants.into_iter().map(|v| v.ident).collect::<Vec<_>>(); |
Contributor
Author
There was a problem hiding this comment.
It was a bug to not do map(|v| v.ident). The test contract used only plain variants like LevelA without comments, data or custom discriminants, which prevented the bug from surfacing.
Comment on lines
+7
to
+15
| /// Roles are represented by enum variants. | ||
| #[derive(AccessControlRole, Deserialize, Serialize, Copy, Clone)] | ||
| #[serde(crate = "near_sdk::serde")] | ||
| pub enum Role { | ||
| /// Represents LevelA. | ||
| LevelA, | ||
| /// Represents LevelB. | ||
| LevelB, | ||
| /// Represents LevelC. |
Contributor
Author
There was a problem hiding this comment.
Adding not-so-meaningful comments to show it's now working and to avoid regressions.
There was a problem hiding this comment.
Just a note, we can add these comments in an enum in some of the examples to test the regression.
mrLSD
approved these changes
Apr 28, 2024
This was referenced Mar 27, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28