Skip to content

deps: bump near-sdk to 5.2#137

Merged
mooori merged 3 commits into
near:masterfrom
aleksuss:deps/near_sdk_5_2
Jul 15, 2024
Merged

deps: bump near-sdk to 5.2#137
mooori merged 3 commits into
near:masterfrom
aleksuss:deps/near_sdk_5_2

Conversation

@aleksuss
Copy link
Copy Markdown
Collaborator

No description provided.

@aleksuss aleksuss force-pushed the deps/near_sdk_5_2 branch from ac06967 to abba4e0 Compare July 12, 2024 10:59
Copy link
Copy Markdown
Contributor

@mooori mooori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If bumping the MSRV is not strictly required, then it would be better to not change it to avoid issues for users of the plugins. Some may not yet be ready to bump their project's MSRV.

Comment thread .github/workflows/test.yml
Comment thread Cargo.toml
# - `rust-toolchain` files in `near-plugins-derive/tests/contracts/**`
# - the toolchain installed in CI via the `toolchain` parameter of `actions-rs/toolchain@v1`
rust-version = "1.74.0"
rust-version = "1.76.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the MSRV bump required due to dependency updates?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately yes. The near-workspaces 0.11 required 1.76.0.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up for the Bridge team that the MSRV is bumped here, cc @karim-en.

Comment thread Cargo.toml
@mooori mooori merged commit 487836d into near:master Jul 15, 2024
This was referenced Mar 27, 2026
This was referenced Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants