replace all ukb_common with ukbb_common #6
Conversation
| @@ -17,10 +17,10 @@ | |||
| description="Common functions for UK Biobank Data", | |||
| long_description=long_description, | |||
| long_description_content_type="text/markdown", | |||
| url="https://github.com/Nealelab/ukb_common", | |||
| url="https://github.com/Nealelab/ukbb_common", | |||
There was a problem hiding this comment.
| @@ -8,7 +8,7 @@ | |||
|
|
|||
|
|
|||
| MKL_OFF = 'export MKL_NUM_THREADS=1; export MKL_DYNAMIC=false; export OMP_NUM_THREADS=1; export OMP_DYNAMIC=false; ' | |||
| SCRIPT_DIR = '/ukb_common/saige' | |||
| SCRIPT_DIR = '/ukbb_common/saige' | |||
There was a problem hiding this comment.
@konradjk I think this line suggests the docker image already has ukb_common in it. Happy to keep ukb_common for now or please update the docker too
There was a problem hiding this comment.
I think since I'm the next person to use the dockers, fine to update and I will update when it merges/next time I use it
|
Relatedly, I'm not sure why |
I believe this was in order to submit it as a package to PyPI. @wlu04 is there a way to consolidate them now that we're renaming the whole thing? |
I did this because this enables |
|
I think if we put a |
I replaced all
ukb_commonwithukbb_commonin this repo. This is dependent on 1) renaming the repo itself (Nealelab/ukbb_common) and 2) maybe some docker update as detailed below.