Skip to content

Support ble extended advertising on Windows #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support ble extended advertising on Windows #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions windows/src/universal_ble_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ namespace universal_ble
{
bluetoothLEWatcher = BluetoothLEAdvertisementWatcher();
bluetoothLEWatcher.ScanningMode(BluetoothLEScanningMode::Active);
(void)bluetoothLEWatcher.AllowExtendedAdvertisements();
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's good to see that the return value of AllowExtendedAdvertisements() is being ignored, as it might not always be necessary to handle it explicitly. However, consider adding a comment explaining why the return value is being ignored. This can help avoid confusion for future developers who might wonder if the return value should be checked for errors or other status information.

Suggested change
(void)bluetoothLEWatcher.AllowExtendedAdvertisements();
(void)bluetoothLEWatcher.AllowExtendedAdvertisements(); // Ignoring return value as it doesn't provide useful information in this context.

resetScanFilter();

if (filter != nullptr)
Expand Down
Loading