fix(livesync): stop forcing native prepare when using --bundle #3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These checks are no longer needed. They also cause the CLI to rebuild the .aar files on every change when using `tns run android --bundle`. - The first check: The CLI watches the `App_Resources` folder and will execute the logic for preparing them whenever there's a change. - The second check: The CLI will try to detect changes in node_modules by comparing the timestamps of every file there on every change. When there's a change, it will set the `modulesChanged` flag to true. Therefore, the `bundle` flag is not needed. fixes #3707
rosen-vladimirov
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks are no longer needed. They also cause the CLI to rebuild the .aar files on every change when using
tns run android --bundle.The first check:
The CLI watches the
App_Resourcesfolder and will execute the logicfor preparing them whenever there's a change.
The second check:
The CLI will try to detect changes in node_modules by comparing the
timestamps of every file there on every change. When there's a change,
it will set the
modulesChangedflag to true. Therefore, thebundleflag is not needed.fixes #3707