Fixed: the app doesn't exit when using --release and --justlaunch #2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/services/platform-service.ts
Outdated
|
|
||
| public runPlatform(platform: string): IFuture<void> { | ||
| return (() => { | ||
| if (this.$options.release) { |
Contributor
There was a problem hiding this comment.
shouldn't this be this.$options.justlaunch
Contributor
Author
There was a problem hiding this comment.
That's correct! Thank you!
Contributor
Author
There was a problem hiding this comment.
Pull request updated
tzraikov
force-pushed
the
raikov/fix-release-watch
branch
from
523685a to
1ba387f
Compare
rosen-vladimirov
approved these changes
Jan 13, 2017
Contributor
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
There was a problem hiding this comment.
But I believe we should check where's the if that checks only watch option and does not check justlaunch. We definitely have such if somewhere that starts something and keeps our process alive.
Contributor
Author
|
Yep, there are several ifs :) |
rosen-vladimirov
pushed a commit
that referenced
this pull request
Jan 23, 2017
rosen-vladimirov
added a commit
that referenced
this pull request
Jan 24, 2017
* Fixed: tns update crashes with error message (#2421) * Fixed: the app doesn't exit when using --release and --justlaunch (#2423) * Fixed: debug exits unexpected when using --chrome and --watch options (#2426) * Fixed: test command fails with exception (#2428) * Fixed: getfile/putfile operate with global files (not local ones) (#2434) * Remove --get-port flag (#2440) * Deprecate support for Node.js 4 (#2444) Deprecate support for Node.js `4.x.x` by adding message that users will see each time when they execute any command and their Node.js version is `4.x.x`. * Updated CLI documentation after behavior changes in run command (#2435) * Updated CLI documentation after behavior changes in run command * Remove usages of in help content. * Update message for livesync deprecation as it should not contain concrete release version * Add source-map dependency and it's types. Fix typescript error Add source-map dependency and typings for it. Previously CLI used it from `lib/common/vendor` dir, but it has npm package for a long time and it's better to use it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command doesn't exit:
tns run ios --release --justlaunchbecause of the watch option that is enabled by default.