Skip to content

Conversation

@edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

If you start the app through the launcher and the app is already open, we restart the logcat process and miss a few logs in the process. The current log line we're using to detect the start doesn't return the new PID at all and can conflict with apps with similar package names. This is a regression from #5755

What is the new behavior?

We accurately use a specific regex (/Start proc (?<pid>[0-9]+):(?<appId>.+?)\//) to find the exact appId and PID.

@cla-bot cla-bot bot added the cla: yes label Jun 26, 2024
@edusperoni edusperoni force-pushed the fix/correct-android-pid-detection branch from f32f86a to 1d1cc76 Compare June 26, 2024 19:59
@NathanWalker NathanWalker merged commit 6509773 into main Jul 1, 2024
@NathanWalker NathanWalker deleted the fix/correct-android-pid-detection branch July 1, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants