fix(http-client): requests with no proxy configured (#5573)

* fix: running tests / http requests where no proxy configured

* fix: allow axios defaults for agent

Co-authored-by: Igor Randjelovic <[email protected]>

* cleanup: remove unneeded import

Co-authored-by: Igor Randjelovic <[email protected]>

Author: jcassidyav

lib/common/http-client.ts

@@ -98,12 +98,15 @@ export class HttpClient implements Server.IHttpClient {
 
 		this.$logger.trace("httpRequest: %s", util.inspect(options));
 
-		const agent = tunnel.httpsOverHttp({
-			proxy: {
-				host: cliProxySettings.hostname,
-				port: parseInt(cliProxySettings.port),
-			},
-		});
+		let agent;
+		if (cliProxySettings) {
+			agent = tunnel.httpsOverHttp({
+				proxy: {
+					host: cliProxySettings.hostname,
+					port: parseInt(cliProxySettings.port),
+				},
+			});
+		}
 		const result = await axios({
 			url: options.url,
 			headers: options.headers,

lib/services/test-execution-service.ts

@@ -81,7 +81,7 @@ export class TestExecutionService implements ITestExecutionService {
 						liveSyncInfo.projectDir,
 						TestExecutionService.SOCKETIO_JS_FILE_NAME
 					),
-					socketIoJs
+					JSON.parse(socketIoJs)
 				);
 			}