From 21aeb2b7a02011b5560a2a17c14a1744a8468d50 Mon Sep 17 00:00:00 2001 From: Samuel Schultze Date: Mon, 5 Dec 2022 11:22:14 -0300 Subject: [PATCH 1/2] fix(dynamic-links): export ShortLinkType as an object --- packages/firebase-dynamic-links/index.android.ts | 2 ++ packages/firebase-dynamic-links/index.d.ts | 2 -- packages/firebase-dynamic-links/index.ios.ts | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/firebase-dynamic-links/index.android.ts b/packages/firebase-dynamic-links/index.android.ts index b7873a89..d652f69e 100644 --- a/packages/firebase-dynamic-links/index.android.ts +++ b/packages/firebase-dynamic-links/index.android.ts @@ -15,6 +15,8 @@ Object.defineProperty(fb, 'dynamicLinks', { writable: false, }); +export { ShortLinkType } from './common'; + export class DynamicLinkAnalyticsParameters implements IDynamicLinkAnalyticsParameters { _builder: com.google.firebase.dynamiclinks.DynamicLink.GoogleAnalyticsParameters.Builder; _native: com.google.firebase.dynamiclinks.DynamicLink.GoogleAnalyticsParameters; diff --git a/packages/firebase-dynamic-links/index.d.ts b/packages/firebase-dynamic-links/index.d.ts index 182700f2..70b6f307 100644 --- a/packages/firebase-dynamic-links/index.d.ts +++ b/packages/firebase-dynamic-links/index.d.ts @@ -1,8 +1,6 @@ import { FirebaseApp } from '@nativescript/firebase-core'; import { ShortLinkType, IDynamicLink } from './common'; -export { ShortLinkType }; - export class DynamicLinkAnalyticsParameters implements IDynamicLinkAnalyticsParameters { readonly native; readonly ios; diff --git a/packages/firebase-dynamic-links/index.ios.ts b/packages/firebase-dynamic-links/index.ios.ts index 8c0fc141..ec6b58b1 100644 --- a/packages/firebase-dynamic-links/index.ios.ts +++ b/packages/firebase-dynamic-links/index.ios.ts @@ -16,6 +16,8 @@ Object.defineProperty(fb, 'dynamicLinks', { declare const FIRApp, TNSFirebaseDynamicLinksAppDelegate; +export { ShortLinkType } from './common'; + export class DynamicLinkAnalyticsParameters implements IDynamicLinkAnalyticsParameters { _native: FIRDynamicLinkGoogleAnalyticsParameters; From b797cc5229facb98d5055da63706985b304ffbd0 Mon Sep 17 00:00:00 2001 From: Samuel Schultze Date: Mon, 5 Dec 2022 12:19:55 -0300 Subject: [PATCH 2/2] re-add export to index.d.ts --- packages/firebase-dynamic-links/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/firebase-dynamic-links/index.d.ts b/packages/firebase-dynamic-links/index.d.ts index 70b6f307..182700f2 100644 --- a/packages/firebase-dynamic-links/index.d.ts +++ b/packages/firebase-dynamic-links/index.d.ts @@ -1,6 +1,8 @@ import { FirebaseApp } from '@nativescript/firebase-core'; import { ShortLinkType, IDynamicLink } from './common'; +export { ShortLinkType }; + export class DynamicLinkAnalyticsParameters implements IDynamicLinkAnalyticsParameters { readonly native; readonly ios;