Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: RxJS - switch from prototype-patched based operators to pipeable operators #232

Closed
dsebastien opened this issue Mar 7, 2018 · 3 comments

Comments

@dsebastien
Copy link
Contributor

Pipeable (also called "lettable") operators have been introduced in RxJS 5.5.0 and they provide a new way of composing observable chains.

Moreover, this new approach is more friendly with bundlers such as Webpack in order to automatically tree-shake the unused operators rather than being the developer manually taking care of not importing any operator that is not really needed.

We should move in this direction in order to get all the benefits of tree-shaking once we leverage it in Stark.

See https://blog.angularindepth.com/rxjs-understanding-lettable-operators-fe74dda186d3

Cfr

@dsebastien
Copy link
Contributor Author

Comment from @christophercr :
Apparently there is an issue when using the pipeable operators together with Scope Hoisting enabled (see ReactiveX/rxjs#2981).
Perhaps we should wait until the new major version of RxJS (v 6.0) is released to see if this is solved

@dsebastien
Copy link
Contributor Author

One more reason to move forward with this: ReactiveX/rxjs#3212

@dsebastien dsebastien removed this from the must milestone Mar 27, 2018
@dsebastien
Copy link
Contributor Author

duplicate of #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant