Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webtrees 2.2.0 version released but not available here #154

Closed
Neriderc opened this issue Nov 25, 2024 · 12 comments
Closed

Webtrees 2.2.0 version released but not available here #154

Neriderc opened this issue Nov 25, 2024 · 12 comments

Comments

@Neriderc
Copy link

The latest version 2.2.0 has been released a couple of days ago, but this container hasn't been updated.

To be fair, this one hasn't either, and webtrees hasn't told me about the update.

Is there some version check not working for this new version?

P.S. thanks for providing this container, I've been a happy customer for many years 🙂

@NathanVaughn
Copy link
Owner

You would be correct, it bombed out since I didn't have a PHP version defined for 2.2: https://github.com/NathanVaughn/webtrees-docker/actions/runs/11995958443

I added a new entry for PHP 8.4 with webtrees 2.2 today, but that also failed due to Imagick I think building for ARM: https://github.com/NathanVaughn/webtrees-docker/actions/runs/11997681382

I downgraded it to 8.3 and was just going to let it try again tomorrow since I was running out of patience.

@Neriderc
Copy link
Author

Haha all good, I just wanted to make sure you were aware. Fix it up when it suits you 🙂

Cheers

@NathanVaughn
Copy link
Owner

Version 8.3 failed today too. Ugh. Possibly related to Imagick/imagick#698. I was able to make an x86 build on my machine, I'll have to play around with ARM with QEMU to debug. May have to disable Imagick for ARM to get 2.2.0 out at some point.

@Neriderc
Copy link
Author

Neriderc commented Nov 25, 2024

Yeah I've had a play too, I wasn't as successful as you, couldn't even get it to build Imagick locally.

Possibly related (but not helpful for resolution): Imagick/imagick#697

I'd happily accept a x86 version for my dev environment, so I can test some fixes for a module I maintain. Apparently all the modules that use app() are broken in webtrees 2.2.0 so my key reason for wanting the update so early is to be able to resolve this.

Or if you have an updated Dockerfile I can build myself, I'm not that familiar with Dockerfiles and haven't managed to get it working with PHP8.3 and webtrees 2.2.20.

@NathanVaughn
Copy link
Owner

NathanVaughn commented Nov 25, 2024

With the repo cloned, I ran uv run python .\dev\build_test_version.py --webtrees_version 2.2.0 which fires off a build of Webtrees 2.2.0 with the appropriate PHP versions and everything passed as build arguments to Docker.

This runs:

docker build --build-arg WEBTREES_VERSION=2.2.0 --build-arg PHP_VERSION=8.3 --build-arg PATCH_VERSION=2 -t webtrees:test docker\

@Neriderc
Copy link
Author

That fails for me, the same as running the dockerfile.

ERROR: failed to solve: process "/bin/sh -c pecl install imagick  && docker-php-ext-enable imagick  && docker-php-ext-configure gd --with-freetype --with-jpeg  && docker-php-ext-install -j\"$(nproc)\" pdo pdo_mysql pdo_pgsql zip intl gd exif" did not complete successfully: exit code: 1

It's the imagick stuff. You didn't make other changes?

@NathanVaughn
Copy link
Owner

Uh, no. I cleared my Docker build cache and tried again and it still worked. I'm not sure.
image

I ran the above command on commit b274df3 with no local changes.

@Neriderc
Copy link
Author

All good. I have now managed to build without Imagick and I think I can probably do a good enough job without it.

Thanks for the help, I'll let you sort the pre-built containers, I'm certainly out of my depth and would be no help 🙂

@NathanVaughn
Copy link
Owner

NathanVaughn commented Nov 26, 2024

I'm able to replicate locally. The issue I get is Imagick/imagick#640 with PHP 8.3.

@Neriderc
Copy link
Author

Yes, same issue I was getting. Looks like it's fixed but not released, and a comment at the bottom has a workaround until it gets into a release. Hopefully it works!

@NathanVaughn
Copy link
Owner

I think I got it situated. 2.2.0 tags have been pushed. I did a quick test locally and it seems to work. Let me know if it looks good.

@Neriderc
Copy link
Author

It's working for me, well done! I am using x86 though, haven't tested ARM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants