Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAllEntities is not a function #89

Open
O4epegb opened this issue Jun 19, 2022 · 8 comments
Open

getAllEntities is not a function #89

O4epegb opened this issue Jun 19, 2022 · 8 comments

Comments

@O4epegb
Copy link

O4epegb commented Jun 19, 2022

Using v0.3.38 and it says that getAllEntities is not a function, and indeed there is no such function in dist files, but it's present in the .d.ts file.

It seems like some mismatch between what is published in npm and the source code?

@fielding
Copy link
Contributor

I think you might be correct about it being a mismatch between what is published to npm and the source. Have you tried pointing the package to this repo to verify this? Something like...

"bitecs": "github:NateTheGreatt/bitECS#master"

You actually just reminded me that I haven't updated one of my projects back to using the npm package haha, but on the upside getAllEntities is available since it points to my fork's dist branch.

@O4epegb
Copy link
Author

O4epegb commented Jun 30, 2022

I think you might be correct about it being a mismatch between what is published to npm and the source. Have you tried pointing the package to this repo to verify this? Something like...

"bitecs": "github:NateTheGreatt/bitECS#master"

You actually just reminded me that I haven't updated one of my projects back to using the npm package haha, but on the upside getAllEntities is available since it points to my fork's dist branch.

I don't think it's possible to point to Github because there is no dist folder checked in here?

@fielding
Copy link
Contributor

fielding commented Jun 30, 2022

herpderp! You're absolutely right, feel free to test using


"bitecs": "github:fielding/bitECS#dist"

so we can report back to @NateTheGreatt and verify that it is just a NPM mismatch

@O4epegb
Copy link
Author

O4epegb commented Jul 3, 2022

Yep, it works.

@NateTheGreatt
Copy link
Owner

hey guys, apologies for the delay on getting a proper release out for this. getting to it, stay tuned!

@AlexJWayne
Copy link

Just ran into this trying to make a test to ensure that an entity did not get created. Guess I'll use a query instead.

Weird that the types say its there.

Awesome, awesome, awesome lib, BTW. This is great fun to work in. Thank you.

@krispya
Copy link
Collaborator

krispya commented Feb 28, 2023

Any updates on this?

@darkwebdev
Copy link

Sorry for another useless comment, just wanted to notify about the unresolved issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants