-
Pick/Create an issue and begin work on it.
if creating an issue, adhere to the [issue template](See ISSUE_TEMPLATE.md
Example:
[#0001](https://github.com/Natasha08/redux-middleware-workers/issues/0001)
-
Create a local branch in your development environment to work on the story.
Example:
$ git checkout master $ git pull $ git checkout -b 0001-test-issue
-
Create a test for your issue/feature.
-
Implement your feature and satisfy relevant test(s).
-
Repeat 3 and 4 as needed.
At the end of the day, WIP commit any pending work, preferably after an iteration of step 4, so that the tests guide the developer on how to complete the WIP work.
-
Run the entire test suite.
yarn test
ornpm test
Make sure your changes don't break anything else. Fix anything broken.
-
Commit branch to GitHub.
Example:
$ git add . # make sure you only add what should be added # add things to .gitignore if needed $ git diff # sanity check changes $ git commit -am '#140087205: implement logo uploads' $ git push
-
Create a pull request using the template.
Use
master
as the root branchPrefix the title of your PR with the issue number.
-
Ask one of the main contributors to review your code.
-
Make any necessary changes.
Address PR review comments. Any ignored comments should be discussed.
-
Repeat 7 and 8 as needed.
-
Request code merge.
When you have thoroughly addressed the main contributor(s) comments, request code merge.