Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests error due to pinned schemathesis version 3.19.* / Docker rebuild fails #747

Closed
juhoinkinen opened this issue Dec 1, 2023 · 1 comment · Fixed by #752
Closed

Tests error due to pinned schemathesis version 3.19.* / Docker rebuild fails #747

juhoinkinen opened this issue Dec 1, 2023 · 1 comment · Fixed by #752
Assignees
Labels
bug dependencies Pull requests that update a dependency file docker maintenance

Comments

@juhoinkinen
Copy link
Member

Running unit tests fail with the following error:

...
  File "/home/local/jmminkin/.cache/pypoetry/virtualenvs/annif-ul-EXdhi-py3.8/lib/python3.8/site-packages/schemathesis/lazy.py", line 9, in <module>
    from hypothesis.internal.escalation import format_exception, get_interesting_origin, get_trimmed_traceback
ImportError: cannot import name 'get_interesting_origin' from 'hypothesis.internal.escalation' (/home/local/jmminkin/.cache/pypoetry/virtualenvs/annif-ul-EXdhi-py3.8/lib/python3.8/site-packages/hypothesis/internal/escalation.py)

This originates from a change in Hypothesis, which makes it incompatible with Schemathesis: HypothesisWorks/hypothesis#3804. On Schemathesis side this is already fixed and the release v3.21.1 includes it, but because in Annif the Schemathesis version is pinned to 3.19.*, the fix does not propagate in use.

For development and future releases the Schemathesis version pinning can be just updated or removed, but this is not possible in rebuilds of the Annif 1.0 Docker image (see failed, manually triggered rebuild attempt), because for that no code changes are made.

Depending on the need to keep the Annif 1.0 Docker image up-to-date and on the schedule of 1.1 release, we could consider releasing Annif 1.0.1, where Schemethesis version pinning is removed or updated.

But for avoiding these kind of problems in the future the version pinning policy should be thought from this point of view: now the dev dependencies are fully unpinned except black and schemathesis.

@juhoinkinen juhoinkinen added bug docker maintenance dependencies Pull requests that update a dependency file labels Dec 1, 2023
@juhoinkinen juhoinkinen self-assigned this Dec 13, 2023
@juhoinkinen
Copy link
Member Author

Depending on the need to keep the Annif 1.0 Docker image up-to-date and on the schedule of 1.1 release, we could consider releasing Annif 1.0.1, where Schemethesis version pinning is removed or updated.

But for avoiding these kind of problems in the future the version pinning policy should be thought from this point of view: now the dev dependencies are fully unpinned except black and schemathesis.

For simply fixing the unit tests and releasing Annif v1.0.1, I switch to pin only Schemathesis major version (i.e. 3.*.*).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file docker maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant