Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pull request does not mention any issues" when mentioned issue is in different repository #126

Closed
Th3S4mur41 opened this issue Jan 13, 2025 · 7 comments · Fixed by #127
Closed
Assignees
Labels
bug Something isn't working

Comments

@Th3S4mur41
Copy link

In an organization with multiple code repositories, we are using a single "roadmap" repository to handle the issues for the various projects.

Referencing the issue in GitHub is straighforward and can be done with keyword like:

closes organization/roadmap#46

The issue is automatically linked by GitHub under the "Development" section, just as an issue in the same repo would.

GitHub has also improved its UI lately so that creating a branch or a codespace in a different repo, or even linking a PR in a different repo from an issue can be done quite easily.

The action check fails though and is reporting that no issue is mentioned

@Namchee
Copy link
Owner

Namchee commented Jan 14, 2025

Hey @Th3S4mur41,

Thanks for filing an issue! I'll check this one out.

@Namchee Namchee self-assigned this Jan 14, 2025
@Namchee Namchee added the bug Something isn't working label Jan 14, 2025
@Namchee
Copy link
Owner

Namchee commented Jan 14, 2025

It seems that the validator doesn't handle cases where issues aren't on the same repository. Will fix ASAP.

@Th3S4mur41
Copy link
Author

Thanks @Namchee highly appreciate the quick feedback 👍

@Namchee
Copy link
Owner

Namchee commented Jan 14, 2025

Hi @Th3S4mur41,

I've just release 0.15.6 that might fix this issue. Can you please try this version and test if it solves this problem?

@Namchee Namchee reopened this Jan 14, 2025
@Th3S4mur41
Copy link
Author

Unfortunately not... Validation is still failing

image

@Namchee
Copy link
Owner

Namchee commented Jan 15, 2025

Hmm, is the issue that you referenced belongs to a private organization / repository?

If yes, can you ensure that the access token you provide is able to access to the issue? Try running this cURL script after replacing it with the correct tokens and repository metadata.

@Th3S4mur41
Copy link
Author

Good hint... Running the script helped me figure out the issue.

While I thought about using a PT instead of GITHUB_TOKEN, I forgot to pass down the PT as a secret to my reusable workflow, so it used the GITHUB_TOKEN as a fallback which obviously doesn't have the necessary access to issues on other private repos within the org.

Now that the action is actually using my PT it is working as expected and considering issues from other repos in the org as valid. So problem fixed!

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants