Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store bindings in each view, instead of a globally shared array #8

Merged
merged 1 commit into from
Sep 25, 2012

Conversation

KidkArolis
Copy link
Contributor

Previously, the _modelBindings array was shared among all views, which means when one view is destroyed, all of the bindings in all views are lost.

Should I provide tests reproducing the problem?

delambo added a commit that referenced this pull request Sep 25, 2012
Store bindings in each view, instead of a globally shared array
@delambo delambo merged commit 66ad734 into nytimes:master Sep 25, 2012
@delambo
Copy link
Member

delambo commented Sep 25, 2012

@KidkArolis Thanks! I think this cleans up the multi-view use-case that I hacked into issue #4.

@delambo
Copy link
Member

delambo commented Sep 25, 2012

@KidkArolis Heads up - I just committed an additional fix for this to master (the case when multiple models are initialized by calling stickit again).

@KidkArolis
Copy link
Contributor Author

Good stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants