Skip to content
This repository has been archived by the owner on Jan 11, 2022. It is now read-only.

Shud skip connection bias be only added once? #51

Open
Alex-X-W opened this issue Jul 26, 2018 · 0 comments
Open

Shud skip connection bias be only added once? #51

Alex-X-W opened this issue Jul 26, 2018 · 0 comments

Comments

@Alex-X-W
Copy link

Hi there!
Thanks for your awesome work and sharing it.

As per my understanding to the deep voice paper, in the layer inference part (section 5.1.2.(d)) they only bias the skip connection once. Since they implemented the skip projection thru accumulation, they made q^(0) to be the bias and only added that once in the beginning.

However at line 87 in nv_wavenet_reference.cpp, q^(j) got biased by Bskip at each layer. It seems like a little bug or is there anything I am missing?

best,
Xuan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant