Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Add bm25 to supported indexes in vdb task (milvus) #167

Open
jperez999 opened this issue Oct 15, 2024 · 0 comments
Open

[FEA]: Add bm25 to supported indexes in vdb task (milvus) #167

jperez999 opened this issue Oct 15, 2024 · 0 comments
Assignees
Labels
feature request New feature or request

Comments

@jperez999
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Significant improvement

Please provide a clear description of problem this feature solves

This PR will add bm25 support provided by Milvus to the VDBTask sink. This will unlock hybrid search where we can query against both BM25 and model embeddings.

Describe the feature, and optionally a solution or implementation and any alternatives

We would allow the user to activate this feature using a boolean when they create the vdb task for their pipeline.
i.e.
VDBTask(bm25=True), This will load both the model embedding index and a bm25 index.

Additional context

No response

@jperez999 jperez999 added the feature request New feature or request label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant