Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise _config - move run-specific items out of plugins and into run #931

Open
leondz opened this issue Sep 24, 2024 · 0 comments
Open
Labels
enhancement Architectural upgrades

Comments

@leondz
Copy link
Collaborator

leondz commented Sep 24, 2024

Summary

Move the following from _config.plugins to _config.run:

  • model_type
  • model_name
  • extended_detectors
  • probe_spec
  • detector_spec
  • buff_spec

Test at least that:

  • they're present in _config.run
  • they're correctly populated in _config.run
  • they're absent in _config.plugins
  • each one is picked up correctly in at least one place

Basic example

the following config becomes valid:

---
run:
  model_name: openai
  probe_spec: encoding
plugins:
  generators:
    openai:
      OpenAIGenerator:
        name: gpt-4

Motivation

Items that shape the current run, and affect what is tested for, must be placed in _config.run. The contents of _config.plugins specify how plugins run, if they run. _config.run is about orchestration. _config.plugins is about helping individual plugins and plugin families execute.

@leondz leondz added the enhancement Architectural upgrades label Sep 24, 2024
@leondz leondz changed the title Reorganise _config - move run-specific items out of plugins Reorganise _config - move run-specific items out of plugins and into run Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Architectural upgrades
Projects
None yet
Development

No branches or pull requests

1 participant