From 8afe31e6883cc5de03252965f1c70ffa64d834fc Mon Sep 17 00:00:00 2001 From: Vedaanta Agarwalla Date: Tue, 25 Aug 2026 21:26:08 -0700 Subject: [PATCH] frost(sdpa): pass combine_rows to choose_split_kv in the sm120 test choose_split_kv gained a required combine_rows keyword-only argument for the combine-pass cost term (#720), but the sm120 expected-split helper wasn't updated to match, unlike its sm100 sibling in test_sdpa_fwd_split_kv_sm100.py which already passes it. The squash-merge of #720 dropped the follow-up fix (yanzhuo607/cudnn-frontend#1), so develop's sm120 CI (frost:rel:sdpa:sm120) is broken again: TypeError: choose_split_kv() missing 1 required keyword-only argument: 'combine_rows' Co-Authored-By: Claude Sonnet 5 --- test/python/sdpa/frost/test_sdpa_fwd_split_kv_sm120.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/python/sdpa/frost/test_sdpa_fwd_split_kv_sm120.py b/test/python/sdpa/frost/test_sdpa_fwd_split_kv_sm120.py index a0b1733dd..b6ad75574 100644 --- a/test/python/sdpa/frost/test_sdpa_fwd_split_kv_sm120.py +++ b/test/python/sdpa/frost/test_sdpa_fwd_split_kv_sm120.py @@ -46,6 +46,8 @@ def _expected_split(api): kv_tiles=-(-api.s_k_max // api.kv_tile), sm_count=device_info(torch.cuda.current_device()).sm_count, ctas_per_tile=1, + # The combine's grid is (S_q, H, B) — see choose_split_kv. + combine_rows=api.batch_size * api.h_q * api.s_q_max, )