diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 7b9524e61ff9..887fa46fa01a 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -51,7 +51,7 @@ jobs: - narwhals-tests - telemetry-setup - third-party-integration-tests-cudf-pandas - uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@test-gb300 permissions: contents: read if: always() @@ -94,7 +94,7 @@ jobs: packages: read pull-requests: read needs: telemetry-setup - uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@test-gb300 with: files_yaml: | build_docs: @@ -372,7 +372,7 @@ jobs: permissions: contents: read needs: telemetry-setup - uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@test-gb300 with: enable_check_generated_files: false ignored_pr_jobs: "telemetry-summarize spark-rapids-jni cuml-compat-tests" @@ -385,7 +385,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@test-gb300 with: build_type: pull-request build-datetime: ${{ needs.build-details.outputs.build-datetime }} @@ -400,7 +400,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 with: build_type: pull-request node_type: cpu16 @@ -416,7 +416,7 @@ jobs: pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] needs: checks - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 with: build_type: pull-request script: "ci/cpp_linters.sh" @@ -428,7 +428,7 @@ jobs: id-token: write packages: read pull-requests: read - uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@test-gb300 with: build_type: pull-request package_name: libcudf @@ -441,13 +441,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_cpp with: build_type: pull-request script: ci/test_cpp.sh - # https://github.com/NVIDIA/cudf/issues/23498 - matrix_filter: map(select(.GPU != "gb300" and .GPU != "gh200")) conda-python-build: needs: [build-details, conda-cpp-build] permissions: @@ -457,7 +455,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@test-gb300 with: build_type: pull-request build-datetime: ${{ needs.build-details.outputs.build-datetime }} @@ -473,7 +471,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@test-gb300 with: build_type: pull-request build-datetime: ${{ needs.build-details.outputs.build-datetime }} @@ -488,13 +486,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_conda && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cudf_polars_nor_dask_cudf with: build_type: pull-request script: "ci/test_python_cudf.sh" - # https://github.com/NVIDIA/cudf/issues/23498 - matrix_filter: map(select(.GPU != "gb300" and .GPU != "gh200")) conda-python-other-tests: # Tests for dask_cudf, cudf_polars, custreamz, cudf_kafka are separated for CI parallelism needs: [conda-python-build-noarch, changed-files] @@ -505,15 +501,13 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_conda with: build_type: pull-request # https://github.com/NVIDIA/cudf/pull/22381/changes#r3196736965 container-options: "--cap-add CAP_SYS_PTRACE --shm-size=8g --ulimit=nofile=1000000:1000000" script: "ci/test_python_other.sh" - # https://github.com/NVIDIA/cudf/issues/23498 - matrix_filter: map(select(.GPU != "gb300" and .GPU != "gh200")) conda-java-tests: needs: [conda-cpp-build, changed-files] permissions: @@ -523,7 +517,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_java with: build_type: pull-request @@ -593,7 +587,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_notebooks with: build_type: pull-request @@ -610,7 +604,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).build_docs with: build_type: pull-request @@ -633,7 +627,7 @@ jobs: target-aws-region: ${{ secrets.NVIDIA_DOCS_AWS_REGION }} target-aws-secret-access-key: ${{ secrets.NVIDIA_DOCS_AWS_SECRET_ACCESS_KEY }} target-s3-bucket: ${{ secrets.NVIDIA_DOCS_S3_BUCKET }} - uses: rapidsai/shared-workflows/.github/workflows/publish-api-docs.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/publish-api-docs.yaml@test-gb300 with: docs-projects: cudf,dask-cudf,libcudf dry-run: true @@ -647,7 +641,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: # build for every combination of arch and CUDA version, but only for the latest Python matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber))) @@ -666,7 +660,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: # build for every combination of arch and CUDA version, but only for the latest Python matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber))) @@ -685,7 +679,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: # Build a wheel for each CUDA x ARCH x minimum supported Python version matrix_filter: group_by({CUDA_VER, ARCH}) | map(min_by(.PY_VER | split(".") | map(tonumber))) @@ -704,13 +698,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels with: build_type: pull-request script: ci/test_wheel_cudf_streaming.sh - # https://github.com/NVIDIA/cudf/issues/23498 - matrix_filter: map(select(.GPU != "gb300" and .GPU != "gh200")) wheel-build-pylibcudf: needs: [build-details, checks, wheel-build-libcudf] permissions: @@ -720,7 +712,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: build_type: pull-request build-datetime: ${{ needs.build-details.outputs.build-datetime }} @@ -739,7 +731,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: build_type: pull-request build-datetime: ${{ needs.build-details.outputs.build-datetime }} @@ -758,13 +750,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cudf_polars_nor_dask_cudf with: build_type: pull-request script: ci/test_wheel_cudf.sh - # https://github.com/NVIDIA/cudf/issues/23498 - matrix_filter: map(select(.GPU != "gb300" and .GPU != "gh200")) wheel-build-cudf-polars: needs: [build-details, wheel-build-pylibcudf] permissions: @@ -774,7 +764,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: # This selects "ARCH=amd64 + the latest supported Python + CUDA". matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) @@ -794,11 +784,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cudf_nor_dask_cudf with: # This selects "ARCH=amd64 + the latest supported Python + CUDA". - matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) + matrix_filter: map(select(.ARCH == "arm64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) build_type: pull-request container-options: "--cap-add CAP_SYS_PTRACE --shm-size=8g --ulimit=nofile=1000000:1000000" script: "env POLARS_VERSIONS=endpoints ci/test_wheel_cudf_polars.sh" @@ -811,11 +801,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cudf_nor_dask_cudf with: # This selects "ARCH=amd64 + the latest supported Python + CUDA". - matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) + matrix_filter: map(select(.ARCH == "arm64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) build_type: pull-request script: "ci/test_cudf_polars_polars_tests.sh" wheel-build-dask-cudf: @@ -827,7 +817,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@test-gb300 with: # This selects "ARCH=amd64 + the latest supported Python + CUDA". matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) @@ -847,11 +837,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels && fromJSON(needs.changed-files.outputs.changed_file_groups).not_cudf_polars with: # This selects "ARCH=amd64 + the latest supported Python + CUDA". - matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) + matrix_filter: map(select(.ARCH == "arm64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) build_type: pull-request script: ci/test_wheel_dask_cudf.sh # build cudf with benchmarks but disable for cudf_streaming since we can't use MPI/UCX in wheel-based builds @@ -864,7 +854,7 @@ jobs: pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] needs: telemetry-setup - uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@test-gb300 with: arch: '["amd64", "arm64"]' cuda: '["13.3"]' @@ -887,12 +877,11 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@test-gb300 if: (fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels || fromJSON(needs.changed-files.outputs.changed_file_groups).test_cudf_pandas) && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cudf_polars_nor_dask_cudf with: # This selects the latest supported Python + CUDA minor versions for each ARCH/CUDA major version combo - # Filter out GB300 due to https://github.com/NVIDIA/cudf/issues/23498 - matrix_filter: group_by([(.ARCH), (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | map(select(.GPU != "gb300" and .GPU != "gh200")) + matrix_filter: group_by([(.ARCH), (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) build_type: pull-request script: ci/cudf_pandas_scripts/run_tests.sh third-party-integration-tests-cudf-pandas: @@ -904,7 +893,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_conda && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cpp_nor_cudf_polars_nor_dask_cudf with: build_type: pull-request @@ -967,7 +956,8 @@ jobs: id-token: write packages: read pull-requests: read - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + secrets: inherit # zizmor: ignore[secrets-inherit] + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cpp_nor_cudf_polars_nor_dask_cudf with: build_type: pull-request @@ -1012,7 +1002,7 @@ jobs: packages: read pull-requests: read secrets: inherit # zizmor: ignore[secrets-inherit] - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-gb300 if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_conda && fromJSON(needs.changed-files.outputs.changed_file_groups).neither_cpp_nor_cudf_polars_nor_dask_cudf with: build_type: pull-request diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 8e237b08b128..4ee1a805d369 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -1547,6 +1547,7 @@ if(CUDF_BUILD_TESTUTIL) endif() # * build cudf_identify_stream_usage -------------------------------------------------------------- +message(STATUS "CUDF: Build with stream testing enabled: ${CUDF_BUILD_STREAMS_TEST_UTIL}") if(CUDF_BUILD_STREAMS_TEST_UTIL) # Libraries for stream-related testing. We build the library twice, one with STREAM_MODE_TESTING # on and one with it set to off. Each test will then be configured to use the appropriate library diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index e749a086cd6b..7c473bcb97fe 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -850,6 +850,7 @@ class strings_column_wrapper : public detail::column_wrapper { cudf::detail::make_device_uvector(offsets, stream, mr.get_output_mr()), rmm::device_buffer{}, 0); + cudf::test::get_default_stream().synchronize(); wrapped = cudf::make_strings_column(num_strings, std::move(d_offsets), d_chars.release(), 0, {}); } @@ -1890,6 +1891,7 @@ class lists_column_wrapper : public detail::column_wrapper { // construct the list column wrapped = make_lists_column( cols.size(), std::move(offsets), std::move(data), null_count, std::move(null_mask)); + cudf::test::get_default_stream().synchronize(); } /** diff --git a/cpp/src/interop/from_arrow_device.cu b/cpp/src/interop/from_arrow_device.cu index 3a79b001bad7..08060019c510 100644 --- a/cpp/src/interop/from_arrow_device.cu +++ b/cpp/src/interop/from_arrow_device.cu @@ -198,7 +198,7 @@ dispatch_tuple_t dispatch_from_arrow_device::operator()( // gather strings into output column auto out_col = cudf::make_strings_column(d_indices, stream, mr); owned.emplace_back(std::move(out_col)); - cudf::detail::sync_stream(stream); + cudf::detail::sync_stream(stream); // variadic_ptrs goes out of scope return std::make_tuple(owned.front()->view(), std::move(owned)); } diff --git a/cpp/src/interop/from_arrow_host_strings.cu b/cpp/src/interop/from_arrow_host_strings.cu index fbc6869c84d2..94498cece8c1 100644 --- a/cpp/src/interop/from_arrow_host_strings.cu +++ b/cpp/src/interop/from_arrow_host_strings.cu @@ -114,7 +114,7 @@ std::unique_ptr from_arrow_stringview(ArrowSchemaView const* schema, return {data, size}; }); - cudf::detail::sync_stream(stream); + cudf::detail::sync_stream(stream); // variadic_ptrs goes out of scope return cudf::make_strings_column(d_indices, stream, mr); } diff --git a/cpp/src/io/orc/stripe_enc.cu b/cpp/src/io/orc/stripe_enc.cu index 7ea3b8de315d..e5d3087d80aa 100644 --- a/cpp/src/io/orc/stripe_enc.cu +++ b/cpp/src/io/orc/stripe_enc.cu @@ -1425,7 +1425,7 @@ void decimal_sizes_to_offsets(device_2dspan rg_bounds, auto const num_blocks = elem_sizes.size() * rg_bounds.size().first; decimal_sizes_to_offsets_kernel <<>>(rg_bounds, d_sizes); - stream.sync(); + stream.sync(); // h_sizes goes out of scope } } // namespace cudf::io::orc::detail diff --git a/cpp/src/io/orc/writer_impl.cu b/cpp/src/io/orc/writer_impl.cu index dc864799f277..9290b73daaea 100644 --- a/cpp/src/io/orc/writer_impl.cu +++ b/cpp/src/io/orc/writer_impl.cu @@ -1513,7 +1513,7 @@ encoded_footer_statistics finish_statistic_blobs(Footer const& footer, file_blobs[i].assign(stat_begin, stat_end); } - stream.sync(); + stream.sync(); // h_stat_chunks goes out of scope return {{}, std::move(file_blobs)}; } @@ -1596,7 +1596,7 @@ encoded_footer_statistics finish_statistic_blobs(Footer const& footer, file_blobs[i].assign(stat_begin, stat_end); } - stream.sync(); + stream.sync(); // h_srcs, h_dsts, h_lens go out of scope return {std::move(stripe_blobs), std::move(file_blobs)}; } @@ -2042,7 +2042,7 @@ orc_table_view make_orc_table_view(table_view const& table, }, stream); - stream.sync(); + stream.sync(); // type_kinds goes out of scope return {std::move(orc_columns), std::move(d_orc_columns), str_col_indexes, diff --git a/cpp/src/io/parquet/experimental/deletion_vectors_helpers.cu b/cpp/src/io/parquet/experimental/deletion_vectors_helpers.cu index 4a061ad22d86..6c212322430f 100644 --- a/cpp/src/io/parquet/experimental/deletion_vectors_helpers.cu +++ b/cpp/src/io/parquet/experimental/deletion_vectors_helpers.cu @@ -132,7 +132,7 @@ std::unique_ptr compute_row_index_column( row_indices_iter, row_indices_iter); - stream.sync(); + stream.sync(); // row_group_span_offsets goes out of scope return std::make_unique(cudf::data_type{cudf::type_id::UINT64}, num_rows, std::move(row_indices),