diff --git a/.clang-format b/.clang-format index bd8979396510..161db076a012 100644 --- a/.clang-format +++ b/.clang-format @@ -119,6 +119,7 @@ PenaltyBreakTemplateDeclaration: 10 PenaltyExcessCharacter: 1000000 PenaltyReturnTypeOnItsOwnLine: 200 PointerAlignment: Left +QualifierAlignment: Right RawStringFormats: - Language: Cpp Delimiters: diff --git a/cpp/benchmarks/common/ndsh_data_generator/ndsh_data_generator.cpp b/cpp/benchmarks/common/ndsh_data_generator/ndsh_data_generator.cpp index 587758d84bb0..0d1669cbc693 100644 --- a/cpp/benchmarks/common/ndsh_data_generator/ndsh_data_generator.cpp +++ b/cpp/benchmarks/common/ndsh_data_generator/ndsh_data_generator.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -189,11 +189,11 @@ std::unique_ptr generate_orders_independent(double scale_factor, // Generate the `o_orderdate` column auto o_orderdate_ts = [&]() { auto const o_orderdate_year = generate_random_string_column_from_set( - cudf::host_span(years.data(), years.size()), o_num_rows, stream, mr); + cudf::host_span(years.data(), years.size()), o_num_rows, stream, mr); auto const o_orderdate_month = generate_random_string_column_from_set( - cudf::host_span(months.data(), months.size()), o_num_rows, stream, mr); + cudf::host_span(months.data(), months.size()), o_num_rows, stream, mr); auto const o_orderdate_day = generate_random_string_column_from_set( - cudf::host_span(days.data(), days.size()), o_num_rows, stream, mr); + cudf::host_span(days.data(), days.size()), o_num_rows, stream, mr); auto const o_orderdate_str = cudf::strings::concatenate( cudf::table_view( {o_orderdate_year->view(), o_orderdate_month->view(), o_orderdate_day->view()}), @@ -212,7 +212,7 @@ std::unique_ptr generate_orders_independent(double scale_factor, // Generate the `o_orderpriority` column auto o_orderpriority = generate_random_string_column_from_set( - cudf::host_span(vocab_priorities.data(), vocab_priorities.size()), + cudf::host_span(vocab_priorities.data(), vocab_priorities.size()), o_num_rows, stream, mr); @@ -391,14 +391,14 @@ std::unique_ptr generate_lineitem_partial(cudf::table_view const& o // Generate the `l_shipinstruct` column auto l_shipinstruct = generate_random_string_column_from_set( - cudf::host_span(vocab_instructions.data(), vocab_instructions.size()), + cudf::host_span(vocab_instructions.data(), vocab_instructions.size()), l_num_rows, stream, mr); // Generate the `l_shipmode` column auto l_shipmode = generate_random_string_column_from_set( - cudf::host_span(vocab_modes.data(), vocab_modes.size()), + cudf::host_span(vocab_modes.data(), vocab_modes.size()), l_num_rows, stream, mr); @@ -591,27 +591,27 @@ std::unique_ptr generate_part(double scale_factor, // Generate the `p_name` column auto p_name = [&]() { auto const p_name_a = generate_random_string_column_from_set( - cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), + cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), num_rows, stream, mr); auto const p_name_b = generate_random_string_column_from_set( - cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), + cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), num_rows, stream, mr); auto const p_name_c = generate_random_string_column_from_set( - cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), + cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), num_rows, stream, mr); auto const p_name_d = generate_random_string_column_from_set( - cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), + cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), num_rows, stream, mr); auto const p_name_e = generate_random_string_column_from_set( - cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), + cudf::host_span(vocab_p_name.data(), vocab_p_name.size()), num_rows, stream, mr); @@ -659,7 +659,7 @@ std::unique_ptr generate_part(double scale_factor, // Generate the `p_type` column auto p_type = generate_random_string_column_from_set( - cudf::host_span(vocab_types.data(), vocab_types.size()), + cudf::host_span(vocab_types.data(), vocab_types.size()), num_rows, stream, mr); @@ -669,7 +669,7 @@ std::unique_ptr generate_part(double scale_factor, // Generate the `p_container` column auto p_container = generate_random_string_column_from_set( - cudf::host_span(vocab_containers.data(), vocab_containers.size()), + cudf::host_span(vocab_containers.data(), vocab_containers.size()), num_rows, stream, mr); @@ -871,7 +871,7 @@ std::unique_ptr generate_customer(double scale_factor, // Generate the `c_mktsegment` column auto c_mktsegment = generate_random_string_column_from_set( - cudf::host_span(vocab_segments.data(), vocab_segments.size()), + cudf::host_span(vocab_segments.data(), vocab_segments.size()), num_rows, stream, mr); diff --git a/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.cu b/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.cu index aa8689bba23f..3aff4d50a111 100644 --- a/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.cu +++ b/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -58,7 +58,7 @@ struct random_number_generator { CUDF_HOST_DEVICE random_number_generator(T lower, T upper) : lower(lower), upper(upper) {} - __device__ T operator()(const int64_t idx) const + __device__ T operator()(int64_t const idx) const { if constexpr (cudf::is_integral()) { thrust::default_random_engine engine; @@ -171,7 +171,7 @@ std::unique_ptr generate_repeat_string_column(std::string const& v } std::unique_ptr generate_random_string_column_from_set( - cudf::host_span set, + cudf::host_span set, cudf::size_type num_rows, rmm::cuda_stream_view stream, rmm::device_async_resource_ref mr) diff --git a/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.hpp b/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.hpp index f301f15a6be0..e91084caf32d 100644 --- a/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.hpp +++ b/cpp/benchmarks/common/ndsh_data_generator/random_column_generator.hpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -109,7 +109,7 @@ std::unique_ptr generate_repeat_string_column( * @param mr Device memory resource used to allocate the returned column's device memory */ std::unique_ptr generate_random_string_column_from_set( - cudf::host_span set, + cudf::host_span set, cudf::size_type num_rows, rmm::cuda_stream_view stream = cudf::get_default_stream(), rmm::device_async_resource_ref mr = cudf::get_current_device_resource_ref()); diff --git a/cpp/benchmarks/common/nvbench_utilities.cpp b/cpp/benchmarks/common/nvbench_utilities.cpp index 4b923c880e34..4d532d0bccc8 100644 --- a/cpp/benchmarks/common/nvbench_utilities.cpp +++ b/cpp/benchmarks/common/nvbench_utilities.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -13,7 +13,7 @@ void set_throughputs(nvbench::state& state) { double avg_cuda_time = state.get_summary("nv/cold/time/gpu/mean").get_float64("value"); - if (const auto items = state.get_element_count(); items != 0) { + if (auto const items = state.get_element_count(); items != 0) { auto& summ = state.add_summary("nv/cold/bw/item_rate"); summ.set_string("name", "Elem/s"); summ.set_string("hint", "item_rate"); @@ -21,8 +21,8 @@ void set_throughputs(nvbench::state& state) summ.set_float64("value", static_cast(items) / avg_cuda_time); } - if (const auto bytes = state.get_global_memory_rw_bytes(); bytes != 0) { - const auto avg_used_gmem_bw = static_cast(bytes) / avg_cuda_time; + if (auto const bytes = state.get_global_memory_rw_bytes(); bytes != 0) { + auto const avg_used_gmem_bw = static_cast(bytes) / avg_cuda_time; { auto& summ = state.add_summary("nv/cold/bw/global/bytes_per_second"); summ.set_string("name", "GlobalMem BW"); @@ -34,7 +34,7 @@ void set_throughputs(nvbench::state& state) } { - const auto peak_gmem_bw = + auto const peak_gmem_bw = static_cast(state.get_device()->get_global_memory_bus_bandwidth()); auto& summ = state.add_summary("nv/cold/bw/global/utilization"); diff --git a/cpp/benchmarks/groupby/group_nunique.cpp b/cpp/benchmarks/groupby/group_nunique.cpp index 1e17bcd3a91f..008d274f523a 100644 --- a/cpp/benchmarks/groupby/group_nunique.cpp +++ b/cpp/benchmarks/groupby/group_nunique.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -46,7 +46,7 @@ void bench_groupby_nunique(nvbench::state& state, nvbench::type_list) data_profile_builder() .cardinality(cardinality) .distribution(cudf::type_to_id(), distribution_id::UNIFORM, 0, size); - if (const auto null_freq = state.get_float64("null_probability"); null_freq > 0) { + if (auto const null_freq = state.get_float64("null_probability"); null_freq > 0) { profile.set_null_probability(null_freq); } else { profile.set_null_probability(std::nullopt); diff --git a/cpp/benchmarks/io/cuio_common.cpp b/cpp/benchmarks/io/cuio_common.cpp index ee1d512293d4..41106efaec58 100644 --- a/cpp/benchmarks/io/cuio_common.cpp +++ b/cpp/benchmarks/io/cuio_common.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -236,7 +236,7 @@ std::pair parse_cache_dropping_env() if (env == nullptr) { return {is_drop_cache_enabled, is_file_scope}; } // Trim leading/trailing whitespace - std::regex const static pattern{R"(^\s+|\s+$)"}; + std::regex static const pattern{R"(^\s+|\s+$)"}; auto env_sanitized = std::regex_replace(env, pattern, ""); // Convert to lowercase @@ -284,7 +284,7 @@ void drop_page_cache_if_enabled(std::vector const& file_paths) return; } - for (const auto& path : file_paths) { + for (auto const& path : file_paths) { if (path.empty()) { continue; } kvikio::drop_file_page_cache(path); } diff --git a/cpp/benchmarks/io/parquet/parquet_reader_filter.cpp b/cpp/benchmarks/io/parquet/parquet_reader_filter.cpp index 1ae244eaa922..a74a1cf2ae6b 100644 --- a/cpp/benchmarks/io/parquet/parquet_reader_filter.cpp +++ b/cpp/benchmarks/io/parquet/parquet_reader_filter.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -211,7 +211,7 @@ void BM_parquet_read_filter(nvbench::state& state) std::vector table_columns; table_columns.push_back(filter_column->view()); - for (const auto& col : copy_only_cols) { + for (auto const& col : copy_only_cols) { table_columns.push_back(col->view()); } diff --git a/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_single_step.cpp b/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_single_step.cpp index 1b1035b328ca..5b0c038d9af1 100644 --- a/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_single_step.cpp +++ b/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_single_step.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -153,7 +153,7 @@ int main(int argc, char const** argv) try { return extract_input_sources( input_paths, input_multiplier, num_threads, io_source_type, default_stream); - } catch (const std::exception& e) { + } catch (std::exception const& e) { print_usage(); throw std::runtime_error(e.what()); } diff --git a/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_two_step.cpp b/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_two_step.cpp index fb8f9260bc35..caadece7abc9 100644 --- a/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_two_step.cpp +++ b/cpp/examples/hybrid_scan_io/hybrid_scan_multifile_two_step.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -179,7 +179,7 @@ int main(int argc, char const** argv) try { return extract_input_sources( input_paths, input_multiplier, num_threads, io_source_type, default_stream); - } catch (const std::exception& e) { + } catch (std::exception const& e) { print_usage(); throw std::runtime_error(e.what()); } diff --git a/cpp/include/cudf/strings/detail/gather.cuh b/cpp/include/cudf/strings/detail/gather.cuh index eb744954897d..759448ac58a7 100644 --- a/cpp/include/cudf/strings/detail/gather.cuh +++ b/cpp/include/cudf/strings/detail/gather.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #pragma once @@ -291,11 +291,11 @@ std::unique_ptr gather(strings_column_view const& strings, // Iterator over the character column of input strings to gather auto in_chars_itr = thrust::make_transform_iterator( begin, - cuda::proclaim_return_type([d_strings = *d_strings] __device__(size_type idx) { + cuda::proclaim_return_type([d_strings = *d_strings] __device__(size_type idx) { if (NullifyOutOfBounds && (idx < 0 || idx >= d_strings.size())) { - return static_cast(nullptr); + return static_cast(nullptr); } - if (not d_strings.is_valid(idx)) { return static_cast(nullptr); } + if (not d_strings.is_valid(idx)) { return static_cast(nullptr); } return d_strings.element(idx).data(); })); diff --git a/cpp/include/cudf_test/nanoarrow_utils.hpp b/cpp/include/cudf_test/nanoarrow_utils.hpp index 7926ffd6bd70..d323d10ba39b 100644 --- a/cpp/include/cudf_test/nanoarrow_utils.hpp +++ b/cpp/include/cudf_test/nanoarrow_utils.hpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -430,7 +430,7 @@ struct VectorOfArrays { return 0; } - static const char* get_last_error(ArrowArrayStream* stream) { return nullptr; } + static char const* get_last_error(ArrowArrayStream* stream) { return nullptr; } static void release(ArrowArrayStream* stream) { diff --git a/cpp/libcudf_streaming/benchmarks/bench_partition.cpp b/cpp/libcudf_streaming/benchmarks/bench_partition.cpp index a8f549a25c62..7792f1c808fb 100644 --- a/cpp/libcudf_streaming/benchmarks/bench_partition.cpp +++ b/cpp/libcudf_streaming/benchmarks/bench_partition.cpp @@ -40,10 +40,10 @@ std::unique_ptr create_int_table(cudf::size_type num_rows, static void BM_PartitionAndPack(benchmark::State& state) { - const std::int64_t local_size = std::int64_t{state.range(1)} * 1000000; + std::int64_t const local_size = std::int64_t{state.range(1)} * 1000000; int num_rows = int(local_size / std::int64_t{sizeof(std::int32_t)}); - const int num_partitions = state.range(1); + int const num_partitions = state.range(1); rmm::cuda_stream_view stream = rmm::cuda_stream_default; @@ -86,9 +86,9 @@ static void BM_PartitionAndPack(benchmark::State& state) static void BM_PartitionAndPackCurrentImpl(benchmark::State& state) { - const int nranks = state.range(0); - const std::int64_t local_size = std::int64_t{state.range(1)} * 1000000; - const int num_partitions = state.range(2); + int const nranks = state.range(0); + std::int64_t const local_size = std::int64_t{state.range(1)} * 1000000; + int const num_partitions = state.range(2); int total_npartitions = nranks * num_partitions; int num_rows = diff --git a/cpp/libcudf_streaming/benchmarks/bench_shuffle.cpp b/cpp/libcudf_streaming/benchmarks/bench_shuffle.cpp index f540928cd2e3..f8fa5fe19b2b 100644 --- a/cpp/libcudf_streaming/benchmarks/bench_shuffle.cpp +++ b/cpp/libcudf_streaming/benchmarks/bench_shuffle.cpp @@ -303,7 +303,7 @@ rapidsmpf::Duration do_run(rapidsmpf::shuffler::PartID const total_num_partition // Check the shuffle result (this test only works for non-empty partitions // thus we only check large shuffles). if (args.num_local_rows >= 1000000) { - for (const auto& output_partition : output_partitions) { + for (auto const& output_partition : output_partitions) { auto [parts, owner] = cudf_streaming::partition_and_split(output_partition->view(), {0}, diff --git a/cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp b/cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp index 5c77c77b9b36..bedeb0cc4a98 100644 --- a/cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp +++ b/cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp @@ -45,7 +45,7 @@ struct device_bloom_filter { * * @return A const-qualified bloom filter viewing the underlying storage. */ - static const device_bloom_filter view(std::size_t num_blocks, + static device_bloom_filter const view(std::size_t num_blocks, std::uint64_t seed, void const* storage, rmm::cuda_stream_view stream); diff --git a/cpp/libcudf_streaming/tests/streaming/test_cudf_utils.cpp b/cpp/libcudf_streaming/tests/streaming/test_cudf_utils.cpp index 3b6a14777fd9..962e2c95c531 100644 --- a/cpp/libcudf_streaming/tests/streaming/test_cudf_utils.cpp +++ b/cpp/libcudf_streaming/tests/streaming/test_cudf_utils.cpp @@ -66,7 +66,7 @@ TEST_F(BaseEstimatedMemoryUsageTest, StringType) std::vector(100, "repeated string") // Many repeated strings }; - for (const auto& data : test_cases) { + for (auto const& data : test_cases) { // Create a string column cudf::test::strings_column_wrapper wrapper(data.begin(), data.end()); auto column = wrapper.release(); @@ -92,7 +92,7 @@ TEST_F(BaseEstimatedMemoryUsageTest, ListType) std::vector(100, 42) // Many repeated values }; - for (const auto& data : test_cases) { + for (auto const& data : test_cases) { // Create a list column cudf::test::lists_column_wrapper wrapper(data.begin(), data.end()); auto column = wrapper.release(); @@ -121,12 +121,12 @@ TEST_F(BaseEstimatedMemoryUsageTest, StructType) 50, std::make_pair(42, "repeated")) // Many repeated structs }; - for (const auto& data : test_cases) { + for (auto const& data : test_cases) { // Create struct columns for each field std::vector int_data; std::vector string_data; - for (const auto& item : data) { + for (auto const& item : data) { int_data.push_back(item.first); string_data.push_back(item.second); } @@ -163,7 +163,7 @@ TEST_F(BaseEstimatedMemoryUsageTest, DictionaryType) std::vector(100, "repeated") // Many repeated values }; - for (const auto& data : test_cases) { + for (auto const& data : test_cases) { // Create a dictionary column cudf::test::dictionary_column_wrapper wrapper(data.begin(), data.end()); auto column = wrapper.release(); diff --git a/cpp/libcudf_streaming/tests/streaming/test_read_parquet.cpp b/cpp/libcudf_streaming/tests/streaming/test_read_parquet.cpp index f96b5a7fc7cd..bb943b9f5ea9 100644 --- a/cpp/libcudf_streaming/tests/streaming/test_read_parquet.cpp +++ b/cpp/libcudf_streaming/tests/streaming/test_read_parquet.cpp @@ -137,7 +137,7 @@ INSTANTIATE_TEST_SUITE_P(ReadParquetCombinations, ::testing::Values(false, true), // truncate file list ::testing::Values(false, true)), - [](const ::testing::TestParamInfo& info) { + [](::testing::TestParamInfo const& info) { auto const& skip_rows = std::get<0>(info.param); auto const& num_rows = std::get<1>(info.param); auto const& use_filter = std::get<2>(info.param); diff --git a/cpp/libcudf_streaming/tests/streaming/test_shuffler.cpp b/cpp/libcudf_streaming/tests/streaming/test_shuffler.cpp index ea416d2cca15..6d7be6821956 100644 --- a/cpp/libcudf_streaming/tests/streaming/test_shuffler.cpp +++ b/cpp/libcudf_streaming/tests/streaming/test_shuffler.cpp @@ -31,13 +31,13 @@ namespace cs_actor = cudf_streaming::actor; class StreamingShuffler : public BaseStreamingFixture, public ::testing::WithParamInterface { public: - const unsigned int num_partitions = 10; - const unsigned int num_rows = 1000; - const unsigned int num_chunks = 5; - const unsigned int chunk_size = num_rows / num_chunks; - const std::int64_t seed = 42; - const cudf::hash_id hash_function = cudf::hash_id::HASH_MURMUR3; - const OpID op_id = 0; + unsigned int const num_partitions = 10; + unsigned int const num_rows = 1000; + unsigned int const num_chunks = 5; + unsigned int const chunk_size = num_rows / num_chunks; + std::int64_t const seed = 42; + cudf::hash_id const hash_function = cudf::hash_id::HASH_MURMUR3; + OpID const op_id = 0; void SetUp() override { BaseStreamingFixture::SetUpWithThreads(GetParam()); } diff --git a/cpp/libcudf_streaming/tests/test_shuffler.cpp b/cpp/libcudf_streaming/tests/test_shuffler.cpp index bf068720bb52..8b4165f2219c 100644 --- a/cpp/libcudf_streaming/tests/test_shuffler.cpp +++ b/cpp/libcudf_streaming/tests/test_shuffler.cpp @@ -170,7 +170,7 @@ INSTANTIATE_TEST_SUITE_P( testing::Values(1, 2, 5, 10), // total_num_partitions testing::Values(1, 9, 100, 100'000) // total_num_rows ), - [](const testing::TestParamInfo& info) { + [](testing::TestParamInfo const& info) { return std::to_string(info.index) + "__nparts_" + std::to_string(std::get<1>(info.param)) + "__nrows_" + std::to_string(std::get<2>(info.param)); }); @@ -243,7 +243,7 @@ INSTANTIATE_TEST_SUITE_P(ConcurrentShuffle, testing::Combine(testing::ValuesIn({1, 2, 4}), // num_shufflers testing::ValuesIn({1, 10, 100}) // total_num_partitions ), - [](const testing::TestParamInfo& info) { + [](testing::TestParamInfo const& info) { return "num_shufflers_" + std::to_string(std::get<0>(info.param)) + "__total_num_partitions_" + std::to_string(std::get<1>(info.param)); diff --git a/cpp/librtcx/embed.hpp b/cpp/librtcx/embed.hpp index d29c75bc6f88..a71b7e1bb240 100644 --- a/cpp/librtcx/embed.hpp +++ b/cpp/librtcx/embed.hpp @@ -108,7 +108,7 @@ rtcx::sha256 compute_embed_hash(std::span uncompressed_files_byte ctx.update(uncompressed_files_bytes); ctx.update(merged_dests_bytes); ctx.update(merged_include_dirs_bytes); - ctx.update(std::span{reinterpret_cast(compression.data()), compression.size()}); + ctx.update(std::span{reinterpret_cast(compression.data()), compression.size()}); return ctx.finalize(); } diff --git a/cpp/src/hash/md5_hash.cu b/cpp/src/hash/md5_hash.cu index 2ae0b8850551..0d42eac3870d 100644 --- a/cpp/src/hash/md5_hash.cu +++ b/cpp/src/hash/md5_hash.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #include @@ -102,10 +102,10 @@ auto __device__ inline get_element_pointer_and_size(string_view const& element) // The MD5 algorithm and its hash/shift constants are officially specified in // RFC 1321. For convenience, these values can also be found on Wikipedia: // https://en.wikipedia.org/wiki/MD5 -const __constant__ uint32_t md5_shift_constants[16] = { +__constant__ constexpr uint32_t md5_shift_constants[16] = { 7, 12, 17, 22, 5, 9, 14, 20, 4, 11, 16, 23, 6, 10, 15, 21}; -const __constant__ uint32_t md5_hash_constants[64] = { +__constant__ constexpr uint32_t md5_hash_constants[64] = { 0xd76aa478, 0xe8c7b756, 0x242070db, 0xc1bdceee, 0xf57c0faf, 0x4787c62a, 0xa8304613, 0xfd469501, 0x698098d8, 0x8b44f7af, 0xffff5bb1, 0x895cd7be, 0x6b901122, 0xfd987193, 0xa679438e, 0x49b40821, 0xf61e2562, 0xc040b340, 0x265e5a51, 0xe9b6c7aa, 0xd62f105d, 0x02441453, 0xd8a1e681, 0xe7d3fbc8, diff --git a/cpp/src/hash/sha_hash.cuh b/cpp/src/hash/sha_hash.cuh index 5fe84072d661..0344acad5331 100644 --- a/cpp/src/hash/sha_hash.cuh +++ b/cpp/src/hash/sha_hash.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -37,7 +37,7 @@ namespace cudf { namespace hashing { namespace detail { -const __constant__ uint32_t sha256_hash_constants[64] = { +__constant__ constexpr uint32_t sha256_hash_constants[64] = { 0x428a2f98, 0x71374491, 0xb5c0fbcf, 0xe9b5dba5, 0x3956c25b, 0x59f111f1, 0x923f82a4, 0xab1c5ed5, 0xd807aa98, 0x12835b01, 0x243185be, 0x550c7dc3, 0x72be5d74, 0x80deb1fe, 0x9bdc06a7, 0xc19bf174, 0xe49b69c1, 0xefbe4786, 0x0fc19dc6, 0x240ca1cc, 0x2de92c6f, 0x4a7484aa, 0x5cb0a9dc, 0x76f988da, @@ -48,7 +48,7 @@ const __constant__ uint32_t sha256_hash_constants[64] = { 0x748f82ee, 0x78a5636f, 0x84c87814, 0x8cc70208, 0x90befffa, 0xa4506ceb, 0xbef9a3f7, 0xc67178f2, }; -const __constant__ uint64_t sha512_hash_constants[80] = { +__constant__ constexpr uint64_t sha512_hash_constants[80] = { 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, diff --git a/cpp/src/interop/to_arrow_host.cu b/cpp/src/interop/to_arrow_host.cu index bef83bf02ec1..4b8cb2a6e42d 100644 --- a/cpp/src/interop/to_arrow_host.cu +++ b/cpp/src/interop/to_arrow_host.cu @@ -144,7 +144,7 @@ int dispatch_to_arrow_host::operator()(ArrowArray* out) const NANOARROW_RETURN_NOT_OK(populate_validity_bitmap(ArrowArrayValidityBitmap(tmp.get()))); auto bitmask = detail::bools_to_mask(column, stream, mr); NANOARROW_RETURN_NOT_OK(populate_data_buffer( - device_span(reinterpret_cast(bitmask.first->data()), + device_span(reinterpret_cast(bitmask.first->data()), bitmask.first->size()), ArrowArrayBuffer(tmp.get(), fixed_width_data_buffer_idx))); diff --git a/cpp/src/io/comp/brotli_dict.cpp b/cpp/src/io/comp/brotli_dict.cpp index 24aa8eeb5205..f008f8b08a27 100644 --- a/cpp/src/io/comp/brotli_dict.cpp +++ b/cpp/src/io/comp/brotli_dict.cpp @@ -1,7 +1,7 @@ /* * SPDX-FileCopyrightText: Copyright 2013 Google Inc. All Rights Reserved. * SPDX-FileCopyrightText: Copyright(c) 2009, 2010, 2013 - 2016 by the Brotli Authors. - * SPDX-FileCopyrightText: Copyright (c) 2018-2025, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 AND MIT */ @@ -45,7 +45,7 @@ THE SOFTWARE. namespace cudf { namespace io { -static const brotli_dictionary_s g_dictionary = { +static brotli_dictionary_s const g_dictionary = { // size_bits_by_length {0, 0, 0, 0, 10, 10, 11, 11, 10, 10, 10, 10, 10, 9, 9, 8, 7, 7, 8, 7, 7, 6, 6, 5, 5, 0, 0, 0, 0, 0, 0, 0}, diff --git a/cpp/src/io/comp/compression.cpp b/cpp/src/io/comp/compression.cpp index 57a553b04bfb..133ee485daaf 100644 --- a/cpp/src/io/comp/compression.cpp +++ b/cpp/src/io/comp/compression.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -86,7 +86,7 @@ std::vector compress_zstd(host_span src) auto const compressed_size_actual = ZSTD_compress(reinterpret_cast(compressed_buffer.data()), compressed_size_estimate, - reinterpret_cast(src.data()), + reinterpret_cast(src.data()), src.size(), 1); check_error_code(ZSTD_isError(compressed_size_actual), __LINE__); diff --git a/cpp/src/io/comp/debrotli.cu b/cpp/src/io/comp/debrotli.cu index 1e6903007498..23c422a6de96 100644 --- a/cpp/src/io/comp/debrotli.cu +++ b/cpp/src/io/comp/debrotli.cu @@ -1,7 +1,7 @@ /* * SPDX-FileCopyrightText: Copyright 2013 Google Inc. All Rights Reserved. * SPDX-FileCopyrightText: Copyright(c) 2009, 2010, 2013 - 2016 by the Brotli Authors. - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 AND MIT */ @@ -355,7 +355,7 @@ static __device__ uint8_t* ext_heap_alloc(uint32_t bytes, uint32_t ext_heap_size) { uint32_t len = (bytes + 0xf) & ~0xf; - volatile auto* heap_ptr = reinterpret_cast(ext_heap_base); + auto volatile* heap_ptr = reinterpret_cast(ext_heap_base); uint32_t first_free_block = ~0; for (;;) { uint32_t blk_next, blk_prev; @@ -425,7 +425,7 @@ static __device__ void ext_heap_free(void* ptr, uint32_t ext_heap_size) { uint32_t len = (bytes + 0xf) & ~0xf; - volatile auto* heap_ptr = (volatile uint32_t*)ext_heap_base; + auto volatile* heap_ptr = (uint32_t volatile*)ext_heap_base; uint32_t first_free_block = ~0; auto cur_blk = static_cast(static_cast(ptr) - ext_heap_base); for (;;) { diff --git a/cpp/src/io/comp/decompression.cpp b/cpp/src/io/comp/decompression.cpp index 0bd2bf674bd0..7658d723b70f 100644 --- a/cpp/src/io/comp/decompression.cpp +++ b/cpp/src/io/comp/decompression.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -382,7 +382,7 @@ size_t decompress_zstd(host_span src, host_span dst) }; size_t const decompressed_bytes = ZSTD_decompress(reinterpret_cast(dst.data()), dst.size(), - reinterpret_cast(src.data()), + reinterpret_cast(src.data()), src.size()); check_error_code(ZSTD_isError(decompressed_bytes), __LINE__); return decompressed_bytes; @@ -465,7 +465,7 @@ source_properties get_source_properties(compression_type compression, host_span< } case compression_type::ZSTD: { auto const ret = - ZSTD_findDecompressedSize(reinterpret_cast(src.data()), src.size()); + ZSTD_findDecompressedSize(reinterpret_cast(src.data()), src.size()); uncomp_len = static_cast(ret); if (compression != compression_type::AUTO) { CUDF_EXPECTS(ret != ZSTD_CONTENTSIZE_UNKNOWN, diff --git a/cpp/src/io/comp/gpuinflate.cu b/cpp/src/io/comp/gpuinflate.cu index a0cbfcf63ccb..808f7168f9cc 100644 --- a/cpp/src/io/comp/gpuinflate.cu +++ b/cpp/src/io/comp/gpuinflate.cu @@ -1,6 +1,6 @@ /* * SPDX-FileCopyrightText: Copyright (C) 2002-2013 Mark Adler, all rights reserved - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 AND Zlib */ @@ -110,9 +110,9 @@ struct prefetch_queue_s { }; template -inline __device__ volatile uint32_t* prefetch_addr32(volatile prefetch_queue_s& q, T* ptr) +inline __device__ volatile uint32_t* prefetch_addr32(prefetch_queue_s volatile& q, T* ptr) { - return reinterpret_cast(&q.pref_data[(prefetch_size - 4) & (size_t)(ptr)]); + return reinterpret_cast(&q.pref_data[(prefetch_size - 4) & (size_t)(ptr)]); } #endif // ENABLE_PREFETCH @@ -142,7 +142,7 @@ struct inflate_state_s { uint16_t first_slow_dist; uint16_t index_slow_dist; - volatile xwarp_s x; + xwarp_s volatile x; #if ENABLE_PREFETCH volatile prefetch_queue_s pref; #endif @@ -318,7 +318,7 @@ __device__ int construct( } /// permutation of code length codes -static const __device__ __constant__ uint8_t g_code_order[19 + 1] = { +static __device__ const __constant__ uint8_t g_code_order[19 + 1] = { 16, 17, 18, 0, 8, 7, 9, 6, 10, 5, 11, 4, 12, 3, 13, 2, 14, 1, 15, 0xff}; /// Dynamic block (custom huffman tables) @@ -493,18 +493,18 @@ __device__ int init_fixed(inflate_state_s* s) */ /// permutation of code length codes -static const __device__ __constant__ uint16_t g_lens[29] = { // Size base for length codes 257..285 +static __device__ const __constant__ uint16_t g_lens[29] = { // Size base for length codes 257..285 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 15, 17, 19, 23, 27, 31, 35, 43, 51, 59, 67, 83, 99, 115, 131, 163, 195, 227, 258}; -static const __device__ __constant__ uint16_t +static __device__ const __constant__ uint16_t g_lext[29] = { // Extra bits for length codes 257..285 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2, 3, 3, 3, 3, 4, 4, 4, 4, 5, 5, 5, 5, 0}; -static const __device__ __constant__ uint16_t +static __device__ const __constant__ uint16_t g_dists[30] = { // Offset base for distance codes 0..29 1, 2, 3, 4, 5, 7, 9, 13, 17, 25, 33, 49, 65, 97, 129, 193, 257, 385, 513, 769, 1025, 1537, 2049, 3073, 4097, 6145, 8193, 12289, 16385, 24577}; -static const __device__ __constant__ uint16_t g_dext[30] = { // Extra bits for distance codes 0..29 +static __device__ const __constant__ uint16_t g_dext[30] = { // Extra bits for distance codes 0..29 0, 0, 0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 9, 10, 10, 11, 11, 12, 12, 13, 13}; /// @brief Thread 0 only: decode bitstreams and output symbols into the symbol queue @@ -518,11 +518,11 @@ __device__ void decode_symbols(inflate_state_s* s) int32_t sym, batch_len; do { - volatile uint32_t* b = &s->x.u.symqueue[batch * batch_size]; + uint32_t volatile* b = &s->x.u.symqueue[batch * batch_size]; // Wait for the next batch entry to be empty #if ENABLE_PREFETCH // Wait for prefetcher to fetch a worst-case of 48 bits per symbol - while ((*(volatile int32_t*)&s->pref.cur_p - (int32_t)(size_t)cur < batch_size * 6) || + while ((*(int32_t volatile*)&s->pref.cur_p - (int32_t)(size_t)cur < batch_size * 6) || (s->x.batch_len[batch] != 0)) {} #else while (s->x.batch_len[batch] != 0) {} @@ -781,7 +781,7 @@ __device__ void process_symbols(inflate_state_s* s, int t) int batch = 0; do { - volatile uint32_t* b = &s->x.u.symqueue[batch * batch_size]; + uint32_t volatile* b = &s->x.u.symqueue[batch * batch_size]; int batch_len = 0; if (t == 0) { while ((batch_len = s->x.batch_len[batch]) == 0) {} @@ -946,14 +946,14 @@ __device__ void init_prefetcher(inflate_state_s* s, int t) } } -__device__ void prefetch_warp(volatile inflate_state_s* s, int t) +__device__ void prefetch_warp(inflate_state_s volatile* s, int t) { uint8_t const* cur_p = s->pref.cur_p; uint8_t const* end = s->end; while (shuffle((t == 0) ? s->pref.run : 0)) { auto cur_lo = (int32_t)(size_t)cur_p; int do_pref = - shuffle((t == 0) ? (cur_lo - *(volatile int32_t*)&s->cur < prefetch_size - 32 * 4 - 4) : 0); + shuffle((t == 0) ? (cur_lo - *(int32_t volatile*)&s->cur < prefetch_size - 32 * 4 - 4) : 0); if (do_pref) { uint8_t const* p = cur_p + 4 * t; *prefetch_addr32(s->pref, p) = (p < end) ? *reinterpret_cast(p) : 0; diff --git a/cpp/src/io/comp/snap.cu b/cpp/src/io/comp/snap.cu index db27c7a0b734..306f08998f9d 100644 --- a/cpp/src/io/comp/snap.cu +++ b/cpp/src/io/comp/snap.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -23,9 +23,9 @@ struct snap_state_s { uint8_t* dst_base; ///< Base ptr to output compressed data uint8_t* dst; ///< Current ptr to uncompressed data uint8_t* end; ///< End of uncompressed data buffer - volatile uint32_t literal_length; ///< Number of literal bytes - volatile uint32_t copy_length; ///< Number of copy bytes - volatile uint32_t copy_distance; ///< Distance for copy bytes + uint32_t volatile literal_length; ///< Number of literal bytes + uint32_t volatile copy_length; ///< Number of copy bytes + uint32_t volatile copy_distance; ///< Distance for copy bytes uint16_t hash_map[1 << hash_bits]; ///< Low 16-bit offset from hash }; @@ -259,7 +259,7 @@ CUDF_KERNEL void __launch_bounds__(128) s->copy_distance = 0; } for (uint32_t i = t; i < sizeof(s->hash_map) / sizeof(uint32_t); i += 128) { - *reinterpret_cast(&s->hash_map[i * 2]) = 0; + *reinterpret_cast(&s->hash_map[i * 2]) = 0; } __syncthreads(); src = s->src; diff --git a/cpp/src/io/comp/unsnap.cu b/cpp/src/io/comp/unsnap.cu index d21667221eac..f81e4c425dd3 100644 --- a/cpp/src/io/comp/unsnap.cu +++ b/cpp/src/io/comp/unsnap.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -65,7 +65,7 @@ struct unsnap_state_s { uint32_t bytes_left{}; ///< remaining bytes to decompress int32_t error{}; ///< current error status uint32_t tstart{}; ///< start time for perf logging - volatile unsnap_queue_s q{}; ///< queue for cross-warp communication + unsnap_queue_s volatile q{}; ///< queue for cross-warp communication device_span src; ///< input for current block device_span dst; ///< output for current block }; @@ -133,7 +133,7 @@ __device__ void snappy_prefetch_bytestream(unsnap_state_s* s, int t) * k_len3lut[k] = v | (n << 4); * } */ -static const uint8_t __device__ __constant__ k_len3lut[1 << 10] = { +static uint8_t const __device__ __constant__ k_len3lut[1 << 10] = { 0x80, 0x91, 0x80, 0x91, 0x92, 0x91, 0x92, 0x91, 0x80, 0xa3, 0x80, 0xa3, 0x92, 0xa3, 0x92, 0xa3, 0x94, 0x91, 0x94, 0x91, 0x92, 0x91, 0x92, 0x91, 0x94, 0xa3, 0x94, 0xa3, 0x92, 0xa3, 0x92, 0xa3, 0x80, 0xa5, 0x80, 0xa5, 0xa6, 0xa5, 0xa6, 0xa5, 0x80, 0xa3, 0x80, 0xa3, 0xa6, 0xa3, 0xa6, 0xa3, @@ -281,7 +281,7 @@ __device__ void snappy_decode_symbols(unsnap_state_s* s, uint32_t t) for (;;) { int32_t batch_len; - volatile unsnap_batch_s* b; + unsnap_batch_s volatile* b; // Wait for prefetcher if (t == 0) { @@ -313,7 +313,7 @@ __device__ void snappy_decode_symbols(unsnap_state_s* s, uint32_t t) is_long_sym = ((b0 & ~4) != 0) && (((b0 + 1) & 2) == 0); short_sym_mask = ballot(is_long_sym); batch_len = 0; - b = reinterpret_cast(shuffle(reinterpret_cast(b))); + b = reinterpret_cast(shuffle(reinterpret_cast(b))); if (!(short_sym_mask & 1)) { batch_len = shuffle((t == 0) ? (short_sym_mask) ? __ffs(short_sym_mask) - 1 : 32 : 0); if (batch_len != 0) { @@ -509,7 +509,7 @@ __device__ void snappy_process_symbols(unsnap_state_s* s, int t, Storage& temp_s int batch = 0; do { - volatile unsnap_batch_s* b = &s->q.batch[batch * batch_size]; + unsnap_batch_s volatile* b = &s->q.batch[batch * batch_size]; int32_t batch_len, blen_t, dist_t; if (t == 0) { diff --git a/cpp/src/io/json/host_tree_algorithms.cu b/cpp/src/io/json/host_tree_algorithms.cu index d907eedd17eb..c20c926237a2 100644 --- a/cpp/src/io/json/host_tree_algorithms.cu +++ b/cpp/src/io/json/host_tree_algorithms.cu @@ -239,8 +239,8 @@ void scatter_offsets(tree_meta_t const& tree, device_span node_ids, device_span sorted_col_ids, // Reuse this for parent_col_ids tree_meta_t const& d_column_tree, - host_span ignore_vals, - host_span is_mixed, + host_span ignore_vals, + host_span is_mixed, hashmap_of_device_columns const& columns, rmm::cuda_stream_view stream); @@ -889,8 +889,8 @@ void scatter_offsets(tree_meta_t const& tree, device_span node_ids, device_span sorted_col_ids, // Reuse this for parent_col_ids tree_meta_t const& d_column_tree, - host_span ignore_vals, - host_span is_mixed_pruned, + host_span ignore_vals, + host_span is_mixed_pruned, hashmap_of_device_columns const& columns, rmm::cuda_stream_view stream) { diff --git a/cpp/src/io/json/json_column.cu b/cpp/src/io/json/json_column.cu index aca69ab26c3e..c3542fcd530d 100644 --- a/cpp/src/io/json/json_column.cu +++ b/cpp/src/io/json/json_column.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -522,7 +522,7 @@ table_with_metadata device_parse_nested_json_impl(device_span d_i auto gpu_tree = [&]() { // Parse the JSON and get the token stream - const auto [tokens_gpu, token_indices_gpu] = + auto const [tokens_gpu, token_indices_gpu] = get_token_stream(d_input, options, stream, cudf::get_current_device_resource_ref()); // gpu tree generation // Note that to normalize whitespaces in nested columns coerced to be string, we need the column diff --git a/cpp/src/io/json/process_tokens.cu b/cpp/src/io/json/process_tokens.cu index 3a249189e3ff..2c5472747487 100644 --- a/cpp/src/io/json/process_tokens.cu +++ b/cpp/src/io/json/process_tokens.cu @@ -1,6 +1,6 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -58,11 +58,11 @@ enum class string_state { ESCAPED_U // not a complete state }; -__device__ inline bool substr_eq(const char* data, +__device__ inline bool substr_eq(char const* data, SymbolOffsetT const start, SymbolOffsetT const end, SymbolOffsetT const expected_len, - const char* expected) + char const* expected) { if (end - start != expected_len) { return false; } for (auto idx = 0; idx < expected_len; idx++) { diff --git a/cpp/src/io/orc/stripe_data.cu b/cpp/src/io/orc/stripe_data.cu index 8c7789ae9c6c..f1b381c11dd6 100644 --- a/cpp/src/io/orc/stripe_data.cu +++ b/cpp/src/io/orc/stripe_data.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -762,7 +762,7 @@ integer_rlev1(orc_bytestream_s* bs, orc_rlev1_state_s* rle, T* vals, uint32_t ma /** * @brief Maps the RLEv2 5-bit length code to 6-bit length */ -static const __device__ __constant__ uint8_t kRLEv2_W[32] = { +static __device__ const __constant__ uint8_t kRLEv2_W[32] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 26, 28, 30, 32, 40, 48, 56, 64}; @@ -775,7 +775,7 @@ static const __device__ __constant__ uint8_t kRLEv2_W[32] = { * * @see https://github.com/apache/orc/commit/9faf7f5147a7bc69 */ -static const __device__ __constant__ uint8_t ClosestFixedBitsMap[65] = { +static __device__ const __constant__ uint8_t ClosestFixedBitsMap[65] = { 1, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 26, 26, 28, 28, 30, 30, 32, 32, 40, 40, 40, 40, 40, 40, 40, 40, 48, 48, 48, 48, 48, 48, 48, 48, 56, 56, 56, 56, 56, 56, 56, 56, 64, 64, 64, 64, 64, 64, 64, 64}; @@ -1131,7 +1131,7 @@ byte_rle(orc_bytestream_s* bs, orc_byte_rle_state_s* rle, uint8_t* vals, uint32_ return rle->num_vals; } -static const __device__ __constant__ int64_t kPow5i[28] = {1, +static __device__ const __constant__ int64_t kPow5i[28] = {1, 5, 25, 125, @@ -1533,7 +1533,7 @@ static __device__ void DecodeRowPositions(orcdec_state_s* s, /** * @brief Trailing zeroes for decoding timestamp nanoseconds */ -static const __device__ __constant__ uint32_t kTimestampNanoScale[8] = { +static __device__ const __constant__ uint32_t kTimestampNanoScale[8] = { 1, 100, 1000, 10000, 100000, 1000000, 10000000, 100000000}; /** diff --git a/cpp/src/io/orc/stripe_enc.cu b/cpp/src/io/orc/stripe_enc.cu index 1a18a2dcc1ea..61a96c84f08f 100644 --- a/cpp/src/io/orc/stripe_enc.cu +++ b/cpp/src/io/orc/stripe_enc.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -275,7 +275,7 @@ static __device__ uint32_t byte_rle( /** * @brief Maps the symbol size in bytes to RLEv2 5-bit length code */ -static const __device__ __constant__ uint8_t kByteLengthToRLEv2_W[9] = { +static __device__ const __constant__ uint8_t kByteLengthToRLEv2_W[9] = { 0, 7, 15, 23, 27, 28, 29, 30, 31}; /** diff --git a/cpp/src/io/orc/writer_impl.cu b/cpp/src/io/orc/writer_impl.cu index 9768c578dd1e..25600d14f44a 100644 --- a/cpp/src/io/orc/writer_impl.cu +++ b/cpp/src/io/orc/writer_impl.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -593,7 +593,7 @@ orc_streams create_streams(host_span columns, auto add_stream = [&](stream_index_type index_type, StreamKind kind, TypeKind type_kind, size_t size) { auto const max_alignment_padding = compress_required_chunk_alignment(compression) - 1; - const auto base = column.index() * CI_NUM_STREAMS; + auto const base = column.index() * CI_NUM_STREAMS; ids[base + index_type] = streams.size(); streams.push_back( Stream{kind, diff --git a/cpp/src/io/parquet/decode_fixed.cu b/cpp/src/io/parquet/decode_fixed.cu index b002598c82ab..c2adc419434b 100644 --- a/cpp/src/io/parquet/decode_fixed.cu +++ b/cpp/src/io/parquet/decode_fixed.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #include "page_data.cuh" @@ -711,7 +711,7 @@ __device__ int update_validity_and_row_indices_lists(int32_t target_value_count, // and we have a valid data_out pointer, it implies this is a list column, so // emit an offset. if (in_nesting_bounds && ni.data_out != nullptr) { - const auto& next_ni = s->nesting_info[d_idx + 1]; + auto const& next_ni = s->nesting_info[d_idx + 1]; int const idx = ni.value_count + thread_value_count; cudf::size_type const ofs = next_ni.value_count + next_thread_value_count + next_ni.page_start_value; diff --git a/cpp/src/io/parquet/page_decode.cuh b/cpp/src/io/parquet/page_decode.cuh index 9431be2d0255..9d03f3f7e4f9 100644 --- a/cpp/src/io/parquet/page_decode.cuh +++ b/cpp/src/io/parquet/page_decode.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -390,7 +390,7 @@ __device__ cuda::std::pair decode_dictionary_indices( if (t >= batch_len || (pos + t >= target_pos)) { return 0; } uint32_t const dict_pos = (s->dict_bits > 0) ? dict_idx * sizeof(string_index_pair) : 0; if (dict_pos < (uint32_t)s->dict_size) { - const auto* src = reinterpret_cast(s->dict_base + dict_pos); + auto const* src = reinterpret_cast(s->dict_base + dict_pos); return src->second; } return 0; diff --git a/cpp/src/io/parquet/page_string_decode.cu b/cpp/src/io/parquet/page_string_decode.cu index 663a828e4a2f..1f7105a366ff 100644 --- a/cpp/src/io/parquet/page_string_decode.cu +++ b/cpp/src/io/parquet/page_string_decode.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -1079,7 +1079,7 @@ inline __device__ bool prefetch_string_data(int t, if (thread_bytes_to_copy > 0) { int32_t const thread_copy_from_index = buffer_base + thread_offset; cuda::std::memcpy(reinterpret_cast(&prefetch_buffer[thread_offset]), - reinterpret_cast(&cur[thread_copy_from_index]), + reinterpret_cast(&cur[thread_copy_from_index]), thread_bytes_to_copy); } } @@ -1207,7 +1207,7 @@ inline __device__ void read_string_offsets_sequential(page_state_s* s, // Read the length of the string from the data stream int32_t len; cuda::std::memcpy(reinterpret_cast(&len), - reinterpret_cast(&cur[length_offset]), + reinterpret_cast(&cur[length_offset]), sizeof(int32_t)); if (string_offset + len > dict_size) { diff --git a/cpp/src/io/parquet/reader_impl_helpers.cpp b/cpp/src/io/parquet/reader_impl_helpers.cpp index 18091cf35822..37f11c1ddf46 100644 --- a/cpp/src/io/parquet/reader_impl_helpers.cpp +++ b/cpp/src/io/parquet/reader_impl_helpers.cpp @@ -1752,7 +1752,7 @@ aggregate_reader_metadata::select_columns( has_list_parent || col_type == type_id::LIST); } } else { - for (const auto& idx : col_name_info->children) { + for (auto const& idx : col_name_info->children) { path_is_valid |= build_column(&idx, find_schema_child(schema_elem, idx.name), output_col.children, diff --git a/cpp/src/io/parquet/reader_impl_preprocess.cu b/cpp/src/io/parquet/reader_impl_preprocess.cu index 2b9723c03b63..7f33cf249289 100644 --- a/cpp/src/io/parquet/reader_impl_preprocess.cu +++ b/cpp/src/io/parquet/reader_impl_preprocess.cu @@ -932,7 +932,7 @@ void reader_impl::allocate_columns(read_mode mode, size_t skip_rows, size_t num_ // Validity Buffer is a uint32_t pointer std::vector> nullmask_bufs; - for (const auto& input_col : _input_columns) { + for (auto const& input_col : _input_columns) { size_t const max_depth = input_col.nesting_depth(); auto* cols = &_output_buffers; diff --git a/cpp/src/io/utilities/base64_utilities.cpp b/cpp/src/io/utilities/base64_utilities.cpp index 276e77acbe75..94961f36fe25 100644 --- a/cpp/src/io/utilities/base64_utilities.cpp +++ b/cpp/src/io/utilities/base64_utilities.cpp @@ -1,6 +1,6 @@ /* * SPDX-FileCopyrightText: Copyright (C) 2004-2017, 2020-2022 René Nyffenegger - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 AND Zlib */ @@ -59,7 +59,7 @@ // altered: use cudf namespaces namespace cudf::io::detail { -static const std::string base64_chars = +static std::string const base64_chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ" "abcdefghijklmnopqrstuvwxyz" "0123456789+/"; diff --git a/cpp/src/merge/merge.cu b/cpp/src/merge/merge.cu index da696419d8ca..565e90466899 100644 --- a/cpp/src/merge/merge.cu +++ b/cpp/src/merge/merge.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -117,7 +117,7 @@ CUDF_KERNEL void materialize_merged_bitmask_kernel( column_device_view right_dcol, bitmask_type* out_validity, size_type const num_destination_rows, - index_type const* const __restrict__ merged_indices) + index_type const* __restrict__ const merged_indices) { auto const stride = detail::grid_1d::grid_stride(); diff --git a/cpp/src/partitioning/partitioning.cu b/cpp/src/partitioning/partitioning.cu index bede1b88780f..99cc16e27bb5 100644 --- a/cpp/src/partitioning/partitioning.cu +++ b/cpp/src/partitioning/partitioning.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -58,7 +58,7 @@ class modulo_partitioner { __device__ size_type operator()(hash_value_t hash_value) const { return hash_value % divisor; } private: - const size_type divisor; + size_type const divisor; }; template @@ -88,7 +88,7 @@ class bitwise_partitioner { } private: - const size_type mask; + size_type const mask; }; /** diff --git a/cpp/src/reductions/scan/ewm.cu b/cpp/src/reductions/scan/ewm.cu index 01a1de93e1b8..dea775762f52 100644 --- a/cpp/src/reductions/scan/ewm.cu +++ b/cpp/src/reductions/scan/ewm.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -46,7 +46,7 @@ class recurrence_functor { template struct ewma_functor_base { T beta; - const pair_type IDENTITY{1.0, 0.0}; + pair_type const IDENTITY{1.0, 0.0}; }; template diff --git a/cpp/src/rolling/jit/kernel.cu b/cpp/src/rolling/jit/kernel.cu index 141758a71666..e255d7b3a967 100644 --- a/cpp/src/rolling/jit/kernel.cu +++ b/cpp/src/rolling/jit/kernel.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -47,7 +47,7 @@ template __device__ void rolling_window_kernel(cudf::size_type nrows, void const* __restrict__ p_in_col, - cudf::bitmask_type const* const __restrict__ in_col_valid, + cudf::bitmask_type const* __restrict__ const in_col_valid, void* __restrict__ p_out_col, cudf::bitmask_type* __restrict__ out_col_valid, cudf::size_type* __restrict__ output_valid_count, diff --git a/cpp/src/strings/copying/copy_range.cu b/cpp/src/strings/copying/copy_range.cu index 50e3004a8a34..95c69aadce34 100644 --- a/cpp/src/strings/copying/copy_range.cu +++ b/cpp/src/strings/copying/copy_range.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -97,7 +97,7 @@ std::unique_ptr copy_range(strings_column_view const& source, [d_source, d_target, source_begin, target_begin, target_end, d_offsets, d_chars] __device__( size_type idx) { if (d_offsets[idx + 1] - d_offsets[idx] > 0) { - const auto source = (idx >= target_begin && idx < target_end) + auto const source = (idx >= target_begin && idx < target_end) ? d_source.element(source_begin + (idx - target_begin)) : d_target.element(idx); memcpy(d_chars + d_offsets[idx], source.data(), source.size_bytes()); diff --git a/cpp/src/strings/regex/regcomp.cpp b/cpp/src/strings/regex/regcomp.cpp index af70f54eb737..a065799b0ae9 100644 --- a/cpp/src/strings/regex/regcomp.cpp +++ b/cpp/src/strings/regex/regcomp.cpp @@ -1222,7 +1222,7 @@ void reprog::check_for_errors() match_flags reprog::compute_match_flags() const { - static const std::unordered_set non_consuming_inst_types{ + static std::unordered_set const non_consuming_inst_types{ OR, BOL, EOL, BOW, NBOW, LBRA, RBRA}; auto check_paths = [this](auto&& self, int id, std::unordered_set& visited) -> bool { diff --git a/cpp/src/utilities/cuda_memcpy.cu b/cpp/src/utilities/cuda_memcpy.cu index e0624d91b541..8e961a9cf633 100644 --- a/cpp/src/utilities/cuda_memcpy.cu +++ b/cpp/src/utilities/cuda_memcpy.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #include @@ -33,7 +33,7 @@ void copy_pinned(void* dst, void const* src, std::size_t size, rmm::cuda_stream_ if (size == 0) return; if (size < get_kernel_pinned_copy_threshold()) { - const int block_size = 256; + int const block_size = 256; auto const grid_size = cudf::util::div_rounding_up_safe(size, block_size); // We are explicitly launching the kernel here instead of calling a thrust function because the // thrust function can potentially call cudaMemcpyAsync instead of using a kernel diff --git a/cpp/src/utilities/stream_pool.cpp b/cpp/src/utilities/stream_pool.cpp index 534f81ab5506..6c65a4067347 100644 --- a/cpp/src/utilities/stream_pool.cpp +++ b/cpp/src/utilities/stream_pool.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -52,8 +52,8 @@ struct cuda_event { virtual ~cuda_event() { CUDF_ASSERT_CUDA_SUCCESS(cudaEventDestroy(e_)); } // Moveable but not copyable. - cuda_event(const cuda_event&) = delete; - cuda_event& operator=(const cuda_event&) = delete; + cuda_event(cuda_event const&) = delete; + cuda_event& operator=(cuda_event const&) = delete; cuda_event(cuda_event&&) = default; cuda_event& operator=(cuda_event&&) = default; diff --git a/cpp/src/utilities/time_utils.cuh b/cpp/src/utilities/time_utils.cuh index 5281950bde5d..af0611467a70 100644 --- a/cpp/src/utilities/time_utils.cuh +++ b/cpp/src/utilities/time_utils.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -10,7 +10,7 @@ namespace cudf::detail { /** * @brief Lookup table to compute power of ten */ -static const __device__ __constant__ int32_t powers_of_ten[10] = { +static __device__ const __constant__ int32_t powers_of_ten[10] = { 1, 10, 100, 1000, 10000, 100000, 1000000, 10000000, 100000000, 1000000000}; } // namespace cudf::detail diff --git a/cpp/tests/copying/copy_range_tests.cpp b/cpp/tests/copying/copy_range_tests.cpp index eefa42b7bbb3..1f7f3dd4d5d6 100644 --- a/cpp/tests/copying/copy_range_tests.cpp +++ b/cpp/tests/copying/copy_range_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -38,7 +38,7 @@ class CopyRangeTypedTestFixture : public cudf::test::BaseFixture { // test the out-of-place version first - const cudf::column_view immutable_view{target}; + cudf::column_view const immutable_view{target}; auto p_ret = cudf::copy_range(source, immutable_view, source_begin, source_end, target_begin); CUDF_TEST_EXPECT_COLUMNS_EQUAL(*p_ret, expected); diff --git a/cpp/tests/copying/scatter_list_scalar_tests.cpp b/cpp/tests/copying/scatter_list_scalar_tests.cpp index b2ab2e180ca9..b0b56f084a65 100644 --- a/cpp/tests/copying/scatter_list_scalar_tests.cpp +++ b/cpp/tests/copying/scatter_list_scalar_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2021-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -20,7 +20,7 @@ std::unique_ptr single_scalar_scatter(cudf::column_view const& tar cudf::scalar const& slr, cudf::column_view const& scatter_map) { - std::vector> slrs{slr}; + std::vector> slrs{slr}; cudf::table_view targets{{target}}; auto result = cudf::scatter(slrs, scatter_map, targets); return std::move(result->release()[0]); diff --git a/cpp/tests/copying/scatter_tests.cpp b/cpp/tests/copying/scatter_tests.cpp index ced7bd58c456..f791c357586c 100644 --- a/cpp/tests/copying/scatter_tests.cpp +++ b/cpp/tests/copying/scatter_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -49,8 +49,8 @@ TEST_F(ScatterUntypedTests, ScatterMapNulls) TEST_F(ScatterUntypedTests, ScatterScalarMapNulls) { auto const source = cudf::scalar_type_t{100}; - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target({10, 20, 30, 40, 50, 60, 70, 80}); cudf::test::fixed_width_column_wrapper scatter_map({-3, 3, 1, -1}, @@ -78,8 +78,8 @@ TEST_F(ScatterUntypedTests, ScatterColumnNumberMismatch) TEST_F(ScatterUntypedTests, ScatterScalarColumnNumberMismatch) { auto const source = cudf::scalar_type_t(100); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target({10, 20, 30, 40, 50, 60, 70, 80}); cudf::test::fixed_width_column_wrapper scatter_map({-3, 3, 1, -1}); @@ -106,8 +106,8 @@ TEST_F(ScatterUntypedTests, ScatterDataTypeMismatch) TEST_F(ScatterUntypedTests, ScatterScalarDataTypeMismatch) { auto const source = cudf::scalar_type_t(100); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target({10, 20, 30, 40, 50, 60, 70, 80}); cudf::test::fixed_width_column_wrapper scatter_map({-3, 3, 1, -1}); @@ -144,8 +144,8 @@ TYPED_TEST(ScatterIndexTypeTests, ScatterIndexType) TYPED_TEST(ScatterIndexTypeTests, ScatterScalarIndexType) { auto const source = cudf::scalar_type_t(100, true); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target({10, 20, 30, 40, 50, 60, 70, 80}); cudf::test::fixed_width_column_wrapper scatter_map({-3, 3, 1, -1}); @@ -185,8 +185,8 @@ TYPED_TEST(ScatterInvalidIndexTypeTests, ScatterInvalidIndexType) TYPED_TEST(ScatterInvalidIndexTypeTests, ScatterScalarInvalidIndexType) { auto const source = cudf::scalar_type_t(100, true); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target({10, 20, 30, 40, 50, 60, 70, 80}); cudf::test::fixed_width_column_wrapper scatter_map({-3, 3, 1, -1}); @@ -223,8 +223,8 @@ TYPED_TEST(ScatterDataTypeTests, EmptyScalarScatterMap) { auto const source = cudf::scalar_type_t(cudf::test::make_type_param_scalar(100), true); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target( {10, 20, 30, 40, 50, 60, 70, 80}); @@ -315,8 +315,8 @@ TYPED_TEST(ScatterDataTypeTests, ScatterScalarNoNulls) auto const source = cudf::scalar_type_t(cudf::test::make_type_param_scalar(100), true); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target( {10, 20, 30, 40, 50, 60, 70, 80}); @@ -338,8 +338,8 @@ TYPED_TEST(ScatterDataTypeTests, ScatterScalarTargetNulls) auto const source = cudf::scalar_type_t(cudf::test::make_type_param_scalar(100), true); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target( {10, 20, 30, 40, 50, 60, 70, 80}, {0, 0, 0, 0, 1, 1, 1, 1}); @@ -361,8 +361,8 @@ TYPED_TEST(ScatterDataTypeTests, ScatterScalarSourceNulls) auto const source = cudf::scalar_type_t(cudf::test::make_type_param_scalar(100), false); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target( {10, 20, 30, 40, 50, 60, 70, 80}); @@ -384,8 +384,8 @@ TYPED_TEST(ScatterDataTypeTests, ScatterScalarBothNulls) auto const source = cudf::scalar_type_t(cudf::test::make_type_param_scalar(100), false); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target( {10, 20, 30, 40, 50, 60, 70, 80}, {0, 0, 0, 0, 1, 1, 1, 1}); @@ -455,8 +455,8 @@ TEST_F(ScatterStringsTests, ScatterNoNulls) TEST_F(ScatterStringsTests, ScatterScalarNoNulls) { auto const source = cudf::string_scalar("buffalo"); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; std::vector h_target{ "Buffalo", "bison", "Buffalo", "bison", "bully", "bully", "Buffalo", "bison"}; @@ -666,7 +666,7 @@ TYPED_TEST(BooleanMaskScalarScatter, WithNoNullElementsInTarget) T source = cudf::test::make_type_param_scalar(11); bool validity = true; auto scalar = this->form_scalar(source, validity); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.push_back(*scalar); cudf::test::fixed_width_column_wrapper target({2, 2, 3, 4, 11, 12, 7, 7, 10, 10}); cudf::test::fixed_width_column_wrapper mask( @@ -689,7 +689,7 @@ TYPED_TEST(BooleanMaskScalarScatter, WithNull) auto scalar_1 = this->form_scalar(source, validity); auto scalar_2 = cudf::make_string_scalar("cudf"); scalar_2->set_valid_async(true); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.push_back(*scalar_1); scalar_vect.emplace_back(*scalar_2); cudf::test::fixed_width_column_wrapper target_col1({2, 2, 3, 4, 11, 12, 7, 7, 10, 10}, @@ -719,7 +719,7 @@ TEST_F(BooleanMaskScatterScalarString, NoNUll) { auto scalar = cudf::make_string_scalar("cudf"); scalar->set_valid_async(true); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.emplace_back(*scalar); cudf::test::strings_column_wrapper target({"is", "is", "a", "udf", "api"}); @@ -738,7 +738,7 @@ TEST_F(BooleanMaskScatterScalarString, WithNUll) { auto scalar = cudf::make_string_scalar("cudf"); scalar->set_valid_async(true); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.emplace_back(*scalar); cudf::test::strings_column_wrapper target({"is", "", "", "udf", "api"}, {true, false, false, true, true}); @@ -759,7 +759,7 @@ TEST_F(BooleanMaskScatterScalarFails, SourceAndTargetTypeMismatch) { auto scalar = cudf::make_numeric_scalar(cudf::data_type(cudf::data_type{cudf::type_to_id()})); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.emplace_back(*scalar); cudf::test::fixed_width_column_wrapper target({2, 2, 3, 4, 11, 12, 7, 7, 10, 10}); cudf::test::fixed_width_column_wrapper mask( @@ -773,7 +773,7 @@ TEST_F(BooleanMaskScatterScalarFails, BooleanMaskTypeMismatch) { auto scalar = cudf::make_numeric_scalar(cudf::data_type(cudf::data_type{cudf::type_to_id()})); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.emplace_back(*scalar); cudf::test::fixed_width_column_wrapper target({2, 2, 3, 4, 11, 12, 7, 7, 10, 10}); cudf::test::fixed_width_column_wrapper mask( @@ -787,7 +787,7 @@ TEST_F(BooleanMaskScatterScalarFails, BooleanMaskTargetSizeMismatch) { auto scalar = cudf::make_numeric_scalar(cudf::data_type(cudf::data_type{cudf::type_to_id()})); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.emplace_back(*scalar); cudf::test::fixed_width_column_wrapper target({2, 2, 3, 4, 11, 12, 7, 7, 10, 10}); cudf::test::fixed_width_column_wrapper mask( @@ -801,7 +801,7 @@ TEST_F(BooleanMaskScatterScalarFails, NumberOfColumnAndScalarMismatch) { auto scalar = cudf::make_numeric_scalar(cudf::data_type(cudf::data_type{cudf::type_to_id()})); - std::vector> scalar_vect; + std::vector> scalar_vect; scalar_vect.emplace_back(*scalar); scalar_vect.emplace_back(*scalar); cudf::test::fixed_width_column_wrapper target({2, 2, 3, 4, 11, 12, 7, 7, 10, 10}); diff --git a/cpp/tests/dictionary/scatter_test.cpp b/cpp/tests/dictionary/scatter_test.cpp index 1b3b6249ac85..95e820580573 100644 --- a/cpp/tests/dictionary/scatter_test.cpp +++ b/cpp/tests/dictionary/scatter_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -59,10 +59,10 @@ TEST_F(DictionaryScatterTest, ScatterScalar) cudf::test::strings_column_wrapper strings_target{ "eee", "aaa", "ddd", "ccc", "ccc", "ccc", "eee", "aaa"}; auto target = cudf::dictionary::encode(strings_target); - std::vector> source; + std::vector> source; - const cudf::string_scalar source_scalar = cudf::string_scalar("bbb"); - std::reference_wrapper slr_wrapper = std::ref(source_scalar); + cudf::string_scalar const source_scalar = cudf::string_scalar("bbb"); + std::reference_wrapper slr_wrapper = std::ref(source_scalar); source.emplace_back(slr_wrapper); cudf::test::fixed_width_column_wrapper scatter_map{0, 2, 3, 7}; @@ -104,9 +104,9 @@ TEST_F(DictionaryScatterTest, ScalarWithNulls) cudf::test::fixed_width_column_wrapper data_target{ {1, 5, 5, 3, 7, 1, 4, 2}, {false, true, false, true, true, true, true, true}}; auto target = cudf::dictionary::encode(data_target); - std::vector> source; - const cudf::numeric_scalar source_slr = cudf::test::make_type_param_scalar(100); - std::reference_wrapper> slr_wrapper = std::ref(source_slr); + std::vector> source; + cudf::numeric_scalar const source_slr = cudf::test::make_type_param_scalar(100); + std::reference_wrapper const> slr_wrapper = std::ref(source_slr); source.emplace_back(slr_wrapper); cudf::test::fixed_width_column_wrapper scatter_map{7, 2, 3, 1, -3}; diff --git a/cpp/tests/groupby/shift_tests.cpp b/cpp/tests/groupby/shift_tests.cpp index bf0753b46473..0b9756e7115a 100644 --- a/cpp/tests/groupby/shift_tests.cpp +++ b/cpp/tests/groupby/shift_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2021-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -403,7 +403,7 @@ template void test_groupby_shift_multi(cudf::test::fixed_width_column_wrapper const& key, cudf::table_view const& value, std::vector offsets, - std::vector> fill_values, + std::vector> fill_values, cudf::table_view const& expected) { cudf::groupby::groupby gb_obj(cudf::table_view({key})); @@ -428,7 +428,7 @@ TYPED_TEST(groupby_shift_mixed_test, NoFill) std::vector offset{2, 1}; auto slr1 = cudf::make_default_constructed_scalar(cudf::column_view(v1).type()); auto slr2 = cudf::make_default_constructed_scalar(cudf::column_view(v2).type()); - std::vector> fill_values{*slr1, *slr2}; + std::vector> fill_values{*slr1, *slr2}; test_groupby_shift_multi(key, value, offset, fill_values, expected); } @@ -450,7 +450,7 @@ TYPED_TEST(groupby_shift_mixed_test, Fill) auto slr1 = cudf::make_string_scalar("42"); auto slr2 = cudf::scalar_type_t(cudf::test::make_type_param_scalar(42), true); - std::vector> fill_values{*slr1, slr2}; + std::vector> fill_values{*slr1, slr2}; test_groupby_shift_multi(key, value, offset, fill_values, expected); } @@ -470,7 +470,7 @@ TEST_F(groupby_shift_fixed_point_type_test, Matching) std::vector offset{-3, 1}; auto slr1 = cudf::make_fixed_point_scalar(-42, numeric::scale_type{-1}); auto slr2 = cudf::make_fixed_point_scalar(42, numeric::scale_type{3}); - std::vector> fill_values{*slr1, *slr2}; + std::vector> fill_values{*slr1, *slr2}; cudf::test::fixed_point_column_wrapper e1{{-42, -42, -42, -42, -42, -42, -42, -42}, numeric::scale_type{-1}}; diff --git a/cpp/tests/interop/from_arrow_device_test.cpp b/cpp/tests/interop/from_arrow_device_test.cpp index 0e50a5ecda2f..18823a6deee0 100644 --- a/cpp/tests/interop/from_arrow_device_test.cpp +++ b/cpp/tests/interop/from_arrow_device_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -138,7 +138,7 @@ TYPED_TEST(FromArrowDeviceTestDurationsTest, DurationTable) auto col = cudf::test::fixed_width_column_wrapper(data); cudf::table_view expected_table_view({col}); - const ArrowTimeUnit time_unit = [&] { + ArrowTimeUnit const time_unit = [&] { switch (cudf::type_to_id()) { case cudf::type_id::DURATION_SECONDS: return NANOARROW_TIME_UNIT_SECOND; case cudf::type_id::DURATION_MILLISECONDS: return NANOARROW_TIME_UNIT_MILLI; diff --git a/cpp/tests/interop/from_arrow_host_test.cpp b/cpp/tests/interop/from_arrow_host_test.cpp index a1829a95fe8c..9db3a47073fe 100644 --- a/cpp/tests/interop/from_arrow_host_test.cpp +++ b/cpp/tests/interop/from_arrow_host_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -162,7 +162,7 @@ TYPED_TEST(FromArrowHostDeviceTestDurationsTest, DurationTable) auto col = cudf::test::fixed_width_column_wrapper(data, cuda::constant_iterator(true)); cudf::table_view expected_table_view({col}); - const ArrowTimeUnit time_unit = [&] { + ArrowTimeUnit const time_unit = [&] { switch (cudf::type_to_id()) { case cudf::type_id::DURATION_SECONDS: return NANOARROW_TIME_UNIT_SECOND; case cudf::type_id::DURATION_MILLISECONDS: return NANOARROW_TIME_UNIT_MILLI; diff --git a/cpp/tests/interop/from_arrow_test.cpp b/cpp/tests/interop/from_arrow_test.cpp index 06f20289882d..3ee6c378f558 100644 --- a/cpp/tests/interop/from_arrow_test.cpp +++ b/cpp/tests/interop/from_arrow_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -595,7 +595,7 @@ TYPED_TEST(FromArrowNumericScalarTest, Basic) struct FromArrowDecimalScalarTest : public cudf::test::BaseFixture {}; template -void check_decimal_scalar(const int value, ScalarType const& arrow_scalar) +void check_decimal_scalar(int const value, ScalarType const& arrow_scalar) { auto const scale{4}; auto const cudf_scalar = export_scalar(arrow_scalar); diff --git a/cpp/tests/interop/to_arrow_device_test.cpp b/cpp/tests/interop/to_arrow_device_test.cpp index b15443c6166d..7c4e5ea043f0 100644 --- a/cpp/tests/interop/to_arrow_device_test.cpp +++ b/cpp/tests/interop/to_arrow_device_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -242,7 +242,7 @@ struct BaseArrowFixture : public cudf::test::BaseFixture { } } - void compare_device_buffers(const size_t nbytes, + void compare_device_buffers(size_t const nbytes, int const buffer_idx, ArrowArray const* expected, ArrowArray const* actual) @@ -269,10 +269,10 @@ struct BaseArrowFixture : public cudf::test::BaseFixture { if (expected->length > 0) { EXPECT_EQ(expected->buffers[0], actual->buffers[0]); if (schema_view.type == NANOARROW_TYPE_BOOL) { - const size_t nbytes = (expected->length + 7) >> 3; + size_t const nbytes = (expected->length + 7) >> 3; compare_device_buffers(nbytes, 1, expected, actual); } else if (schema_view.type == NANOARROW_TYPE_DECIMAL128) { - const size_t nbytes = (expected->length * sizeof(__int128_t)); + size_t const nbytes = (expected->length * sizeof(__int128_t)); compare_device_buffers(nbytes, 1, expected, actual); } else { for (int i = 1; i < expected->n_buffers; ++i) { @@ -432,7 +432,7 @@ TYPED_TEST(ToArrowDeviceTestDurationsTest, DurationTable) NANOARROW_THROW_NOT_OK(ArrowSchemaSetTypeStruct(expected_schema.get(), 1)); ArrowSchemaInit(expected_schema->children[0]); - const ArrowTimeUnit arrow_unit = [&] { + ArrowTimeUnit const arrow_unit = [&] { switch (cudf::type_to_id()) { case cudf::type_id::DURATION_SECONDS: return NANOARROW_TIME_UNIT_SECOND; case cudf::type_id::DURATION_MILLISECONDS: return NANOARROW_TIME_UNIT_MILLI; diff --git a/cpp/tests/interop/to_arrow_host_test.cpp b/cpp/tests/interop/to_arrow_host_test.cpp index 13a37c9ff3d9..2a2e4f96406a 100644 --- a/cpp/tests/interop/to_arrow_host_test.cpp +++ b/cpp/tests/interop/to_arrow_host_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -35,12 +35,12 @@ struct BaseToArrowHostFixture : public cudf::test::BaseFixture { requires(cudf::is_fixed_width() and !std::is_same_v) { for (int64_t i = 0; i < length; ++i) { - const bool is_null = ArrowArrayViewIsNull(expected, start_offset_expected + i); + bool const is_null = ArrowArrayViewIsNull(expected, start_offset_expected + i); EXPECT_EQ(is_null, ArrowArrayViewIsNull(actual, start_offset_actual + i)); if (is_null) continue; - const auto expected_val = ArrowArrayViewGetIntUnsafe(expected, start_offset_expected + i); - const auto actual_val = ArrowArrayViewGetIntUnsafe(actual, start_offset_actual + i); + auto const expected_val = ArrowArrayViewGetIntUnsafe(expected, start_offset_expected + i); + auto const actual_val = ArrowArrayViewGetIntUnsafe(actual, start_offset_actual + i); EXPECT_EQ(expected_val, actual_val); } @@ -55,12 +55,12 @@ struct BaseToArrowHostFixture : public cudf::test::BaseFixture { requires(std::is_same_v) { for (int64_t i = 0; i < length; ++i) { - const bool is_null = ArrowArrayViewIsNull(expected, start_offset_expected + i); + bool const is_null = ArrowArrayViewIsNull(expected, start_offset_expected + i); EXPECT_EQ(is_null, ArrowArrayViewIsNull(actual, start_offset_actual + i)); if (is_null) continue; - const auto expected_view = ArrowArrayViewGetBytesUnsafe(expected, start_offset_expected + i); - const auto actual_view = ArrowArrayViewGetBytesUnsafe(actual, start_offset_actual + i); + auto const expected_view = ArrowArrayViewGetBytesUnsafe(expected, start_offset_expected + i); + auto const actual_view = ArrowArrayViewGetBytesUnsafe(actual, start_offset_actual + i); EXPECT_EQ(expected_view.size_bytes, actual_view.size_bytes); EXPECT_TRUE( @@ -80,25 +80,25 @@ struct BaseToArrowHostFixture : public cudf::test::BaseFixture { switch (expected->storage_type) { case NANOARROW_TYPE_LIST: for (int64_t i = 0; i < length; ++i) { - const auto expected_start = exp_start_offset + i; - const auto actual_start = act_start_offset + i; + auto const expected_start = exp_start_offset + i; + auto const actual_start = act_start_offset + i; // ArrowArrayViewIsNull accounts for the array offset, so we can properly // compare the validity of indexes - const bool is_null = ArrowArrayViewIsNull(expected, expected_start); + bool const is_null = ArrowArrayViewIsNull(expected, expected_start); EXPECT_EQ(is_null, ArrowArrayViewIsNull(actual, actual_start)); if (is_null) continue; // ArrowArrayViewListChildOffset does not account for array offset, so we need // to add the offset to the index in order to get the correct offset into the list - const int64_t start_offset_expected = + int64_t const start_offset_expected = ArrowArrayViewListChildOffset(expected, expected->offset + expected_start); - const int64_t start_offset_actual = + int64_t const start_offset_actual = ArrowArrayViewListChildOffset(actual, actual->offset + actual_start); - const int64_t end_offset_expected = + int64_t const end_offset_expected = ArrowArrayViewListChildOffset(expected, expected->offset + expected_start + 1); - const int64_t end_offset_actual = + int64_t const end_offset_actual = ArrowArrayViewListChildOffset(actual, actual->offset + actual_start + 1); // verify the list lengths are the same @@ -115,10 +115,10 @@ struct BaseToArrowHostFixture : public cudf::test::BaseFixture { case NANOARROW_TYPE_STRUCT: for (int64_t i = 0; i < length; ++i) { SCOPED_TRACE("idx: " + std::to_string(i)); - const auto expected_start = exp_start_offset + i; - const auto actual_start = act_start_offset + i; + auto const expected_start = exp_start_offset + i; + auto const actual_start = act_start_offset + i; - const bool is_null = ArrowArrayViewIsNull(expected, expected_start); + bool const is_null = ArrowArrayViewIsNull(expected, expected_start); EXPECT_EQ(is_null, ArrowArrayViewIsNull(actual, actual_start)); if (is_null) continue; @@ -341,7 +341,7 @@ TYPED_TEST(ToArrowHostDeviceTestDurationsTest, DurationTable) NANOARROW_THROW_NOT_OK(ArrowSchemaSetTypeStruct(expected_schema.get(), 1)); ArrowSchemaInit(expected_schema->children[0]); - const ArrowTimeUnit arrow_unit = [&] { + ArrowTimeUnit const arrow_unit = [&] { switch (cudf::type_to_id()) { case cudf::type_id::DURATION_SECONDS: return NANOARROW_TIME_UNIT_SECOND; case cudf::type_id::DURATION_MILLISECONDS: return NANOARROW_TIME_UNIT_MILLI; diff --git a/cpp/tests/io/csv_test.cpp b/cpp/tests/io/csv_test.cpp index 2cb96215ab60..fd56b7a2e7b0 100644 --- a/cpp/tests/io/csv_test.cpp +++ b/cpp/tests/io/csv_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -2472,9 +2472,9 @@ TEST_F(CsvReaderTest, CsvDefaultOptionsWriteReadMatch) TEST_F(CsvReaderTest, UseColsValidation) { - const std::string buffer = "1,2,3"; + std::string const buffer = "1,2,3"; - const cudf::io::csv_reader_options idx_cnt_options = + cudf::io::csv_reader_options const idx_cnt_options = cudf::io::csv_reader_options::builder( cudf::io::source_info{cudf::host_span{ reinterpret_cast(buffer.c_str()), buffer.size()}}) @@ -2504,7 +2504,7 @@ TEST_F(CsvReaderTest, UseColsValidation) TEST_F(CsvReaderTest, CropColumns) { - const std::string csv_in{"12,9., 10\n34,8., 20\n56,7., 30"}; + std::string const csv_in{"12,9., 10\n34,8., 20\n56,7., 30"}; cudf::io::csv_reader_options in_opts = cudf::io::csv_reader_options::builder( diff --git a/cpp/tests/io/fst/fst_test.cu b/cpp/tests/io/fst/fst_test.cu index 1ebfc9fc8619..da21ae071fb0 100644 --- a/cpp/tests/io/fst/fst_test.cu +++ b/cpp/tests/io/fst/fst_test.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -143,7 +143,7 @@ TEST_F(FstTest, GroundTruth) size_t string_size = input.size() * (1 << 10); auto d_input_scalar = cudf::make_string_scalar(input); auto& d_string_scalar = static_cast(*d_input_scalar); - const cudf::size_type repeat_times = string_size / input.size(); + cudf::size_type const repeat_times = string_size / input.size(); auto d_input_string = cudf::strings::repeat_string(d_string_scalar, repeat_times); auto& d_input = static_cast&>(*d_input_string); input = d_input.to_string(stream); diff --git a/cpp/tests/io/json/json_test.cpp b/cpp/tests/io/json/json_test.cpp index 398078f77a08..d48af774f7a3 100644 --- a/cpp/tests/io/json/json_test.cpp +++ b/cpp/tests/io/json/json_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -631,7 +631,7 @@ TEST_P(JsonReaderParamTest, JsonLinesFileInput) to_records_orient({{{"0", "11"}, {"1", "1.1"}}, {{"0", "22"}, {"1", "2.2"}}}, "\n"); std::string data = is_row_orient_test(test_opt) ? row_orient : record_orient; - const std::string fname = temp_env->get_temp_dir() + "JsonLinesFileTest.json"; + std::string const fname = temp_env->get_temp_dir() + "JsonLinesFileTest.json"; std::ofstream outfile(fname, std::ofstream::out); outfile << data; outfile.close(); @@ -656,7 +656,7 @@ TEST_P(JsonReaderParamTest, JsonLinesFileInput) TEST_F(JsonReaderTest, JsonLinesByteRangeCompleteRecord) { - const std::string fname = temp_env->get_temp_dir() + "JsonLinesByteRangeTest.json"; + std::string const fname = temp_env->get_temp_dir() + "JsonLinesByteRangeTest.json"; std::ofstream outfile(fname, std::ofstream::out); outfile << "[1000]\n[2000]\n[3000]\n[4000]\n[5000]\n[6000]\n[7000]\n[8000]\n[9000]\n"; outfile.close(); @@ -682,7 +682,7 @@ TEST_F(JsonReaderTest, JsonLinesByteRangeCompleteRecord) TEST_F(JsonReaderTest, JsonLinesByteRangeIncompleteRecord) { - const std::string fname = temp_env->get_temp_dir() + "JsonLinesByteRangeTest.json"; + std::string const fname = temp_env->get_temp_dir() + "JsonLinesByteRangeTest.json"; std::ofstream outfile(fname, std::ofstream::out); outfile << "[1000]\n[2000]\n[3000]\n[4000]\n[5000]\n[6000]\n[7000]\n[8000]\n[9000]\n"; outfile.close(); @@ -754,7 +754,7 @@ TEST_F(JsonReaderTest, JsonLinesByteRangeWithRealloc) TEST_F(JsonReaderTest, JsonLinesMultipleFilesByteRange_AcrossFiles) { - const std::string file1 = temp_env->get_temp_dir() + "JsonLinesMultipleFilesByteRangeTest1.json"; + std::string const file1 = temp_env->get_temp_dir() + "JsonLinesMultipleFilesByteRangeTest1.json"; std::ofstream outfile1(file1, std::ofstream::out); outfile1 << "[1000]\n[2000]\n[3000]\n[4000]\n[5000]\n[6000]\n[7000]\n[8000]\n[9000]"; outfile1.close(); @@ -780,7 +780,7 @@ TEST_F(JsonReaderTest, JsonLinesMultipleFilesByteRange_AcrossFiles) TEST_F(JsonReaderTest, JsonLinesMultipleFilesByteRange_ExcessRangeSize) { - const std::string file1 = temp_env->get_temp_dir() + "JsonLinesMultipleFilesByteRangeTest1.json"; + std::string const file1 = temp_env->get_temp_dir() + "JsonLinesMultipleFilesByteRangeTest1.json"; std::ofstream outfile1(file1, std::ofstream::out); outfile1 << "[1000]\n[2000]\n[3000]\n[4000]\n[5000]\n[6000]\n[7000]\n[8000]\n[9000]"; outfile1.close(); @@ -820,7 +820,7 @@ TEST_F(JsonReaderTest, JsonLinesMultipleFilesByteRange_ExcessRangeSize) TEST_F(JsonReaderTest, JsonLinesMultipleFilesByteRange_LoadAllFiles) { - const std::string file1 = temp_env->get_temp_dir() + "JsonLinesMultipleFilesByteRangeTest1.json"; + std::string const file1 = temp_env->get_temp_dir() + "JsonLinesMultipleFilesByteRangeTest1.json"; std::ofstream outfile1(file1, std::ofstream::out); outfile1 << "[1000]\n[2000]\n[3000]\n[4000]\n[5000]\n[6000]\n[7000]\n[8000]\n[9000]"; outfile1.close(); @@ -859,7 +859,7 @@ TEST_F(JsonReaderTest, JsonLinesMultipleFilesByteRange_LoadAllFiles) TEST_P(JsonReaderRecordTest, JsonLinesObjects) { - const std::string fname = temp_env->get_temp_dir() + "JsonLinesObjectsTest.json"; + std::string const fname = temp_env->get_temp_dir() + "JsonLinesObjectsTest.json"; std::ofstream outfile(fname, std::ofstream::out); outfile << " {\"co\\\"l1\" : 1, \"col2\" : 2.0} \n"; outfile.close(); @@ -1286,12 +1286,12 @@ TEST_P(JsonReaderParamTest, JsonLinesMultipleFileInputs) to_records_orient({{{"0", "33"}, {"1", "3.3"}}, {{"0", "44"}, {"1", "4.4"}}}, "\n") + "\n"}; auto const& data = is_row_orient_test(test_opt) ? row_orient : record_orient; - const std::string file1 = temp_env->get_temp_dir() + "JsonLinesFileTest1.json"; + std::string const file1 = temp_env->get_temp_dir() + "JsonLinesFileTest1.json"; std::ofstream outfile(file1, std::ofstream::out); outfile << data[0]; outfile.close(); - const std::string file2 = temp_env->get_temp_dir() + "JsonLinesFileTest2.json"; + std::string const file2 = temp_env->get_temp_dir() + "JsonLinesFileTest2.json"; std::ofstream outfile2(file2, std::ofstream::out); outfile2 << data[1]; outfile2.close(); @@ -1325,12 +1325,12 @@ TEST_P(JsonReaderParamTest, JsonLinesMultipleFileInputsNoNL) to_records_orient({{{"0", "33"}, {"1", "3.3"}}, {{"0", "44"}, {"1", "4.4"}}}, "\n")}; auto const& data = is_row_orient_test(test_opt) ? row_orient : record_orient; - const std::string file1 = temp_env->get_temp_dir() + "JsonLinesFileTest1.json"; + std::string const file1 = temp_env->get_temp_dir() + "JsonLinesFileTest1.json"; std::ofstream outfile(file1, std::ofstream::out); outfile << data[0]; outfile.close(); - const std::string file2 = temp_env->get_temp_dir() + "JsonLinesFileTest2.json"; + std::string const file2 = temp_env->get_temp_dir() + "JsonLinesFileTest2.json"; std::ofstream outfile2(file2, std::ofstream::out); outfile2 << data[1]; outfile2.close(); @@ -1844,9 +1844,9 @@ TEST_P(JsonReaderParamTest, JsonDtypeParsing) make_validity(validity)}; // Types to test - const std::vector dtypes = { + std::vector const dtypes = { dtype(), dtype(), dtype(), dtype()}; - const std::vector cols{cudf::column_view(int_col), + std::vector const cols{cudf::column_view(int_col), cudf::column_view(float_col), cudf::column_view(str_col), cudf::column_view(bool_col)}; @@ -3644,9 +3644,9 @@ TEST_F(JsonReaderTest, DeviceReadAsyncThrows) try { cudf::io::read_json(read_args); // Test passes if no exception is thrown - } catch (const cudf::test::AsyncException&) { + } catch (cudf::test::AsyncException const&) { // Test passes if AsyncException is thrown (expected test exception) - } catch (const std::exception& e) { + } catch (std::exception const& e) { // Test fails if any other exception is thrown FAIL() << "Unexpected exception thrown: " << e.what(); } @@ -3667,9 +3667,9 @@ TEST_F(JsonReaderTest, DeviceWriteAsyncThrows) try { cudf::io::write_json(write_args); // Test passes if no exception is thrown - } catch (const cudf::test::AsyncException&) { + } catch (cudf::test::AsyncException const&) { // Test passes if AsyncException is thrown (expected test exception) - } catch (const std::exception& e) { + } catch (std::exception const& e) { // Test fails if any other exception is thrown FAIL() << "Unexpected exception thrown: " << e.what(); } diff --git a/cpp/tests/io/json/json_tree.cpp b/cpp/tests/io/json/json_tree.cpp index dbf261a7f507..993fc715453d 100644 --- a/cpp/tests/io/json/json_tree.cpp +++ b/cpp/tests/io/json/json_tree.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -420,7 +420,7 @@ records_orient_tree_traversal_cpu(cudf::host_span inpu std::vector node_ids(tree.parent_node_ids.size()); std::iota(node_ids.begin(), node_ids.end(), 0); - const cuio_json::NodeIndexT row_array_children_level = is_enabled_lines ? 1 : 2; + cuio_json::NodeIndexT const row_array_children_level = is_enabled_lines ? 1 : 2; std::unordered_map list_indices; if (is_array_of_arrays) { cuio_json::NodeIndexT parent_node = -1, child_index = 0; diff --git a/cpp/tests/io/orc_test.cpp b/cpp/tests/io/orc_test.cpp index fbcd449addb5..0ecdd55d85a3 100644 --- a/cpp/tests/io/orc_test.cpp +++ b/cpp/tests/io/orc_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -2350,9 +2350,9 @@ TEST_F(OrcReaderTest, DeviceReadAsyncThrows) try { cudf::io::read_orc(read_args); // Test passes if no exception is thrown - } catch (const cudf::test::AsyncException&) { + } catch (cudf::test::AsyncException const&) { // Test passes if AsyncException is thrown (expected test exception) - } catch (const std::exception& e) { + } catch (std::exception const& e) { // Test fails if any other exception is thrown FAIL() << "Unexpected exception thrown: " << e.what(); } @@ -2374,9 +2374,9 @@ TEST_F(OrcReaderTest, DeviceWriteAsyncThrows) try { cudf::io::write_orc(write_args); // Test passes if no exception is thrown - } catch (const cudf::test::AsyncException&) { + } catch (cudf::test::AsyncException const&) { // Test passes if AsyncException is thrown (expected test exception) - } catch (const std::exception& e) { + } catch (std::exception const& e) { // Test fails if any other exception is thrown FAIL() << "Unexpected exception thrown: " << e.what(); } diff --git a/cpp/tests/io/parquet_common.cpp b/cpp/tests/io/parquet_common.cpp index 3f4696480ce5..a250379ed061 100644 --- a/cpp/tests/io/parquet_common.cpp +++ b/cpp/tests/io/parquet_common.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -671,7 +671,7 @@ std::pair create_parquet_typed_with_stats(std::string expected_metadata.column_metadata[1].set_name("col1"); expected_metadata.column_metadata[2].set_name("col2"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, written_table) .metadata(std::move(expected_metadata)) .row_group_size_rows(8000); diff --git a/cpp/tests/io/parquet_misc_test.cpp b/cpp/tests/io/parquet_misc_test.cpp index f37cb8ccfc6e..dbfc86a41988 100644 --- a/cpp/tests/io/parquet_misc_test.cpp +++ b/cpp/tests/io/parquet_misc_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -208,7 +208,7 @@ TYPED_TEST(ParquetWriterComparableTypeTest, ThreeColumnSorted) auto const expected = table_view{{col0, col1, col2}}; auto const filepath = temp_env->get_temp_filepath("ThreeColumnSorted.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .max_page_size_rows(page_size_for_ordered_tests) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN); diff --git a/cpp/tests/io/parquet_reader_test.cpp b/cpp/tests/io/parquet_reader_test.cpp index b28ec897c956..4e1725623f77 100644 --- a/cpp/tests/io/parquet_reader_test.cpp +++ b/cpp/tests/io/parquet_reader_test.cpp @@ -1421,7 +1421,7 @@ auto create_parquet_with_stats(std::string const& filename) expected_metadata.column_metadata[2].set_name("col_double"); auto const filepath = temp_env->get_temp_filepath(filename); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .metadata(std::move(expected_metadata)) .row_group_size_rows(8000) @@ -1981,7 +1981,7 @@ TEST_F(ParquetReaderTest, FilterSupported2) auto const written_table = table_view{{col0, col1, col2}}; auto const filepath = temp_env->get_temp_filepath("FilterSupported2.parquet"); { - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, written_table) .row_group_size_rows(1000); cudf::io::write_parquet(out_opts); @@ -2129,7 +2129,7 @@ TEST_F(ParquetReaderTest, FilterNoStats) auto const written_table = table_view{{col0}}; auto const filepath = temp_env->get_temp_filepath("FilterNoStats.parquet"); { - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, written_table) .row_group_size_rows(8000) .stats_level(cudf::io::statistics_freq::STATISTICS_NONE); @@ -2169,7 +2169,7 @@ TEST_F(ParquetReaderTest, FilterFloatNAN) auto const written_table = table_view{{col0, col1}}; auto const filepath = temp_env->get_temp_filepath("FilterFloatNAN.parquet"); { - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, written_table) .row_group_size_rows(8000); cudf::io::write_parquet(out_opts); @@ -3378,7 +3378,7 @@ void filter_unary_operation_typed_test() expected_metadata.column_metadata[1].set_name("col1"); expected_metadata.column_metadata[2].set_name("col2"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, written_table) .metadata(std::move(expected_metadata)) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN) @@ -4098,9 +4098,9 @@ TEST_F(ParquetReaderTest, DeviceReadAsyncThrows) try { cudf::io::read_parquet(read_args); // Test passes if no exception is thrown - } catch (const cudf::test::AsyncException&) { + } catch (cudf::test::AsyncException const&) { // Test passes if AsyncException is thrown (expected test exception) - } catch (const std::exception& e) { + } catch (std::exception const& e) { // Test fails if any other exception is thrown FAIL() << "Unexpected exception thrown: " << e.what(); } @@ -4121,9 +4121,9 @@ TEST_F(ParquetReaderTest, DeviceWriteAsyncThrows) try { cudf::io::write_parquet(write_args); // Test passes if no exception is thrown - } catch (const cudf::test::AsyncException&) { + } catch (cudf::test::AsyncException const&) { // Test passes if AsyncException is thrown (expected test exception) - } catch (const std::exception& e) { + } catch (std::exception const& e) { // Test fails if any other exception is thrown FAIL() << "Unexpected exception thrown: " << e.what(); } diff --git a/cpp/tests/io/parquet_v2_test.cpp b/cpp/tests/io/parquet_v2_test.cpp index d9139de1b47a..1cc4209af991 100644 --- a/cpp/tests/io/parquet_v2_test.cpp +++ b/cpp/tests/io/parquet_v2_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -721,7 +721,7 @@ TEST_P(ParquetV2Test, CheckColumnOffsetIndex) auto const expected = table_view{{col0, col1, col2, col3, col4, col5, col6, col7}}; auto const filepath = temp_env->get_temp_filepath("CheckColumnOffsetIndex.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN) .write_v2_headers(is_v2) @@ -819,7 +819,7 @@ TEST_P(ParquetV2Test, CheckColumnOffsetIndexNulls) auto expected = table_view{{col0, col1, col2, col3, col4, col5, col6, col7}}; auto const filepath = temp_env->get_temp_filepath("CheckColumnOffsetIndexNulls.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN) .write_v2_headers(is_v2) @@ -909,7 +909,7 @@ TEST_P(ParquetV2Test, CheckColumnOffsetIndexNullColumn) auto expected = table_view{{col0, col1, col2, col3}}; auto const filepath = temp_env->get_temp_filepath("CheckColumnOffsetIndexNullColumn.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN) .write_v2_headers(is_v2) @@ -1007,7 +1007,7 @@ TEST_P(ParquetV2Test, CheckColumnOffsetIndexStruct) table_view expected({c0, c1, *c2}); auto const filepath = temp_env->get_temp_filepath("CheckColumnOffsetIndexStruct.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN) .write_v2_headers(is_v2) @@ -1097,7 +1097,7 @@ TEST_P(ParquetV2Test, CheckColumnOffsetIndexStructNulls) table_view expected({c0, c1}); auto const filepath = temp_env->get_temp_filepath("CheckColumnOffsetIndexStructNulls.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .stats_level(cudf::io::statistics_freq::STATISTICS_COLUMN) .write_v2_headers(is_v2) diff --git a/cpp/tests/io/parquet_writer_test.cpp b/cpp/tests/io/parquet_writer_test.cpp index bcd79595049c..ec0267c3bfea 100644 --- a/cpp/tests/io/parquet_writer_test.cpp +++ b/cpp/tests/io/parquet_writer_test.cpp @@ -666,7 +666,7 @@ TEST_F(ParquetWriterTest, CheckPageRows) auto expected = table_view{{col}}; auto const filepath = temp_env->get_temp_filepath("CheckPageRows.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .max_page_size_rows(page_rows); cudf::io::write_parquet(out_opts); @@ -694,7 +694,7 @@ TEST_F(ParquetWriterTest, CheckPageRowsAdjusted) // enough for a few pages with the default 20'000 rows/page constexpr auto rows_per_page = 20'000; constexpr auto num_rows = 3 * rows_per_page; - const std::string s1(32, 'a'); + std::string const s1(32, 'a'); auto col0_elements = cudf::detail::make_counting_transform_iterator(0, [&](auto i) { return s1; }); auto col0 = cudf::test::strings_column_wrapper(col0_elements, col0_elements + num_rows); @@ -702,7 +702,7 @@ TEST_F(ParquetWriterTest, CheckPageRowsAdjusted) auto const expected = table_view{{col0}}; auto const filepath = temp_env->get_temp_filepath("CheckPageRowsAdjusted.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .max_page_size_rows(rows_per_page); cudf::io::write_parquet(out_opts); @@ -730,7 +730,7 @@ TEST_F(ParquetWriterTest, CheckPageRowsTooSmall) constexpr auto rows_per_page = 1'000; constexpr auto fragment_size = 5'000; constexpr auto num_rows = 3 * rows_per_page; - const std::string s1(32, 'a'); + std::string const s1(32, 'a'); auto col0_elements = cudf::detail::make_counting_transform_iterator(0, [&](auto i) { return s1; }); auto col0 = cudf::test::strings_column_wrapper(col0_elements, col0_elements + num_rows); @@ -738,7 +738,7 @@ TEST_F(ParquetWriterTest, CheckPageRowsTooSmall) auto const expected = table_view{{col0}}; auto const filepath = temp_env->get_temp_filepath("CheckPageRowsTooSmall.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .max_page_fragment_size(fragment_size) .max_page_size_rows(rows_per_page); @@ -777,7 +777,7 @@ TEST_F(ParquetWriterTest, Decimal32Stats) auto expected = table_view{{col0}}; auto const filepath = temp_env->get_temp_filepath("Decimal32Stats.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected); cudf::io::write_parquet(out_opts); @@ -806,7 +806,7 @@ TEST_F(ParquetWriterTest, Decimal64Stats) auto expected = table_view{{col0}}; auto const filepath = temp_env->get_temp_filepath("Decimal64Stats.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected); cudf::io::write_parquet(out_opts); @@ -838,7 +838,7 @@ TEST_F(ParquetWriterTest, Decimal128Stats) auto expected = table_view{{col0}}; auto const filepath = temp_env->get_temp_filepath("Decimal128Stats.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected); cudf::io::write_parquet(out_opts); @@ -2134,7 +2134,7 @@ TEST_F(ParquetWriterTest, Decimal128DeltaByteArray) .set_nullability(false); auto const filepath = temp_env->get_temp_filepath("Decimal128DeltaByteArray.parquet"); - const cudf::io::parquet_writer_options out_opts = + cudf::io::parquet_writer_options const out_opts = cudf::io::parquet_writer_options::builder(cudf::io::sink_info{filepath}, expected) .compression(cudf::io::compression_type::NONE) .metadata(table_metadata); diff --git a/cpp/tests/iterator/optional_iterator_test_numeric.cu b/cpp/tests/iterator/optional_iterator_test_numeric.cu index c1c369b4d369..22f8f064f110 100644 --- a/cpp/tests/iterator/optional_iterator_test_numeric.cu +++ b/cpp/tests/iterator/optional_iterator_test_numeric.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #include @@ -59,7 +59,7 @@ TYPED_TEST(NumericOptionalIteratorTest, mean_var_output) transformer_optional_meanvar transformer{}; int const column_size{50}; - const T init{0}; + T const init{0}; // data and valid arrays std::vector host_values(column_size); diff --git a/cpp/tests/iterator/pair_iterator_test_numeric.cu b/cpp/tests/iterator/pair_iterator_test_numeric.cu index ae03f0b1459d..ac536f37693a 100644 --- a/cpp/tests/iterator/pair_iterator_test_numeric.cu +++ b/cpp/tests/iterator/pair_iterator_test_numeric.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #include @@ -62,7 +62,7 @@ TYPED_TEST(NumericPairIteratorTest, mean_var_output) transformer_pair_meanvar transformer{}; int const column_size{5000}; - const T init{0}; + T const init{0}; // data and valid arrays std::vector host_values(column_size); diff --git a/cpp/tests/iterator/value_iterator_test_transform.cu b/cpp/tests/iterator/value_iterator_test_transform.cu index 19964606eb68..8551d04e4535 100644 --- a/cpp/tests/iterator/value_iterator_test_transform.cu +++ b/cpp/tests/iterator/value_iterator_test_transform.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2025, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ #include @@ -111,7 +111,7 @@ TEST_F(TransformedIteratorTest, large_size_reduction) using T = int64_t; int const column_size{1000000}; - const T init{0}; + T const init{0}; // data and valid arrays std::vector host_values(column_size); diff --git a/cpp/tests/join/join_tests.cpp b/cpp/tests/join/join_tests.cpp index 231a52085e76..f6a6633f09cb 100644 --- a/cpp/tests/join/join_tests.cpp +++ b/cpp/tests/join/join_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -1018,7 +1018,7 @@ TEST_F(JoinTest, SortMergeInnerJoinSizePerRowNoNulls) Table t0(std::move(cols0)); Table t1(std::move(cols1)); - for (const auto eq : {cudf::null_equality::EQUAL, cudf::null_equality::UNEQUAL}) { + for (auto const eq : {cudf::null_equality::EQUAL, cudf::null_equality::UNEQUAL}) { // single column { auto size_per_row = inner_join_size_per_row(t0, t1, {0}, {0}, eq, algorithm::SORT_MERGE); @@ -1182,7 +1182,7 @@ TEST_P(JoinParameterizedTest, InnerJoinNoNulls) Table t0(std::move(cols0)); Table t1(std::move(cols1)); - for (const auto eq : {cudf::null_equality::EQUAL, cudf::null_equality::UNEQUAL}) { + for (auto const eq : {cudf::null_equality::EQUAL, cudf::null_equality::UNEQUAL}) { // single column { auto result = inner_join(t0, t1, {0}, {0}, eq, algo); diff --git a/cpp/tests/join/mixed_join_tests.cu b/cpp/tests/join/mixed_join_tests.cu index 4000af524064..3300e3b56f17 100644 --- a/cpp/tests/join/mixed_join_tests.cu +++ b/cpp/tests/join/mixed_join_tests.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -202,10 +202,10 @@ struct MixedJoinTest : public cudf::test::BaseFixture { /** * Compare two join results, sorting both before comparison since order is not guaranteed. */ - void compare_join_results(const PairJoinReturn& expected_result, - const PairJoinReturn& actual_result) + void compare_join_results(PairJoinReturn const& expected_result, + PairJoinReturn const& actual_result) { - auto device_results_to_host = [](const PairJoinReturn& result) { + auto device_results_to_host = [](PairJoinReturn const& result) { // Create column views from device_uvectors auto left_view = cudf::column_view(cudf::data_type{cudf::type_to_id()}, result.first->size(), @@ -668,7 +668,7 @@ TEST_F(MixedInnerJoinTestInt32, LargeDataMultiBlockCoordination) EXPECT_EQ(result.second->size(), expected_size); EXPECT_GT(expected_size, 0); - auto to_sorted_pairs = [](const PairJoinReturn& join_result) { + auto to_sorted_pairs = [](PairJoinReturn const& join_result) { std::vector> result_pairs; for (size_t i = 0; i < join_result.first->size(); ++i) { result_pairs.emplace_back(join_result.first->element(i, cudf::get_default_stream()), diff --git a/cpp/tests/labeling/label_bins_tests.cpp b/cpp/tests/labeling/label_bins_tests.cpp index 469e9c0e82e9..88b24dfa77bb 100644 --- a/cpp/tests/labeling/label_bins_tests.cpp +++ b/cpp/tests/labeling/label_bins_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2021-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -235,7 +235,7 @@ struct RealDataBinTestFixture : public BinTestFixture { T left_edge_start_val = 0) { // Avoid testing numbers that are larger than the current type supports. - const T largest_value = (num_elements / inputs_per_bin) * 4; + T const largest_value = (num_elements / inputs_per_bin) * 4; num_elements = std::min(std::numeric_limits::max(), largest_value); unsigned int num_edges = num_elements / inputs_per_bin; diff --git a/cpp/tests/merge/merge_string_test.cpp b/cpp/tests/merge/merge_string_test.cpp index d8b01d4687cb..27c8f19ec274 100644 --- a/cpp/tests/merge/merge_string_test.cpp +++ b/cpp/tests/merge/merge_string_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -61,7 +61,7 @@ TYPED_TEST(MergeStringTest, Merge1StringKeyColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); strings_column_wrapper expectedDataWrap1({"ab", "ac", @@ -152,7 +152,7 @@ TYPED_TEST(MergeStringTest, Merge2StringKeyColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); strings_column_wrapper expectedDataWrap1({"ab", "ac", "bc", @@ -244,7 +244,7 @@ TYPED_TEST(MergeStringTest, Merge1StringKeyNullColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); // data: "ab", "ac", "bc", "bd", "cd", "ce", "de", "df" | valid: 1 1 1 1 1 1 0 0 strings_column_wrapper expectedDataWrap1({"ab", @@ -352,7 +352,7 @@ TYPED_TEST(MergeStringTest, Merge2StringKeyNullColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); strings_column_wrapper expectedDataWrap1({"ab", "ac", "bc", diff --git a/cpp/tests/merge/merge_test.cpp b/cpp/tests/merge/merge_test.cpp index f3c53425faf2..0302846ec96e 100644 --- a/cpp/tests/merge/merge_test.cpp +++ b/cpp/tests/merge/merge_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -259,7 +259,7 @@ TYPED_TEST(MergeTest_, MergeWithEmptyColumn) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); cudf::test::fixed_width_column_wrapper expectedDataWrap1( @@ -324,7 +324,7 @@ TYPED_TEST(MergeTest_, Merge1KeyColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); auto seq_out1 = cudf::detail::make_counting_transform_iterator(0, [outputRows](auto row) { if (cudf::type_to_id() == cudf::type_id::BOOL8) { @@ -402,7 +402,7 @@ TYPED_TEST(MergeTest_, Merge2KeyColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); auto seq_out1 = cudf::detail::make_counting_transform_iterator(0, [outputRows](auto row) { if (cudf::type_to_id() == cudf::type_id::BOOL8) { @@ -489,8 +489,8 @@ TYPED_TEST(MergeTest_, Merge1KeyNullColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); - const cudf::size_type column1TotalNulls = + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const column1TotalNulls = a_left_tbl_cview.null_count() + a_right_tbl_cview.null_count(); // data: 0 1 2 3 4 5 6 7 | valid: 1 1 1 1 1 1 0 0 @@ -573,7 +573,7 @@ TYPED_TEST(MergeTest_, Merge2KeyNullColumns) cudf::column_view const& a_left_tbl_cview{static_cast(leftColWrap1)}; cudf::column_view const& a_right_tbl_cview{static_cast(rightColWrap1)}; - const cudf::size_type outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); + cudf::size_type const outputRows = a_left_tbl_cview.size() + a_right_tbl_cview.size(); // data: 0 0 1 1 2 2 3 3 | valid: 1 1 1 1 1 1 1 1 auto seq_out1 = cudf::detail::make_counting_transform_iterator(0, [outputRows](auto row) { @@ -651,7 +651,7 @@ TYPED_TEST(MergeTest_, NMerge1KeyColumns) std::unique_ptr p_outputTable; EXPECT_NO_THROW(p_outputTable = cudf::merge(tables, key_cols, column_order, null_precedence)); - const cudf::size_type outputRows = inputRows * num_tables; + cudf::size_type const outputRows = inputRows * num_tables; auto seq_out1 = cudf::detail::make_counting_transform_iterator(0, [](auto row) { if (cudf::type_to_id() == cudf::type_id::BOOL8) { diff --git a/cpp/tests/reductions/reduction_tests.cpp b/cpp/tests/reductions/reduction_tests.cpp index 67de80fa60e5..bd44f651de04 100644 --- a/cpp/tests/reductions/reduction_tests.cpp +++ b/cpp/tests/reductions/reduction_tests.cpp @@ -905,7 +905,7 @@ struct ReductionMultiStepErrorCheck : public ReductionTest { reduce_aggregation const& agg, cudf::data_type output_dtype) { - const cudf::column_view underlying_column = col; + cudf::column_view const underlying_column = col; auto statement = [&]() { cudf::reduce(underlying_column, agg, output_dtype); }; if (succeeded_condition) { diff --git a/cpp/tests/replace/replace_tests.cpp b/cpp/tests/replace/replace_tests.cpp index 343aa80e9fe9..3c0185a46fd1 100644 --- a/cpp/tests/replace/replace_tests.cpp +++ b/cpp/tests/replace/replace_tests.cpp @@ -2,7 +2,7 @@ /* * SPDX-FileCopyrightText: Copyright 2018 BlazingDB, Inc. * SPDX-FileCopyrightText: Copyright 2018 Cristhian Alberto Gonzales Castillo - * SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ // clang-format on @@ -501,8 +501,8 @@ TYPED_TEST(ReplaceTest, NullsInBoth) // Test with much larger data sets TYPED_TEST(ReplaceTest, LargeScaleReplaceTest) { - const size_t DATA_SIZE = 1000000; - const size_t REPLACE_SIZE = 10000; + size_t const DATA_SIZE = 1000000; + size_t const REPLACE_SIZE = 10000; thrust::host_vector input_column(DATA_SIZE); std::generate(std::begin(input_column), std::end(input_column), []() { diff --git a/cpp/tests/rolling/grouped_rolling_test.cpp b/cpp/tests/rolling/grouped_rolling_test.cpp index 1b24aa4c8014..b568a909ff0e 100644 --- a/cpp/tests/rolling/grouped_rolling_test.cpp +++ b/cpp/tests/rolling/grouped_rolling_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -22,7 +22,7 @@ #include -const std::string cuda_func{ +std::string const cuda_func{ R"***( template __device__ void CUDA_GENERIC_AGGREGATOR(OutType *ret, InType *in_col, cudf::size_type start, @@ -35,7 +35,7 @@ const std::string cuda_func{ } )***"}; -const std::string ptx_func{ +std::string const ptx_func{ R"***( // // Generated by NVIDIA NVVM Compiler @@ -435,17 +435,17 @@ class GroupedRollingSumEdgeCaseTest : public cudf::test::BaseFixture {}; TEST_F(GroupedRollingErrorTest, NegativeMinPeriods) { // Construct agg column. - const std::vector col_data{0, 1, 2, 0, 4}; - const std::vector col_valid{true, true, true, false, true}; + std::vector const col_data{0, 1, 2, 0, 4}; + std::vector const col_valid{true, true, true, false, true}; cudf::test::fixed_width_column_wrapper input{ col_data.begin(), col_data.end(), col_valid.begin()}; // Construct Grouping keys table-view. auto const N_ELEMENTS{col_data.size()}; - const std::vector grouping_key_vec(N_ELEMENTS, 0); + std::vector const grouping_key_vec(N_ELEMENTS, 0); cudf::test::fixed_width_column_wrapper grouping_keys_col( grouping_key_vec.begin(), grouping_key_vec.end(), col_valid.begin()); - const cudf::table_view grouping_keys{std::vector{grouping_keys_col}}; + cudf::table_view const grouping_keys{std::vector{grouping_keys_col}}; EXPECT_THROW( cudf::grouped_rolling_window( @@ -457,7 +457,7 @@ TEST_F(GroupedRollingErrorTest, EmptyInput) { cudf::test::fixed_width_column_wrapper empty_col{}; std::unique_ptr output; - const cudf::table_view grouping_keys{std::vector{}}; + cudf::table_view const grouping_keys{std::vector{}}; EXPECT_NO_THROW( output = cudf::grouped_rolling_window( grouping_keys, empty_col, 2, 0, 2, *cudf::make_sum_aggregation())); @@ -483,7 +483,7 @@ TEST_F(GroupedRollingErrorTest, SumTimestampNotSupported) // Construct table-view of grouping keys. std::vector grouping_keys_vec(size, 0); // `size` elements, each == 0. - const cudf::table_view grouping_keys{ + cudf::table_view const grouping_keys{ std::vector{cudf::test::fixed_width_column_wrapper( grouping_keys_vec.begin(), grouping_keys_vec.end())}}; @@ -514,8 +514,8 @@ TYPED_TEST_SUITE(GroupedRollingTest, cudf::test::FixedWidthTypesWithoutFixedPoin TYPED_TEST(GroupedRollingTest, SimplePartitionedStaticWindowsWithGroupKeys) { auto const col_data = {0, 10, 20, 30, 40, 50, 60, 70, 80, 90}; - const cudf::size_type DATA_SIZE{static_cast(col_data.size())}; - const std::vector col_mask(DATA_SIZE, true); + cudf::size_type const DATA_SIZE{static_cast(col_data.size())}; + std::vector const col_mask(DATA_SIZE, true); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -527,11 +527,11 @@ TYPED_TEST(GroupedRollingTest, SimplePartitionedStaticWindowsWithGroupKeys) int i{0}; std::generate_n( std::back_inserter(key_1_vec), DATA_SIZE, [&i]() { return i++ / 4; }); // Groups of 4. - const cudf::test::fixed_width_column_wrapper key_0(key_0_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_0(key_0_vec.begin(), key_0_vec.end()); - const cudf::test::fixed_width_column_wrapper key_1(key_1_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_1(key_1_vec.begin(), key_1_vec.end()); - const cudf::table_view grouping_keys{std::vector{key_0, key_1}}; + cudf::table_view const grouping_keys{std::vector{key_0, key_1}}; cudf::size_type preceding_window = 2; cudf::size_type following_window = 1; @@ -545,12 +545,12 @@ TYPED_TEST(GroupedRollingTest, SimplePartitionedStaticWindowWithNoGroupKeys) { auto const col_data = cudf::test::make_type_param_vector({0, 10, 20, 30, 40, 50, 60, 70, 80, 90}); - const cudf::size_type DATA_SIZE{static_cast(col_data.size())}; - const std::vector col_mask(DATA_SIZE, true); + cudf::size_type const DATA_SIZE{static_cast(col_data.size())}; + std::vector const col_mask(DATA_SIZE, true); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); - const cudf::table_view grouping_keys{std::vector{}}; + cudf::table_view const grouping_keys{std::vector{}}; cudf::size_type preceding_window = 2; cudf::size_type following_window = 1; @@ -565,8 +565,8 @@ TYPED_TEST(GroupedRollingTest, AllInvalid) { auto const col_data = cudf::test::make_type_param_vector({0, 10, 20, 30, 40, 50, 60, 70, 80, 90}); - const cudf::size_type DATA_SIZE{static_cast(col_data.size())}; - const std::vector col_mask(DATA_SIZE, false); + cudf::size_type const DATA_SIZE{static_cast(col_data.size())}; + std::vector const col_mask(DATA_SIZE, false); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -578,11 +578,11 @@ TYPED_TEST(GroupedRollingTest, AllInvalid) int i{0}; std::generate_n( std::back_inserter(key_1_vec), DATA_SIZE, [&i]() { return i++ / 4; }); // Groups of 4. - const cudf::test::fixed_width_column_wrapper key_0(key_0_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_0(key_0_vec.begin(), key_0_vec.end()); - const cudf::test::fixed_width_column_wrapper key_1(key_1_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_1(key_1_vec.begin(), key_1_vec.end()); - const cudf::table_view grouping_keys{std::vector{key_0, key_1}}; + cudf::table_view const grouping_keys{std::vector{key_0, key_1}}; cudf::size_type preceding_window = 2; cudf::size_type following_window = 1; @@ -596,8 +596,8 @@ TYPED_TEST(GroupedRollingTest, AllInvalid) TYPED_TEST(GroupedRollingTest, ZeroWindow) { auto const col_data = {0, 10, 20, 30, 40, 50, 60, 70, 80, 90}; - const cudf::size_type DATA_SIZE{static_cast(col_data.size())}; - const std::vector col_mask(DATA_SIZE, true); + cudf::size_type const DATA_SIZE{static_cast(col_data.size())}; + std::vector const col_mask(DATA_SIZE, true); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -609,11 +609,11 @@ TYPED_TEST(GroupedRollingTest, ZeroWindow) int i{0}; std::generate_n( std::back_inserter(key_1_vec), DATA_SIZE, [&i]() { return i++ / 4; }); // Groups of 4. - const cudf::test::fixed_width_column_wrapper key_0(key_0_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_0(key_0_vec.begin(), key_0_vec.end()); - const cudf::test::fixed_width_column_wrapper key_1(key_1_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_1(key_1_vec.begin(), key_1_vec.end()); - const cudf::table_view grouping_keys{std::vector{key_0, key_1}}; + cudf::table_view const grouping_keys{std::vector{key_0, key_1}}; cudf::size_type preceding_window = 1; cudf::size_type following_window = 0; @@ -706,9 +706,9 @@ TEST_F(GroupedRollingTestStrings, StringsUnsupportedOperators) cudf::test::strings_column_wrapper input{{"This", "is", "not", "", "string", ""}, {true, true, true, false, true, false}}; - const cudf::size_type DATA_SIZE{static_cast(input).size()}; - const std::vector key_col_vec(DATA_SIZE, 0); - const cudf::table_view key_cols{ + cudf::size_type const DATA_SIZE{static_cast(input).size()}; + std::vector const key_col_vec(DATA_SIZE, 0); + cudf::table_view const key_cols{ std::vector{cudf::test::fixed_width_column_wrapper( key_col_vec.begin(), key_col_vec.end())}}; @@ -1166,9 +1166,9 @@ TYPED_TEST_SUITE(GroupedTimeRangeRollingTest, cudf::test::FixedWidthTypesWithout TYPED_TEST(GroupedTimeRangeRollingTest, SimplePartitionedStaticWindowsWithGroupKeysAndTimeRangesAscending) { - const cudf::size_type DATA_SIZE{static_cast(18)}; - const std::vector col_data(DATA_SIZE, 1); - const std::vector col_mask(DATA_SIZE, true); + cudf::size_type const DATA_SIZE{static_cast(18)}; + std::vector const col_data(DATA_SIZE, 1); + std::vector const col_mask(DATA_SIZE, true); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -1180,11 +1180,11 @@ TYPED_TEST(GroupedTimeRangeRollingTest, int i{0}; std::generate_n( std::back_inserter(key_1_vec), DATA_SIZE, [&i]() { return i++ / 6; }); // Groups of 6. - const cudf::test::fixed_width_column_wrapper key_0(key_0_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_0(key_0_vec.begin(), key_0_vec.end()); - const cudf::test::fixed_width_column_wrapper key_1(key_1_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_1(key_1_vec.begin(), key_1_vec.end()); - const cudf::table_view grouping_keys{std::vector{key_0, key_1}}; + cudf::table_view const grouping_keys{std::vector{key_0, key_1}}; cudf::size_type preceding_window_in_days = 1; cudf::size_type following_window_in_days = 1; @@ -1208,9 +1208,9 @@ TYPED_TEST(GroupedTimeRangeRollingTest, TYPED_TEST(GroupedTimeRangeRollingTest, SimplePartitionedStaticWindowsWithGroupKeysAndTimeRangesDescending) { - const cudf::size_type DATA_SIZE{static_cast(18)}; - const std::vector col_data(DATA_SIZE, 1); - const std::vector col_mask(DATA_SIZE, true); + cudf::size_type const DATA_SIZE{static_cast(18)}; + std::vector const col_data(DATA_SIZE, 1); + std::vector const col_mask(DATA_SIZE, true); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -1222,11 +1222,11 @@ TYPED_TEST(GroupedTimeRangeRollingTest, int i{0}; std::generate_n( std::back_inserter(key_1_vec), DATA_SIZE, [&i]() { return i++ / 6; }); // Groups of 6. - const cudf::test::fixed_width_column_wrapper key_0(key_0_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_0(key_0_vec.begin(), key_0_vec.end()); - const cudf::test::fixed_width_column_wrapper key_1(key_1_vec.begin(), + cudf::test::fixed_width_column_wrapper const key_1(key_1_vec.begin(), key_1_vec.end()); - const cudf::table_view grouping_keys{std::vector{key_0, key_1}}; + cudf::table_view const grouping_keys{std::vector{key_0, key_1}}; cudf::size_type preceding_window_in_days = 1; cudf::size_type following_window_in_days = 2; @@ -1248,13 +1248,13 @@ TYPED_TEST(GroupedTimeRangeRollingTest, TYPED_TEST(GroupedTimeRangeRollingTest, SimplePartitionedStaticWindowsWithNoGroupingKeys) { - const cudf::size_type DATA_SIZE{static_cast(6)}; - const std::vector col_data(DATA_SIZE, 1); - const std::vector col_mask(DATA_SIZE, true); + cudf::size_type const DATA_SIZE{static_cast(6)}; + std::vector const col_data(DATA_SIZE, 1); + std::vector const col_mask(DATA_SIZE, true); cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); - const cudf::table_view grouping_keys{std::vector{}}; + cudf::table_view const grouping_keys{std::vector{}}; cudf::size_type preceding_window_in_days = 1; cudf::size_type following_window_in_days = 1; diff --git a/cpp/tests/rolling/rolling_test.cpp b/cpp/tests/rolling/rolling_test.cpp index 6eb2c03c79f5..a2f178499388 100644 --- a/cpp/tests/rolling/rolling_test.cpp +++ b/cpp/tests/rolling/rolling_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -620,8 +620,8 @@ class RollingSumEdgeCaseTest : public cudf::test::BaseFixture {}; // negative sizes TEST_F(RollingErrorTest, NegativeMinPeriods) { - const std::vector col_data = {0, 1, 2, 0, 4}; - const std::vector col_valid = {1, 1, 1, 0, 1}; + std::vector const col_data = {0, 1, 2, 0, 4}; + std::vector const col_valid = {1, 1, 1, 0, 1}; cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_valid.begin()); @@ -633,8 +633,8 @@ TEST_F(RollingErrorTest, NegativeMinPeriods) // window array size mismatch TEST_F(RollingErrorTest, WindowArraySizeMismatch) { - const std::vector col_data = {0, 1, 2, 0, 4}; - const std::vector col_valid = {1, 1, 1, 0, 1}; + std::vector const col_data = {0, 1, 2, 0, 4}; + std::vector const col_valid = {1, 1, 1, 0, 1}; cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_valid.begin()); @@ -815,7 +815,7 @@ TYPED_TEST(RollingTest, SimpleStatic) { // https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.rolling.html auto const col_data = cudf::test::make_type_param_vector({0, 1, 2, 0, 4}); - const std::vector col_mask = {1, 1, 1, 0, 1}; + std::vector const col_mask = {1, 1, 1, 0, 1}; cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -879,7 +879,7 @@ TYPED_TEST(RollingVarStdTest, SimpleStaticVarianceStd) auto const col_data = cudf::test::make_type_param_vector({XXX, XXX, 9, 5, XXX, XXX, XXX, 0, 8, 5, 8}); - const std::vector col_mask = {0, 0, 1, 1, 0, 0, 0, 1, 1, 1, 1}; + std::vector const col_mask = {0, 0, 1, 1, 0, 0, 0, 1, 1, 1, 1}; auto const expected_var = cudf::is_boolean() @@ -890,7 +890,7 @@ TYPED_TEST(RollingVarStdTest, SimpleStaticVarianceStd) return std::sqrt(x); }); - const std::vector expected_mask = {0, /* all null window */ + std::vector const expected_mask = {0, /* all null window */ 1, /* 0 div 0, nan */ 1, 1, @@ -942,7 +942,7 @@ TEST_F(RollingtVarStdTestUntyped, SimpleStaticVarianceStdInfNaN) auto const col_data = cudf::test::make_type_param_vector({5., 4., XXX, inf, 4., 8., 0., nan, XXX, 5.}); - const std::vector col_mask = {1, 1, 0, 1, 1, 1, 1, 1, 0, 1}; + std::vector const col_mask = {1, 1, 0, 1, 1, 1, 1, 1, 0, 1}; auto const expected_var = std::vector{nan, 0.5, 0.5, nan, nan, nan, 16, nan, nan, nan}; @@ -951,7 +951,7 @@ TEST_F(RollingtVarStdTestUntyped, SimpleStaticVarianceStdInfNaN) return std::sqrt(x); }); - const std::vector expected_mask = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1}; + std::vector const expected_mask = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1}; cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -1004,7 +1004,7 @@ TYPED_TEST(RollingTest, SimpleDynamic) { // https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.rolling.html auto const col_data = cudf::test::make_type_param_vector({0, 1, 2, 0, 4}); - const std::vector col_mask = {1, 1, 1, 0, 1}; + std::vector const col_mask = {1, 1, 1, 0, 1}; cudf::test::fixed_width_column_wrapper input( col_data.begin(), col_data.end(), col_mask.begin()); @@ -1236,7 +1236,7 @@ TEST_F(RollingTestStrings, StringsUnsupportedOperators) }*/ struct RollingTestUdf : public cudf::test::BaseFixture { - const std::string cuda_func{ + std::string const cuda_func{ R"***( template __device__ void CUDA_GENERIC_AGGREGATOR(OutType *ret, InType *in_col, cudf::size_type start, @@ -1249,7 +1249,7 @@ struct RollingTestUdf : public cudf::test::BaseFixture { } )***"}; - const std::string ptx_func{ + std::string const ptx_func{ R"***( // // Generated by NVIDIA NVVM Compiler diff --git a/cpp/tests/round/round_tests.cpp b/cpp/tests/round/round_tests.cpp index 47862a7223a0..14f1bb225fb3 100644 --- a/cpp/tests/round/round_tests.cpp +++ b/cpp/tests/round/round_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2020-2025, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -322,7 +322,7 @@ TYPED_TEST(RoundTestsFixedPointTypes, TestScaleMovementExceedingMaxPrecision) cudf::round_decimal(input, -target_scale, cudf::rounding_method::HALF_EVEN); CUDF_TEST_EXPECT_COLUMNS_EQUAL(expected_even, result_even->view()); - const std::initializer_list validity = { + std::initializer_list const validity = { true, false, true, true, true, false, false, true, true, true, true, false}; auto const input_null = fp_wrapper{{14, 15, 16, 24, 25, 26, -14, -15, -16, -24, -25, -26}, validity, scale_type{1}}; diff --git a/cpp/tests/streams/copying_test.cpp b/cpp/tests/streams/copying_test.cpp index 41a1e2ef183a..502f34606a9f 100644 --- a/cpp/tests/streams/copying_test.cpp +++ b/cpp/tests/streams/copying_test.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -72,8 +72,8 @@ TEST_F(CopyingTest, ScatterTable) TEST_F(CopyingTest, ScatterScalars) { auto const source = cudf::scalar_type_t(100, true, cudf::test::get_default_stream()); - std::reference_wrapper slr_ref{source}; - std::vector> source_vector{slr_ref}; + std::reference_wrapper slr_ref{source}; + std::vector> source_vector{slr_ref}; cudf::test::fixed_width_column_wrapper target({10, 20, 30, 40, 50, 60, 70, 80}); cudf::test::fixed_width_column_wrapper scatter_map({-3, 3, 1, -1}); @@ -146,7 +146,7 @@ TEST_F(CopyingTest, CopyRange) source(source_elements, source_elements + size); cudf::mutable_column_view target_view{target}; - const cudf::column_view immutable_view{target_view}; + cudf::column_view const immutable_view{target_view}; cudf::size_type source_begin{9}; cudf::size_type source_end{size - 50}; @@ -268,7 +268,7 @@ TEST_F(CopyingTest, BooleanMaskScatter) TEST_F(CopyingTest, BooleanMaskScatterScalars) { - std::vector> scalars; + std::vector> scalars; auto s = cudf::scalar_type_t(1, true, cudf::test::get_default_stream()); scalars.emplace_back(s); cudf::test::fixed_width_column_wrapper target( diff --git a/cpp/tests/strings/array_tests.cpp b/cpp/tests/strings/array_tests.cpp index 4bd1141f236a..5ccd725df8b2 100644 --- a/cpp/tests/strings/array_tests.cpp +++ b/cpp/tests/strings/array_tests.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -180,7 +180,7 @@ TEST_F(StringsColumnTest, ScatterScalar) cudf::test::fixed_width_column_wrapper scatter_map({0, 5}); cudf::string_scalar scalar("__"); - auto source = std::vector>({scalar}); + auto source = std::vector>({scalar}); auto results = cudf::scatter(source, scatter_map, cudf::table_view({target})); cudf::test::strings_column_wrapper expected({"__", "bb", "", "", "aa", "__", "ééé"}, @@ -198,7 +198,7 @@ TEST_F(StringsColumnTest, ScatterZeroSizeStringsColumn) cudf::test::expect_column_empty(results->view().column(0)); cudf::string_scalar scalar(""); - auto scalar_source = std::vector>({scalar}); + auto scalar_source = std::vector>({scalar}); results = cudf::scatter(scalar_source, scatter_map, cudf::table_view({target})); cudf::test::expect_column_empty(results->view().column(0)); } diff --git a/cpp/tests/utilities/identify_stream_usage.cpp b/cpp/tests/utilities/identify_stream_usage.cpp index 61abc4577da8..00249b830346 100644 --- a/cpp/tests/utilities/identify_stream_usage.cpp +++ b/cpp/tests/utilities/identify_stream_usage.cpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -130,17 +130,17 @@ class sanitizer_subscriber { static void check_result(SanitizerResult result); template - static void check_stream_arg(const Sanitizer_CallbackData* cbdata); + static void check_stream_arg(Sanitizer_CallbackData const* cbdata); - void callback(Sanitizer_CallbackDomain domain, Sanitizer_CallbackId cbid, const void* cbdata); + void callback(Sanitizer_CallbackDomain domain, Sanitizer_CallbackId cbid, void const* cbdata); }; sanitizer_subscriber::sanitizer_subscriber() { - const auto cb = [](void* userdata, + auto const cb = [](void* userdata, Sanitizer_CallbackDomain domain, Sanitizer_CallbackId cbid, - const void* cbdata) { + void const* cbdata) { auto* subscriber = static_cast(userdata); subscriber->callback(domain, cbid, cbdata); }; @@ -154,16 +154,16 @@ sanitizer_subscriber::~sanitizer_subscriber() { check_result(sanitizerUnsubscrib void sanitizer_subscriber::check_result(SanitizerResult result) { if (result != SANITIZER_SUCCESS) { - const char* str; + char const* str; sanitizerGetResultString(result, &str); throw std::runtime_error(std::string("Sanitizer error: ") + str); } } template -void sanitizer_subscriber::check_stream_arg(const Sanitizer_CallbackData* cbdata) +void sanitizer_subscriber::check_stream_arg(Sanitizer_CallbackData const* cbdata) { - const auto* args = static_cast(cbdata->functionParams); + auto const* args = static_cast(cbdata->functionParams); check_stream_and_error(args->*Field); } @@ -183,7 +183,7 @@ void sanitizer_subscriber::callback(Sanitizer_CallbackDomain domain, { switch (domain) { case SANITIZER_CB_DOMAIN_RUNTIME_API: { - const auto* runtime_cbdata = static_cast(cbdata); + auto const* runtime_cbdata = static_cast(cbdata); if (runtime_cbdata->callbackSite == SANITIZER_API_ENTER) { switch (cbid) { diff --git a/cpp/tests/wrappers/timestamps_test.cu b/cpp/tests/wrappers/timestamps_test.cu index c84ac54f67e3..e3af3a50ff54 100644 --- a/cpp/tests/wrappers/timestamps_test.cu +++ b/cpp/tests/wrappers/timestamps_test.cu @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ @@ -45,7 +45,7 @@ struct compare_chrono_elements_to_primitive_representation { } template ()>* = nullptr> - __host__ __device__ bool operator()(const int32_t element_index) + __host__ __device__ bool operator()(int32_t const element_index) { using Primitive = typename ChronoT::rep; auto primitive = primitives.element(element_index); @@ -54,7 +54,7 @@ struct compare_chrono_elements_to_primitive_representation { } template ()>* = nullptr> - __host__ __device__ bool operator()(const int32_t element_index) + __host__ __device__ bool operator()(int32_t const element_index) { using Primitive = typename ChronoT::rep; auto primitive = primitives.element(element_index); @@ -109,7 +109,7 @@ struct compare_chrono_elements { { } - __host__ __device__ bool operator()(const int32_t element_index) + __host__ __device__ bool operator()(int32_t const element_index) { auto lhs_elt = lhs.element(element_index); auto rhs_elt = rhs.element(element_index); diff --git a/java/src/main/native/src/AggregationJni.cpp b/java/src/main/native/src/AggregationJni.cpp index 5734c3d5ac52..6a88152dcd29 100644 --- a/java/src/main/native/src/AggregationJni.cpp +++ b/java/src/main/native/src/AggregationJni.cpp @@ -211,7 +211,7 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_Aggregation_createQuantAgg(JNIEnv* e { cudf::jni::auto_set_device(env); - const cudf::jni::native_jdoubleArray quantiles(env, j_quantiles); + cudf::jni::native_jdoubleArray const quantiles(env, j_quantiles); std::vector quants(quantiles.data(), quantiles.data() + quantiles.size()); cudf::interpolation interp = static_cast(j_method); diff --git a/java/src/main/native/src/TableJni.cpp b/java/src/main/native/src/TableJni.cpp index c744c8acad18..3fbe71f3235e 100644 --- a/java/src/main/native/src/TableJni.cpp +++ b/java/src/main/native/src/TableJni.cpp @@ -223,7 +223,7 @@ class native_arrow_ipc_writer_handle final { return col_meta; } - std::string& get_column_name(const size_t idx) + std::string& get_column_name(size_t const idx) { if (idx < 0 || idx >= column_names.size()) { throw cudf::jni::jni_exception("Missing names for columns or nested struct columns"); @@ -1199,13 +1199,13 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_Table_sortOrder(JNIEnv* env, cudf::jni::native_jpointerArray n_sort_keys_columns(env, j_sort_keys_columns); jsize num_columns = n_sort_keys_columns.size(); - const cudf::jni::native_jbooleanArray n_is_descending(env, j_is_descending); + cudf::jni::native_jbooleanArray const n_is_descending(env, j_is_descending); jsize num_columns_is_desc = n_is_descending.size(); JNI_ARG_CHECK( env, num_columns_is_desc == num_columns, "columns and is_descending lengths don't match", 0); - const cudf::jni::native_jbooleanArray n_are_nulls_smallest(env, j_are_nulls_smallest); + cudf::jni::native_jbooleanArray const n_are_nulls_smallest(env, j_are_nulls_smallest); jsize num_columns_null_smallest = n_are_nulls_smallest.size(); JNI_ARG_CHECK(env, @@ -1243,13 +1243,13 @@ JNIEXPORT jlongArray JNICALL Java_ai_rapids_cudf_Table_orderBy(JNIEnv* env, cudf::jni::native_jpointerArray n_sort_keys_columns(env, j_sort_keys_columns); jsize num_columns = n_sort_keys_columns.size(); - const cudf::jni::native_jbooleanArray n_is_descending(env, j_is_descending); + cudf::jni::native_jbooleanArray const n_is_descending(env, j_is_descending); jsize num_columns_is_desc = n_is_descending.size(); JNI_ARG_CHECK( env, num_columns_is_desc == num_columns, "columns and is_descending lengths don't match", 0); - const cudf::jni::native_jbooleanArray n_are_nulls_smallest(env, j_are_nulls_smallest); + cudf::jni::native_jbooleanArray const n_are_nulls_smallest(env, j_are_nulls_smallest); jsize num_columns_null_smallest = n_are_nulls_smallest.size(); JNI_ARG_CHECK(env, @@ -1290,9 +1290,9 @@ JNIEXPORT jlongArray JNICALL Java_ai_rapids_cudf_Table_merge(JNIEnv* env, cudf::jni::auto_set_device(env); cudf::jni::native_jpointerArray n_table_handles(env, j_table_handles); - const cudf::jni::native_jintArray n_sort_key_indexes(env, j_sort_key_indexes); + cudf::jni::native_jintArray const n_sort_key_indexes(env, j_sort_key_indexes); jsize num_columns = n_sort_key_indexes.size(); - const cudf::jni::native_jbooleanArray n_is_descending(env, j_is_descending); + cudf::jni::native_jbooleanArray const n_is_descending(env, j_is_descending); jsize num_columns_is_desc = n_is_descending.size(); JNI_ARG_CHECK(env, @@ -1300,7 +1300,7 @@ JNIEXPORT jlongArray JNICALL Java_ai_rapids_cudf_Table_merge(JNIEnv* env, "columns and is_descending lengths don't match", NULL); - const cudf::jni::native_jbooleanArray n_are_nulls_smallest(env, j_are_nulls_smallest); + cudf::jni::native_jbooleanArray const n_are_nulls_smallest(env, j_are_nulls_smallest); jsize num_columns_null_smallest = n_are_nulls_smallest.size(); JNI_ARG_CHECK(env,